From patchwork Thu Mar 9 16:01:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 67007 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp389296wrd; Thu, 9 Mar 2023 08:34:47 -0800 (PST) X-Google-Smtp-Source: AK7set/U9UdNHq/Y2dxb1gZcVMNQI0bu9QBHDjWoCQZ2Q6xnsAOveXeTd7ilnKWZX8dqSVXLq5uc X-Received: by 2002:a05:6e02:156d:b0:316:5625:242 with SMTP id k13-20020a056e02156d00b0031656250242mr18354004ilu.3.1678379686746; Thu, 09 Mar 2023 08:34:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678379686; cv=none; d=google.com; s=arc-20160816; b=swnlTezW4q9Yzu67fYcD1xj4brFqfB1pUhNQnLCQA1Vh+5fDErprX1Y+IPCF80sP2I Xga41M21/Qs3OLJwzp/s4AtOdU3/NyWCD8a7IZT7IwmQwR3HH6vYSRT0qSupPWrmxEnm KUKrSxk7UQq1bXtDI5/g6hrNO3V9R6nk8nk6hUonKW6NmW+tcfNPNkIFul4/Pp7YA0eD 3+zBPTJvmWtm6iQeNNuhRVSpkChojIB3VG9m1Vd6/GJ65MKMMrSTtBZDW/ff6qsjOs9z fvPLIDYhstSilLIc9u0HEeH7vINRK+AtZwPx04Q7exaAsut1l4GcHhHu+eYEwVoJyPKn T9cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=c7fzbHMZo/4t6EopunsYCvjOPtf7sTkieu2cfrSqxh4=; b=fHVH0KTZkxF46rAFM4xwcJwNWu4kTUXSTpd3vTeuHmI971A2eqhOKJbTOfppnr+CqS AgJYtL6MR4sMxRkoNZwCrLLIwsMD2ctaqIrtp+SmHW2rtIrR6SPK4a3fUowNKiH9V9la fKTYn0CCYOTkhSrMrIrYlRl4EYeoXojSLAg2H+zWCvmSrgZl3107hdDV+r73mzAOIQwG 37q+6DuaCsz66mwwwW5GYmcE18VDCJ9QcNFo6NmrqotBIprBBpAXWLdwN28Fh+65vLO7 skNU3MORy78UTk0kqxOWiV8m0HlCaw5Z45+lrRmC9QsTmxGJlG3YreUPaujYQD81McWD ZHuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AcjpdxWm; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=zXFSwT+R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17-20020a056638023100b003c4e1a4de3asi19072149jaq.111.2023.03.09.08.34.32; Thu, 09 Mar 2023 08:34:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AcjpdxWm; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=zXFSwT+R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjCIQGg (ORCPT + 99 others); Thu, 9 Mar 2023 11:06:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231644AbjCIQCX (ORCPT ); Thu, 9 Mar 2023 11:02:23 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CD83F4B43; Thu, 9 Mar 2023 08:02:22 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0E85422144; Thu, 9 Mar 2023 16:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678377741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c7fzbHMZo/4t6EopunsYCvjOPtf7sTkieu2cfrSqxh4=; b=AcjpdxWm5zvGSYbFoeuEUnP4boRb5za5KSjPBQem5PqUCIGbTC1YQyR0bzLfnSXfEcfp9S vWozmmoOveM6DUzJIicy12AOaBWeCqhkuylaJ1kIHgqynt7NsGG5AeIERZ5raI1UEhL72P wPGK+lXTR1+AXZKJkrDaAmewHFLLSfQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678377741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c7fzbHMZo/4t6EopunsYCvjOPtf7sTkieu2cfrSqxh4=; b=zXFSwT+RVObgE93n73DBA0+4VkgBUJV055XbmNaTwRb7OgJFPKZRLUApY764qMPHJl8HXL cL0gZLXVd47G5BAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A79A01391B; Thu, 9 Mar 2023 16:02:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AJoaKAwDCmQHbgAAMHmgww (envelope-from ); Thu, 09 Mar 2023 16:02:20 +0000 From: Thomas Zimmermann To: deller@gmx.de, geert+renesas@glider.be, timur@kernel.org, rdunlap@infradead.org, paulus@samba.org, benh@kernel.crashing.org, linux@armlinux.org.uk, pjones@redhat.com, adaplas@gmail.com, s.hauer@pengutronix.de, shawnguo@kernel.org, mbroemme@libmpq.org, thomas@winischhofer.net, James.Bottomley@HansenPartnership.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, corbet@lwn.net Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 040/101] fbdev/imxfb: Parse option string with struct option_iter Date: Thu, 9 Mar 2023 17:01:00 +0100 Message-Id: <20230309160201.5163-41-tzimmermann@suse.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230309160201.5163-1-tzimmermann@suse.de> References: <20230309160201.5163-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759908658287942681?= X-GMAIL-MSGID: =?utf-8?q?1759908658287942681?= Use struct option_iter to walk over the individual options in the driver's option string. Replaces the hand-written strsep() loop with a clean interface. The helpers for struct option_iter handle empty option strings and empty options transparently. The struct's _init and _release functions duplicate and release the option string's memory buffer as needed. Done in preparation of constifying the option string. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/imxfb.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index aad7d447385c..d4e347aca0b0 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -14,6 +14,7 @@ * linux-arm-kernel@lists.arm.linux.org.uk */ +#include #include #include #include @@ -845,21 +846,21 @@ static struct lcd_ops imxfb_lcd_ops = { static int imxfb_setup(struct platform_device *pdev) { - char *opt, *options = NULL; + char *options = NULL; + struct option_iter iter; + char *opt; if (fb_get_options("imxfb", &options)) return -ENODEV; - if (!options || !*options) - return 0; - - while ((opt = strsep(&options, ",")) != NULL) { - if (!*opt) - continue; + option_iter_init(&iter, options); + while (option_iter_next(&iter, &opt)) { fb_mode = devm_kstrdup(&pdev->dev, opt, GFP_KERNEL); // ignore errors } + option_iter_release(&iter); + return 0; }