From patchwork Thu Mar 9 15:49:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 66941 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp366703wrd; Thu, 9 Mar 2023 07:55:30 -0800 (PST) X-Google-Smtp-Source: AK7set/D+7ArXZtmy6dwQ9FrrACPobP/HFlMPe7cZLrHnuYJL1iI7VgDHyBkDZYpIvKidsbXrnWu X-Received: by 2002:a62:1850:0:b0:5dc:d34:d9f6 with SMTP id 77-20020a621850000000b005dc0d34d9f6mr17178386pfy.2.1678377329948; Thu, 09 Mar 2023 07:55:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678377329; cv=none; d=google.com; s=arc-20160816; b=ihHd+ONuzoa+NRHRqzRBJ5xiRxNGMi3Aerwfv3HHM2ZI5XIIXXV9Ns56R5xY2Qf6th NJ85KcW4LVq2td/a9XG1Z4zc3VXQXRkqw2+5o0U9fksTCAbdStmOZhoDeb9UUj9A2K+p NiP441mdD9fErgkOxRUvOxNBTcK11Qwe/wf2XrVWIh3W4/auvJ+fGGmVueSg5Uis6kjG xQQLqv7QbSf2BdlKj9wjKSz4Orxq7Z8OUDloUzxKP/eGK06GnidYevuDHQU08OUIJ7LL Fsmaymypw0Aap2JmmlDohkAANffBu7zzWhZWsCfiliLERnZ9/rrTUTZvKPzA9sGoegW8 Yq1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5hDw377R+3WveEHHISt0O+B0HNboj//Q7JnZS8WCHQk=; b=x4idMvI0lqG35at2M2jTln55AEejZbgqF1FE+IdUmWV8FtlVePDpDBna/O7jB7RvuR ZVVTWWgYdyYWZnwwdgZLCnLZIbtgCPFB7QwzGzWqQWMzYEspmK9KyL5TgAuhQu8krW9m 9OKhnjB5zoj5sEoRkPotxqmbx3eF1YMKDrxadVm15nNZ2iL6ZY40gAjGzjbKG80ABOPd mrlKkC3eanLkedNuVx6ThvGCOfdldVm0A0JcC3ugZIeMT7zwQ4aGjK3OTJLYF0d+aJSM 5sRdTws/FSFco7dLB3fC+dEA2X6ckSle+dsgEPiaPiB70brl9JGt5nBs6vZW/tIyJ2Dh rytA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="xFOeIBq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m67-20020a625846000000b005a90f60a0e2si17480933pfb.366.2023.03.09.07.55.15; Thu, 09 Mar 2023 07:55:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="xFOeIBq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbjCIPuE (ORCPT + 99 others); Thu, 9 Mar 2023 10:50:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjCIPuD (ORCPT ); Thu, 9 Mar 2023 10:50:03 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB372F28A4 for ; Thu, 9 Mar 2023 07:50:01 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id cy23so8722845edb.12 for ; Thu, 09 Mar 2023 07:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678377000; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5hDw377R+3WveEHHISt0O+B0HNboj//Q7JnZS8WCHQk=; b=xFOeIBq/oenmpZgse9ypMIySBxHojJR+priTRx4ns8SVP7D39nQ6GWvynrSpoOZ5R4 HsKcT908aKbyY+mWmwZRF55bt35KR1yKcW6++DQauTZLH6LO5XQhIsgcSLObp6gQi6hm a3C1Phim93FONjhxlLRQF8vnGyv5kEKRKyqqR4+hFR4Sgk3etvYPV7Q2wgf+quQeWcXe hxC2Ucy6M/FWI8NXM4FSsbi4SSEtTGBa+kYiuwRsDKUcCqugBKPlLx+sYmJ/K9BI1x47 dyALpaqG6NJ6cPLoOigP4lVhPtGskb7OAMXxdEwptXITcYfMfg+ad/t27LGV1Lpt5K5d pncA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678377000; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5hDw377R+3WveEHHISt0O+B0HNboj//Q7JnZS8WCHQk=; b=eM28eGUTtlpMXkzpJzZ/zCV3qnnMXk9Bs6m5JFAbvBxdvpT2jYf9rc30IwifoHC8L4 XZH6JavOT1yeZWa9qQQMh8TDkmo6oPF0/I3gTckQoNYAYtpIgQ78c27K7StwZ9WfVu7l QS3pl5oT4aC2FBhnnBaBkOQFgBy42Z0zsekUgEu1/NhRbLXCLjhcTnkI8LMT4f/RkEoO z7jO1UL6RXc0a+BBmVszJF9k7b50tXUfw+EBIczEwls6XpG+WsIfzjDI/bzjCB2M6d66 7+pjpu6hOxkQeIUtEz9mGZTG+j+Z4QUwlYuqZIFxWo3tXGrwK6Yf7uXRPzYvFx3j+Afm jbmA== X-Gm-Message-State: AO0yUKU5Kn5vBA4jLnFi6Kc4bCQPgMfMBAm/SPZ+AAU7u/lDqDLBPUfs dC5tonmvwFLV8RAebz2DmvPiZXXu61L7RTG2YJM= X-Received: by 2002:a17:906:a1c5:b0:906:3373:cfe9 with SMTP id bx5-20020a170906a1c500b009063373cfe9mr21147766ejb.10.1678377000203; Thu, 09 Mar 2023 07:50:00 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:7ee2:e73e:802e:45c1]) by smtp.gmail.com with ESMTPSA id h17-20020a17090634d100b008ee5356801dsm8981683ejb.187.2023.03.09.07.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 07:49:59 -0800 (PST) From: Krzysztof Kozlowski To: Bjorn Andersson , Andy Gross , Konrad Dybcio , Linus Walleij , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH 1/4] pinctrl: qcom: lpass-lpi: set output value before enabling output Date: Thu, 9 Mar 2023 16:49:46 +0100 Message-Id: <20230309154949.658380-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759906187130671493?= X-GMAIL-MSGID: =?utf-8?q?1759906187130671493?= As per Hardware Programming Guide, when configuring pin as output, set the pin value before setting output-enable (OE). Similar approach is in main SoC TLMM pin controller. Cc: Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c index 87920257bb73..27fc8b671954 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c @@ -221,6 +221,15 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group, } } + /* + * As per Hardware Programming Guide, when configuring pin as output, + * set the pin value before setting output-enable (OE). + */ + if (output_enabled) { + val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK); + lpi_gpio_write(pctrl, group, LPI_GPIO_VALUE_REG, val); + } + val = lpi_gpio_read(pctrl, group, LPI_GPIO_CFG_REG); u32p_replace_bits(&val, pullup, LPI_GPIO_PULL_MASK); @@ -230,11 +239,6 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group, lpi_gpio_write(pctrl, group, LPI_GPIO_CFG_REG, val); - if (output_enabled) { - val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK); - lpi_gpio_write(pctrl, group, LPI_GPIO_VALUE_REG, val); - } - return 0; }