[v1] gpio: loongson: fixup the warning about OF_GPIO direct dependencies

Message ID 20230309111407.3398-1-zhuyinbo@loongson.cn
State New
Headers
Series [v1] gpio: loongson: fixup the warning about OF_GPIO direct dependencies |

Commit Message

Yinbo Zhu March 9, 2023, 11:14 a.m. UTC
  WARNING: unmet direct dependencies detected for OF_GPIO
  Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
  Selected by [y]:
  - GPIO_LOONGSON_64BIT [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (LOONGARCH || COMPILE_TEST [=y])

Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202303091728.UUe6LWye-lkp@intel.com
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Bartosz Golaszewski March 9, 2023, 2:50 p.m. UTC | #1
On Thu, Mar 9, 2023 at 12:14 PM Yinbo Zhu <zhuyinbo@loongson.cn> wrote:
>
> WARNING: unmet direct dependencies detected for OF_GPIO
>   Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - GPIO_LOONGSON_64BIT [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (LOONGARCH || COMPILE_TEST [=y])
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303091728.UUe6LWye-lkp@intel.com
> ---
>  drivers/gpio/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 94051fb59043d..c0d6254797800 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -384,7 +384,7 @@ config GPIO_LOONGSON
>  config GPIO_LOONGSON_64BIT
>         tristate "Loongson 64 bit GPIO support"
>         depends on LOONGARCH || COMPILE_TEST
> -       select OF_GPIO
> +       depends on OF_GPIO
>         select GPIO_GENERIC
>         help
>           Say yes here to support the GPIO functionality of a number of
> --
> 2.31.1
>

Thanks for the quick fix, applied.

Bart
  

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 94051fb59043d..c0d6254797800 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -384,7 +384,7 @@  config GPIO_LOONGSON
 config GPIO_LOONGSON_64BIT
 	tristate "Loongson 64 bit GPIO support"
 	depends on LOONGARCH || COMPILE_TEST
-	select OF_GPIO
+	depends on OF_GPIO
 	select GPIO_GENERIC
 	help
 	  Say yes here to support the GPIO functionality of a number of