diff mbox series

[2/2] erofs: get rid of an useless DBG_BUGON

Message ID 20230309053148.9223-2-hsiangkao@linux.alibaba.com
State New
Headers
Series [1/2] erofs: Revert "erofs: fix kvcalloc() misuse with __GFP_NOFAIL" |

Commit Message

Gao Xiang March 9, 2023, 5:31 a.m. UTC 
  `err` could be -EINTR and it should not be the case.  Actually such
DBG_BUGON is useless.

Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
 fs/erofs/zmap.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Chao Yu March 9, 2023, 2:34 p.m. UTC | #1 
On 2023/3/9 13:31, Gao Xiang wrote:
> `err` could be -EINTR and it should not be the case.  Actually such
> DBG_BUGON is useless.
> 
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,
diff mbox series

Patch

diff --git a/fs/erofs/zmap.c b/fs/erofs/zmap.c
index 8bf6d30518b6..655da4d739cb 100644
--- a/fs/erofs/zmap.c
+++ b/fs/erofs/zmap.c
@@ -757,9 +757,6 @@  int z_erofs_map_blocks_iter(struct inode *inode, struct erofs_map_blocks *map,
 	err = z_erofs_do_map_blocks(inode, map, flags);
 out:
 	trace_z_erofs_map_blocks_iter_exit(inode, map, flags, err);
-
-	/* aggressively BUG_ON iff CONFIG_EROFS_FS_DEBUG is on */
-	DBG_BUGON(err < 0 && err != -ENOMEM);
 	return err;
 }