diff mbox series

dt-bindings: power: supply: bq256xx: Add ts-ignore property

Message ID 20230309023926.38682-1-chenhuiz@axis.com
State New
Headers
Series dt-bindings: power: supply: bq256xx: Add ts-ignore property |

Commit Message

Hermes Zhang March 9, 2023, 2:39 a.m. UTC 
  Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag
in chip. Ignore TS pin will allow user to control the charging
parameters instead of the default JEITA profile in chip.

Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
---
 Documentation/devicetree/bindings/power/supply/bq256xx.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski March 9, 2023, 10:12 a.m. UTC | #1 
On 09/03/2023 03:39, Hermes Zhang wrote:
> Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag
> in chip. Ignore TS pin will allow user to control the charging
> parameters instead of the default JEITA profile in chip.

You miss users of it.

> 
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
>  Documentation/devicetree/bindings/power/supply/bq256xx.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> index 82f382a7ffb3..74fd48f4bec5 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> @@ -68,6 +68,12 @@ properties:
>        Interrupt sends an active low, 256 μs pulse to host to report the charger
>        device status and faults.
>  
> +  ts-ignore:

Missing vendor prefix... is this generic property? ts-ignore is very
cryptic. You should describe here rather desired system characteristic.
Why anyone would need to use it per-board level?

> +    type: boolean
> +    description: |
> +      If this property is set, the TS_IGNORE flag will be set to 1 which means
> +      will not apply JEITA profile during the charging.> +
>  required:
>    - compatible
>    - reg

Best regards,
Krzysztof
Hermes Zhang March 10, 2023, 3:48 a.m. UTC | #2 
On 2023/3/9 18:12, Krzysztof Kozlowski wrote:
> On 09/03/2023 03:39, Hermes Zhang wrote:
>> Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag
>> in chip. Ignore TS pin will allow user to control the charging
>> parameters instead of the default JEITA profile in chip.
> You miss users of it.
Could you give some more info about what I missed?
> @@ -68,6 +68,12 @@ properties:
>         Interrupt sends an active low, 256 μs pulse to host to report the charger
>         device status and faults.
>   
> +  ts-ignore:
> Missing vendor prefix... is this generic property? ts-ignore is very
> cryptic. You should describe here rather desired system characteristic.
> Why anyone would need to use it per-board level?

OK, I will fix it. Will "ti,ignore-ts-pin" be better? Yes, it's a 
generic. To disable the TS pin, actually we also could do it from HW, 
but from software, it could be more flexble. But if HW already disable 
it, then you don't need to do it again from dts.

BTW, I find I may miss some information here: the ts-ignore feature is 
not support by all the chips list here, I will add some comment for 
which chip support it.


Best Regards,

Hermes
Krzysztof Kozlowski March 10, 2023, 8:06 a.m. UTC | #3 
On 10/03/2023 04:48, Hermes Zhang wrote:
> On 2023/3/9 18:12, Krzysztof Kozlowski wrote:
>> On 09/03/2023 03:39, Hermes Zhang wrote:
>>> Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag
>>> in chip. Ignore TS pin will allow user to control the charging
>>> parameters instead of the default JEITA profile in chip.
>> You miss users of it.
> Could you give some more info about what I missed?

Users. DTS and driver code.

>> @@ -68,6 +68,12 @@ properties:
>>         Interrupt sends an active low, 256 μs pulse to host to report the charger
>>         device status and faults.
>>   
>> +  ts-ignore:
>> Missing vendor prefix... is this generic property? ts-ignore is very
>> cryptic. You should describe here rather desired system characteristic.
>> Why anyone would need to use it per-board level?
> 
> OK, I will fix it. Will "ti,ignore-ts-pin" be better? 

No, because does not describe system characteristic. Read again my last
two sentences.

> Yes, it's a 
> generic. To disable the TS pin, actually we also could do it from HW, 
> but from software, it could be more flexble. But if HW already disable 
> it, then you don't need to do it again from dts.

If this is configurable from HW, why this should be in DT?


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
index 82f382a7ffb3..74fd48f4bec5 100644
--- a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
+++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
@@ -68,6 +68,12 @@  properties:
       Interrupt sends an active low, 256 μs pulse to host to report the charger
       device status and faults.
 
+  ts-ignore:
+    type: boolean
+    description: |
+      If this property is set, the TS_IGNORE flag will be set to 1 which means
+      will not apply JEITA profile during the charging.
+
 required:
   - compatible
   - reg