Message ID | 20230308233822.31180-8-semen.protsenko@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp646827wrd; Wed, 8 Mar 2023 15:55:01 -0800 (PST) X-Google-Smtp-Source: AK7set9aHS6L42zLQDwfbpPfK+sYAwXdNCPVe8N/OszmzdryTEfRFSs4BVw0Oxt7380i6ad2IFnN X-Received: by 2002:a05:6a20:1e4e:b0:cd:9673:9c07 with SMTP id cy14-20020a056a201e4e00b000cd96739c07mr16635888pzb.7.1678319700808; Wed, 08 Mar 2023 15:55:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678319700; cv=none; d=google.com; s=arc-20160816; b=PPc3nOuqnPeimh0rBnYQrfwb1mrWLygvPsDCkHs6/NCUvi/Q6ZHfT+38seY36QVC+X YlvXp52WKTRkvapotkpKCEcV7VQALzisbfpAb8TEc4eXz5BLqF5C7Zwk1LIKEjQIpNWP elLiv2FN/+fEDO9hYCRxyjWATd4nqymqvxPNT7sS3thuvz1EB9H/5tTaeO1+p1MqyNP8 shAZIAE1feI0Kf1Q3lpivtsgMsb9w5qhipYAFY5Me64HrZrzLWypkts2tXMQmfXlFmS/ vC5PFrqL+tpxD7ASQp28eAPkPC/J6RcxJsDHl0C74veKLTJkKLr1L2ZwQYE2eF8dkQ/Y KjHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=59RnUUeXUSnsMfT51jFg2QQnLPiQn/N+3fHwfoGuKl0=; b=r0FBmiVazGm4/Z3MtlIlvztoPUq1GwVv8tpH9rSmP0aOxsWXoRFPEL361gP9x6Gi+W wY4vM8vx9hQzdOWg+rKbg7xG6PN36ldRIjLiw6OizUDYZNmqS0GmkE58RzGu/KGq0x+G zKGqx1T1G2oRwA63mjJ0kPkSsK4W8tMjsXAEPpX06DqnyI01WTVgEBQ7DpCdkH83SiG4 sl8KuCB2Uy9EacQqHDbGGwzhitK9TUM4BleMtmr7RwbNhWShFIYM9dgsJoFtaFUTzGig QX29lgdblIH+dQhc07owUbG8UyBw5S204AmJzA8/YQrRRzaEv1ma+4XE01kcCwmKjpy0 eT/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pF1RglZC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q20-20020aa79834000000b00594356992a1si15577539pfl.108.2023.03.08.15.54.45; Wed, 08 Mar 2023 15:55:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pF1RglZC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbjCHXjQ (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Wed, 8 Mar 2023 18:39:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbjCHXii (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 8 Mar 2023 18:38:38 -0500 Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ECCF65C61 for <linux-kernel@vger.kernel.org>; Wed, 8 Mar 2023 15:38:34 -0800 (PST) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-17683b570b8so508696fac.13 for <linux-kernel@vger.kernel.org>; Wed, 08 Mar 2023 15:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678318713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=59RnUUeXUSnsMfT51jFg2QQnLPiQn/N+3fHwfoGuKl0=; b=pF1RglZCkn5XIyOdWnyrmL8yTgBs1+95aNqxPg2mjlZQLm4EI99ZyCF4ldmppwfY7m SasK2e3cl9aIuv9zdQTbmuso94/gVRjDw6jWdUERQkAAXL9apO+VWMzkOrgFIqE1R/oE HcAp8jLvUWFPE/I744zd/Yaq51nSaZC413gL8BSvdQ6+2Eva13dMptuK2LvPsvaYj3dm BCdH/rGisBSwjztRqyj4WqXu+hr9/dQJXBye8LZ7PES1L0heGNKxMfQmQTU8wdhJF23J M1E0z2xB2rnNkGoTqMTTkeXqAsMtWXKmzeTV79if8Cnj3q6Nv6LAk4YxntEpCsXyPbZi pOBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678318713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59RnUUeXUSnsMfT51jFg2QQnLPiQn/N+3fHwfoGuKl0=; b=CNxOIJ4xehZSazN4a4+4rFhRAGn1GjqPskUwOvxSHb9jk5yFAnFWMmz1jc5Aq5PFv2 d0KHpwzQ6/RHKZ7uTJgsM92eFFZU1FdZgJ3d4icZ9foUQmFECZUP35YOFlaKee9tM49c PgROheVEkh73zSWhsRz+D6GaY1/GwV8ZJRGFZx6crs1suBrUxCnyGIKBy83FaG/1a5vm TcQC6bkPx+ae6hFyeKhPR9bpTElsBtBLxqS0HcbsSnQZjYzGFTKFpGSD6BR5Exed7WX+ vl0EcDVxeFaqzF72GUjbdXRMYHxH/+qVvN0+YrKAAVjkt5Y+nlWPrL1+0p/lX4ZV6M4c O+Lg== X-Gm-Message-State: AO0yUKU0yM1l4iHB3RFkByC6X99U8DurKe1oA79h/sI2QqeodqQ+35Ai zcEppnfQBYl0oIcM+lF91C+2Pg== X-Received: by 2002:a05:6870:d1c3:b0:172:36ce:91d0 with SMTP id b3-20020a056870d1c300b0017236ce91d0mr2341540oac.38.1678318713251; Wed, 08 Mar 2023 15:38:33 -0800 (PST) Received: from localhost ([136.49.140.41]) by smtp.gmail.com with ESMTPSA id ax39-20020a05687c022700b0016b0369f08fsm6735660oac.15.2023.03.08.15.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 15:38:32 -0800 (PST) From: Sam Protsenko <semen.protsenko@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh+dt@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Marek Szyprowski <m.szyprowski@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Chanho Park <chanho61.park@samsung.com>, David Virag <virag.david003@gmail.com>, Alim Akhtar <alim.akhtar@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/7] arm64: dts: exynos: Remove clock from Exynos850 pmu_system_controller Date: Wed, 8 Mar 2023 17:38:22 -0600 Message-Id: <20230308233822.31180-8-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230308233822.31180-1-semen.protsenko@linaro.org> References: <20230308233822.31180-1-semen.protsenko@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759845758282423305?= X-GMAIL-MSGID: =?utf-8?q?1759845758282423305?= |
Series |
clk: samsung: Enable PM in Exynos850 clk driver
|
|
Commit Message
Sam Protsenko
March 8, 2023, 11:38 p.m. UTC
As described in the corresponding binding documentation for
"samsung,exynos850-pmu", the "clocks" property should be used for
specifying CLKOUT mux inputs. Therefore, the clock provided to exynos850
pmu_system_controller is incorrect and should be removed. Instead of
making syscon regmap keep that clock running for PMU accesses, it should
be made always running in the clock driver, because the kernel is not
the only software accessing PMU registers on Exynos850 platform.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
arch/arm64/boot/dts/exynos/exynos850.dtsi | 1 -
1 file changed, 1 deletion(-)
Comments
On 09/03/2023 00:38, Sam Protsenko wrote: > As described in the corresponding binding documentation for > "samsung,exynos850-pmu", the "clocks" property should be used for > specifying CLKOUT mux inputs. Therefore, the clock provided to exynos850 > pmu_system_controller is incorrect and should be removed. Instead of > making syscon regmap keep that clock running for PMU accesses, it should > be made always running in the clock driver, because the kernel is not > the only software accessing PMU registers on Exynos850 platform. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > arch/arm64/boot/dts/exynos/exynos850.dtsi | 1 - > 1 file changed, 1 deletion(-) To avoid any bisectability issues, I will apply this in the next cycle. Best regards, Krzysztof
On Wed, 08 Mar 2023 17:38:22 -0600, Sam Protsenko wrote: > As described in the corresponding binding documentation for > "samsung,exynos850-pmu", the "clocks" property should be used for > specifying CLKOUT mux inputs. Therefore, the clock provided to exynos850 > pmu_system_controller is incorrect and should be removed. Instead of > making syscon regmap keep that clock running for PMU accesses, it should > be made always running in the clock driver, because the kernel is not > the only software accessing PMU registers on Exynos850 platform. > > [...] Applied, thanks! [7/7] arm64: dts: exynos: Remove clock from Exynos850 pmu_system_controller https://git.kernel.org/krzk/linux/c/858fd147234dbb66401bc102968a479f92e7ad43 Best regards,
diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi index d67e98120313..aa077008b3be 100644 --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi @@ -200,7 +200,6 @@ gic: interrupt-controller@12a01000 { pmu_system_controller: system-controller@11860000 { compatible = "samsung,exynos850-pmu", "syscon"; reg = <0x11860000 0x10000>; - clocks = <&cmu_apm CLK_GOUT_PMU_ALIVE_PCLK>; reboot: syscon-reboot { compatible = "syscon-reboot";