Message ID | 20230308230931.27261-3-semen.protsenko@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp638409wrd; Wed, 8 Mar 2023 15:33:00 -0800 (PST) X-Google-Smtp-Source: AK7set+KtYAGeEYDPmtUFN22na0h18M49UA+ftisBADUjlXvHZourlnLBApIr9OEYeDBD+GOYwtE X-Received: by 2002:a05:6a20:1443:b0:d0:15c9:4e68 with SMTP id a3-20020a056a20144300b000d015c94e68mr11108723pzi.62.1678318380044; Wed, 08 Mar 2023 15:33:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678318380; cv=none; d=google.com; s=arc-20160816; b=nqCCvDx6MmZYAWuv6gFUzD2xs0Rbl4qRw2P+xV6J9Uag/6GCPdIeODRYGmE3fm4HaE ErU7E8uoPcncpmXogwkl8vrw+0DoR/It01OMj5smD+ff3EdOc2t7O/OWP0lRq/0ZRdyr UWQk8L8eHFiTBI9WqQ5fYlI/oUJKejvvDxNUwbT8L56gAtH/PqA9+78PfSgNe3B5pARo Uzr2B1Y8U0/Ild9+jTqhf3PezTVKy/j39WNUFyROoTVpZre1YXsfGSbd/vLk9KtM4d7f 3SES935WzJCOIni+JLtKYIRdYClgKxt5VkKQkija+KgnzikCluD8kcTG/+R7U0he9At5 eWOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=J5PJqs5BsEDG1wdBjWwvXsmxEV4UYqM9XMe4BPKxtuE=; b=DHQ3E9x9VuSKky9vYmHnoI0tXGFrwhN6+B2UCHvap4ZnfFIyGKNolscpbucwpdcawO lLcO4qxr6D+FBJiaxikMBaEKDNn2CtwWhYWUYn3h8N6tzFuI/ikVDLcYPu3P/qGm6/P0 AKeDX7Ae5/GmjfpAF5dXqy9EiUO1Fq1hYu+ezMaYXOYe1iOoy74FW7pn953PBxq4YJZV 0pd7XkeZXLhdUVlOpeb9/8iFlCxWO6qZjVNc5P7ecbu1/6e7nGE2y3Mg8AtlpxrBYcLe uMMxlmrmU5fsgj4W8sW4Q0UuHUJfMWbioP6jNOHDf0uB3Pc8G72KaNiCUezGqv3QF7gl ilTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZU2X+gAA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x67-20020a633146000000b004fb6d558e4esi15503503pgx.266.2023.03.08.15.32.47; Wed, 08 Mar 2023 15:33:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZU2X+gAA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230170AbjCHXJo (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Wed, 8 Mar 2023 18:09:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjCHXJg (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 8 Mar 2023 18:09:36 -0500 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF61A618A5 for <linux-kernel@vger.kernel.org>; Wed, 8 Mar 2023 15:09:35 -0800 (PST) Received: by mail-ot1-x32c.google.com with SMTP id p13-20020a9d744d000000b0069438f0db7eso111226otk.3 for <linux-kernel@vger.kernel.org>; Wed, 08 Mar 2023 15:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678316975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J5PJqs5BsEDG1wdBjWwvXsmxEV4UYqM9XMe4BPKxtuE=; b=ZU2X+gAAyNbrZY+ccoI8srKvzJyr8um35igO3wIc7sMBIwllqYYzfzRU6hDuVGzBr0 Z1nYOwbnWSEU2h/QgERS5S+ydFsTvlH6nNRE6m/j2Ky9GxN0Ci41a7LPYHEiiTVxReeS 5/rsNyudWq6Ka5nqw1VCHvBgAFvmaBpkSChwE6nZBj4I59II15cjF9FSygL2ikudqtxw qHohzOZJtqX/gh0emEUgvxEyOY7gXKgDlB3fses6xEISy921rs9AcR/5Pl2Aa9G8erh1 ykGcKppFLstx1j6aEsp4/FwxKopraCwUk/BgBZrvZbWjl35uDJagPNrJBvQ8ucaq8GfB 0JTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678316975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J5PJqs5BsEDG1wdBjWwvXsmxEV4UYqM9XMe4BPKxtuE=; b=033Cj3tzwUDUncYhOTcLgRo4YYcPTrEjHszuNWQl4mjePPrGmyLAG6Is0eVl8Nx6UM gY3U0rDsDV5G6AIwTSE0o8fgomGvy/Ww5TBclU3BNEyE26lWNkR2a/ErmZweVGz6IA1Y ASc7+Yoo/2DPtGrJ3K6o3rf5GcEh10Cv+oN7Jvg886S2yMXBUfx84Cl9rkFEIzRqE+ff JtsZQ/1pMA/4VRVwTMJ90dvo7fij0d/bBo5Sf7HINs0S/aqZakTQP2IkL/Tq73H4a+1v BivMXdh92EawHU5Q5pjXJoQnqGeQVSHiMAoC78r4PVCjtyzfOb7M0f6FkGkEyxhGFuJa zmMw== X-Gm-Message-State: AO0yUKUkBnsWOKUTKAfL+rj8JqLKS6HuAmPXOeXcmuRqLTBTYpV4j/xL kC0OQDnY/R7UT6ASz9GCYpvZng== X-Received: by 2002:a05:6830:1f42:b0:68d:41b2:5b75 with SMTP id u2-20020a0568301f4200b0068d41b25b75mr9166479oth.11.1678316975008; Wed, 08 Mar 2023 15:09:35 -0800 (PST) Received: from localhost ([136.49.140.41]) by smtp.gmail.com with ESMTPSA id q24-20020a05683031b800b0068bc48c61a5sm6976067ots.19.2023.03.08.15.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 15:09:34 -0800 (PST) From: Sam Protsenko <semen.protsenko@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh+dt@kernel.org> Cc: Alim Akhtar <alim.akhtar@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Chanho Park <chanho61.park@samsung.com>, David Virag <virag.david003@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] dt-bindings: power: pd-samsung: Allow pd nodes to be children of PMU Date: Wed, 8 Mar 2023 17:09:27 -0600 Message-Id: <20230308230931.27261-3-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230308230931.27261-1-semen.protsenko@linaro.org> References: <20230308230931.27261-1-semen.protsenko@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759844373609541114?= X-GMAIL-MSGID: =?utf-8?q?1759844373609541114?= |
Series |
soc: samsung: pm_domains: Add Exynos850 support
|
|
Commit Message
Sam Protsenko
March 8, 2023, 11:09 p.m. UTC
Introduce a new "samsung,pd-index" property to choose a specific power
domain. This way it would be possible to avoid specifying any addresses
in power domain nodes, relying solely on syscon regmap from the parent
node (which should be a PMU system controller). Therefore the "reg"
property is deprecated now, as it's more logical to describe power
domains as children of PMU node, because PD registers reside in the PMU
area.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
.../devicetree/bindings/power/pd-samsung.yaml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
Comments
On 09/03/2023 00:09, Sam Protsenko wrote: > Introduce a new "samsung,pd-index" property to choose a specific power > domain. This way it would be possible to avoid specifying any addresses > in power domain nodes, relying solely on syscon regmap from the parent > node (which should be a PMU system controller). Therefore the "reg" > property is deprecated now, as it's more logical to describe power > domains as children of PMU node, because PD registers reside in the PMU > area. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > .../devicetree/bindings/power/pd-samsung.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/pd-samsung.yaml b/Documentation/devicetree/bindings/power/pd-samsung.yaml > index a353a705292c..73178b1a56ea 100644 > --- a/Documentation/devicetree/bindings/power/pd-samsung.yaml > +++ b/Documentation/devicetree/bindings/power/pd-samsung.yaml > @@ -25,6 +25,10 @@ properties: > > reg: > maxItems: 1 > + deprecated: true > + description: > + Physical base address and length of Power Domains area (if not a child of > + PMU). > > clocks: > deprecated: true > @@ -45,10 +49,15 @@ properties: > power-domains: > maxItems: 1 > > + samsung,pd-index: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Power domain index (if a child of PMU). Valid values are defined in:: > + "include/dt-bindings/power/samsung,exynos850-power.h" - for Exynos850 DT nodes should not have any IDs, except what is in 'reg'. Thus please go with Marek's proposal of merging power domains into PMU driver and using proper xlate. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/pd-samsung.yaml b/Documentation/devicetree/bindings/power/pd-samsung.yaml index a353a705292c..73178b1a56ea 100644 --- a/Documentation/devicetree/bindings/power/pd-samsung.yaml +++ b/Documentation/devicetree/bindings/power/pd-samsung.yaml @@ -25,6 +25,10 @@ properties: reg: maxItems: 1 + deprecated: true + description: + Physical base address and length of Power Domains area (if not a child of + PMU). clocks: deprecated: true @@ -45,10 +49,15 @@ properties: power-domains: maxItems: 1 + samsung,pd-index: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Power domain index (if a child of PMU). Valid values are defined in:: + "include/dt-bindings/power/samsung,exynos850-power.h" - for Exynos850 + required: - compatible - "#power-domain-cells" - - reg unevaluatedProperties: false