From patchwork Wed Mar 8 17:34:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 66400 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp473375wrd; Wed, 8 Mar 2023 09:42:49 -0800 (PST) X-Google-Smtp-Source: AK7set9NL98XsOnB4qzX0Xt3fwafGHDk9KbxKBp+PnVcHIlpmmSC4CCQWIdvc+3+TS7qMPXwhlEp X-Received: by 2002:a17:90a:fe8c:b0:237:64dc:4b65 with SMTP id co12-20020a17090afe8c00b0023764dc4b65mr19664326pjb.21.1678297369357; Wed, 08 Mar 2023 09:42:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678297369; cv=none; d=google.com; s=arc-20160816; b=03Veda2BDUZg5tzxf0g2dUJlPycYGps0Hb27RfDUt3Xh5lE+cslG/5VeLWr5s7UfyL hgG+lK8kjCizENb+K93XccXuOLM/h5eN9GUGKHz8b7oNrVzMrij7iVyJT8WbhO7tEBcW o85bsBifmrfWkUJho7rGSlJZZDqbfbi53uy6HTh+ilpJ4Ng8YTMIu/f3jJudJamTX2nP erHhEqMs5ex+4s1kFzdjoTccv7FDlVoglv3irMH62z3Mp+Q8Ocf3FOT0USe6m5WscFay Lq5YXp9S/vzycfjYvLnW5w0MQgEGk2gOnXiUjTiwO4Bngtw0zGVB3LfzwnZkniLTMODJ sH1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=eRJDP6Vc/O5/BFT6QkUGAFvagsrz1RUcQ8m4GSGcwQk=; b=yg+QyJ2NIutyMmUxlyUw1fTRmj7R6aVE9r9cGlpz2z2RaaRQ4qjwrQgTxRlHCtb/bE +3/WZxXgkVJnP3loFjbDbvZVf5X4LwOcnoPhePwlMG6UO+ahdhtXns9F212qilll1o9c s44zBvTBRbC9ZrwCYQgA3PVX6Mgh4R3ZmLZyKJ45hPD2lgvMTX3GzOu6oVLbKfDqQYUx WiZS2Nli5Er3+go6VhvnScL8k7iUJlYdnabpPCmXvYsTPjHEwKveY6WrBQgFh3x8lUqg cVe4Bgl8BGrylg2UB4ycFgbX0WxJ9QVFWgzBHqSVfu2XmHQMu4DCMQWP1/o40f8MlEu0 ot6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=P5+8O4pc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5-20020a17090a7c0500b00233cf305f6bsi50289pjf.111.2023.03.08.09.42.36; Wed, 08 Mar 2023 09:42:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=P5+8O4pc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbjCHRfm (ORCPT + 99 others); Wed, 8 Mar 2023 12:35:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjCHRfk (ORCPT ); Wed, 8 Mar 2023 12:35:40 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.215]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 45EB1C083C for ; Wed, 8 Mar 2023 09:35:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=eRJDP 6Vc/O5/BFT6QkUGAFvagsrz1RUcQ8m4GSGcwQk=; b=P5+8O4pcjaMSwWpLWwf5s XIdfhUahbwYqB9yeVw1rQo82QfZS1BFndK4SzOZYbmrKGLF8ZxwtELHqnK27lXBL jONOpczcOW5YU4K1BAwIQVxXKf2lyKQ+l4Crhrl5eAzUxfzg0QIg/UIEcbdY392x D+ZEgMrIAKmaF9pau0sqp0= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g0-0 (Coremail) with SMTP id _____wD3SnQqxwhkOjFfCg--.59019S2; Thu, 09 Mar 2023 01:34:35 +0800 (CST) From: Zheng Wang To: dri-devel@lists.freedesktop.org Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, jonas@kwiboo.se, airlied@gmail.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] drm/bridge: adv7511: fix race condition bug in adv7511_remove due to unfinished work Date: Thu, 9 Mar 2023 01:34:33 +0800 Message-Id: <20230308173433.2788833-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wD3SnQqxwhkOjFfCg--.59019S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr18Xr4rGw4ktrW3Ww1UGFg_yoWDZFbEkF y3Z34xWr15A3Wv9w17AFW2vry2k3WUCrZI93WfKa9xJr13Zr1rW347ZrWDXF18uF4YyFyD JrnrZw4rJa42yjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKPfHUUUUUU== X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiGg0sU1aEEgVt2wAAsb X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759822342327838262?= X-GMAIL-MSGID: =?utf-8?q?1759822342327838262?= In adv7511_probe, adv7511->hpd_work is bound with adv7511_hpd_work. If we call adv7511_remove with a unfinished work. There may be a race condition where bridge->hpd_mutex was destroyed by drm_bridge_remove and used in adv7511_hpd_work in drm_bridge_hpd_notify. Fix it by canceling the work before cleanup in adv7511_remove. Signed-off-by: Zheng Wang --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ddceafa7b637..9bf72dd6c1d3 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1349,6 +1349,7 @@ static void adv7511_remove(struct i2c_client *i2c) { struct adv7511 *adv7511 = i2c_get_clientdata(i2c); + cancel_work_sync(&adv7511->hpd_work); adv7511_uninit_regulators(adv7511); drm_bridge_remove(&adv7511->bridge);