From patchwork Wed Mar 8 16:52:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 66361 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp446950wrd; Wed, 8 Mar 2023 08:57:14 -0800 (PST) X-Google-Smtp-Source: AK7set8ZttmvEl1H5RtSXhSj8oiFpMtGKmwO/Q/DGM2jES3tfUY1zK+2l7Xyc8sGT6Bn7BeNxVck X-Received: by 2002:a62:38ce:0:b0:5a8:a9bc:197 with SMTP id f197-20020a6238ce000000b005a8a9bc0197mr14781526pfa.11.1678294634583; Wed, 08 Mar 2023 08:57:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678294634; cv=none; d=google.com; s=arc-20160816; b=BtsFaRXL7RmIU43ttc2I0oslGEagYm3GxJs2vJoN/AQriu6rQ9sYi7IBdJHaQ5Wb6I nUJdPJ1J3vlWffVPGIj/3IRtbDngF4fS97YfcUV+i15MuWY8ZNarDnWYOa0NPNhCnulc +nu6v25+vcdMzDNsVqq5woZYUrMjrePQMuBMhqwwr28+2w5dgv/hauOHE7lL8urPGe+l EpFTIaLWpDtsDf6ftW61KHmsaLMTVFBV8ZmKpxp1ulLYZgdhgfs4M0ThTD8KBOzBiA7i 8yZfN+77NfWMzmY16m/srqqqvYfmBfIsQT+9Xe9Bsxf9Te0f27bg9Rll8dB+9ZaGTQHv kK3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dL8s47Tp1nK8GIg8PijNkCrDLEgPha2fkCIMRUXm1zk=; b=DaDn8Sq/dcuY549gUbgXJMA5/mP2+45/F4vXPT6a6L5MKZRxxix9U4eELCvsjrV5tO Y4kUJ7H42sXLdg2CrWyIfxNqmCikyyx+rkhBSEtXLSPKAolQGcwXgmU3d6d35MUAOrJq MBrzce0JbrPyNIB6KuGMdyoPiA76lsN08BdgqmkEXFfWre+FB95LXuH4Sp18uS7WyuVf eO6ZZZVjY1dWMLSSYNVbw8S48THoyNLNWNEg/QljP54rAa1Xj+xUbMpKdK0amIxVQAMU tAkSB6y3yiO2YPIbOA/AcF5mWG763pIc1/kWR7yjMQwy4osls4JTRRhlPodfc2GYY1zS STQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X9xDhghJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 188-20020a6305c5000000b004fc2f2d8d45si16255466pgf.162.2023.03.08.08.57.02; Wed, 08 Mar 2023 08:57:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X9xDhghJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbjCHQyA (ORCPT + 99 others); Wed, 8 Mar 2023 11:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbjCHQx4 (ORCPT ); Wed, 8 Mar 2023 11:53:56 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B0C31CF55 for ; Wed, 8 Mar 2023 08:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678294388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dL8s47Tp1nK8GIg8PijNkCrDLEgPha2fkCIMRUXm1zk=; b=X9xDhghJJiUO5nheQyRlufRJS24LGPs91Op9cqn6U8PoPfSFk58bwgmG58loognKBRmYKa 9WhsMJodSUOiD+s84cb6WwbEhF582FGFojsYiFrf+OUnhDoyjiQstuQDEZDKJG1fYu9v7d a1rFqT7sPHryk26KidQwFJ8ZkD2bWkE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-609-Q9XiGVkBM5CVEEGBMEseQA-1; Wed, 08 Mar 2023 11:53:02 -0500 X-MC-Unique: Q9XiGVkBM5CVEEGBMEseQA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0ADFE2810C15; Wed, 8 Mar 2023 16:53:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08E1F492B04; Wed, 8 Mar 2023 16:52:58 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: [PATCH v17 01/14] splice: Clean up direct_splice_read() a bit Date: Wed, 8 Mar 2023 16:52:38 +0000 Message-Id: <20230308165251.2078898-2-dhowells@redhat.com> In-Reply-To: <20230308165251.2078898-1-dhowells@redhat.com> References: <20230308165251.2078898-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759819475192759025?= X-GMAIL-MSGID: =?utf-8?q?1759819475192759025?= Do a couple of cleanups to direct_splice_read(): (1) Cast to struct page **, not void *. (2) Simplify the calculation of the number of pages to keep/reclaim in direct_splice_read(). Suggested-by: Christoph Hellwig Signed-off-by: David Howells cc: Jens Axboe cc: Christoph Hellwig cc: Al Viro cc: David Hildenbrand cc: John Hubbard cc: linux-mm@kvack.org cc: linux-block@vger.kernel.org cc: linux-fsdevel@vger.kernel.org Reviewed-by: Christoph Hellwig --- fs/splice.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/fs/splice.c b/fs/splice.c index 2e76dbb81a8f..abd21a455a2b 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -295,7 +295,7 @@ ssize_t direct_splice_read(struct file *in, loff_t *ppos, struct kiocb kiocb; struct page **pages; ssize_t ret; - size_t used, npages, chunk, remain, reclaim; + size_t used, npages, chunk, remain, keep = 0; int i; /* Work out how much data we can actually add into the pipe */ @@ -309,7 +309,7 @@ ssize_t direct_splice_read(struct file *in, loff_t *ppos, if (!bv) return -ENOMEM; - pages = (void *)(bv + npages); + pages = (struct page **)(bv + npages); npages = alloc_pages_bulk_array(GFP_USER, npages, pages); if (!npages) { kfree(bv); @@ -332,11 +332,8 @@ ssize_t direct_splice_read(struct file *in, loff_t *ppos, kiocb.ki_pos = *ppos; ret = call_read_iter(in, &kiocb, &to); - reclaim = npages * PAGE_SIZE; - remain = 0; if (ret > 0) { - reclaim -= ret; - remain = ret; + keep = DIV_ROUND_UP(ret, PAGE_SIZE); *ppos = kiocb.ki_pos; file_accessed(in); } else if (ret < 0) { @@ -349,14 +346,12 @@ ssize_t direct_splice_read(struct file *in, loff_t *ppos, } /* Free any pages that didn't get touched at all. */ - reclaim /= PAGE_SIZE; - if (reclaim) { - npages -= reclaim; - release_pages(pages + npages, reclaim); - } + if (keep < npages) + release_pages(pages + keep, npages - keep); /* Push the remaining pages into the pipe. */ - for (i = 0; i < npages; i++) { + remain = ret; + for (i = 0; i < keep; i++) { struct pipe_buffer *buf = pipe_head_buf(pipe); chunk = min_t(size_t, remain, PAGE_SIZE);