From patchwork Wed Mar 8 14:37:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 66274 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp379758wrd; Wed, 8 Mar 2023 06:54:44 -0800 (PST) X-Google-Smtp-Source: AK7set86iRYMCX1TVJGOAM2sLmdLAoOcSjo2jIwijmkaw5wdptQXX23j67LLS9T9Edu4FFRlJE2u X-Received: by 2002:a17:90b:1bd0:b0:237:c4b1:baf4 with SMTP id oa16-20020a17090b1bd000b00237c4b1baf4mr18771322pjb.11.1678287284630; Wed, 08 Mar 2023 06:54:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678287284; cv=none; d=google.com; s=arc-20160816; b=c4OTZy6DqBGQRvP2y7wOM8zaHKhj2b/U1Y01umuneDww5gfiYqolBjuMT8s9hhxVdb IHEmN61aWZEEcZLCLBKW4RhM06xxCmXixzsTm8KjsWXM4P4hkXD28VN3cPoMofKQshGx ifUngO/xKm9w1Rc9ufvoswSMHbIuImgdD9iKwimP+/kwQVeHV+OI5IpK3QYu7njQGU8/ GaG91nc9wxUOO/R5KWEO5sfP3ivTTfifB0X2Zugg/fTfep0visJEJSauIptSFDuEC2tC 7o3ZREv6klfU0McxQAZqaIJt9aLQ0IuRHARxP2qYM4OpUjuRTZwjwtA+8lN2YgYLRAfm aRYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=T0MgyEE2up5lyn6F4xZiFP7ZLu50ZEhkrR3VW4b8xrI=; b=rya6dzNRQaKHhN0qCLuCv5Desuh1YVYAR3h2yK8h25HhV4NGzf2ZF0+KNIj89/Vbo2 rHTi35NoB60HhSzNnZ26/U58whuZtDkYX5H2kvw9dUVQCD5i8cZx18ViUaTH5tsuULZ/ v+LjhZuER8c5UcHR+XAI7nMnff1qI6mNY4tJBWQVrn/4xGAg58wwYC5F5coz6IE9+sPu edFB/uxUh/MMQ3j+/X6cqG3ZeW4fdx9MpEDuVZgn3V3CEfDYVY6EDbm5rpFdhl44PPls iF5urJDsHpugA32IraAJ9KzfnN8nFCq3hy1QFcaXiCMNkZCwHNXpYSGIiWOaqbOR2TB3 CZgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SNKfiAeK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020a63440c000000b004fbacd1a872si14010508pga.853.2023.03.08.06.54.27; Wed, 08 Mar 2023 06:54:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SNKfiAeK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbjCHOkT (ORCPT + 99 others); Wed, 8 Mar 2023 09:40:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbjCHOj0 (ORCPT ); Wed, 8 Mar 2023 09:39:26 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 267E17D086 for ; Wed, 8 Mar 2023 06:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678286311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T0MgyEE2up5lyn6F4xZiFP7ZLu50ZEhkrR3VW4b8xrI=; b=SNKfiAeKA5Zx8G42iBFHjpaAVy416va0x5kq6lTE1Rv/bW+zmQlXEnX2QM6ibcDyKQ4tKl ZBh7xQLHkGV/GkES5kjRsaYrCwTKH0Iv45iTJjYa+Eu/T1f+yGq6Gdjgpj+ULbw+uyJ0Bw mgCCiRug58+9mEklTV4kVYPagXkY7RM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-349-LwKNUDAjOYOokcFxinhM6A-1; Wed, 08 Mar 2023 09:38:26 -0500 X-MC-Unique: LwKNUDAjOYOokcFxinhM6A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5AD9F101A55E; Wed, 8 Mar 2023 14:38:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71FC01121314; Wed, 8 Mar 2023 14:38:20 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard Subject: [PATCH v16 08/13] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Wed, 8 Mar 2023 14:37:49 +0000 Message-Id: <20230308143754.1976726-9-dhowells@redhat.com> In-Reply-To: <20230308143754.1976726-1-dhowells@redhat.com> References: <20230308143754.1976726-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759811767491800706?= X-GMAIL-MSGID: =?utf-8?q?1759811767491800706?= ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard cc: Al Viro cc: David Hildenbrand cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index f771001574d0..850fb9870c2f 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }