diff mbox series

[-next] thermal/hwmon: Use devm_platform_ioremap_resource()

Message ID 20230308060357.45647-1-yang.lee@linux.alibaba.com
State New
Headers
Series [-next] thermal/hwmon: Use devm_platform_ioremap_resource() |

Commit Message

Yang Li March 8, 2023, 6:03 a.m. UTC 
  According to commit 7945f929f1a7 ("drivers: provide
devm_platform_ioremap_resource()"), convert platform_get_resource(),
devm_ioremap_resource() to a single call to Use 
devm_platform_ioremap_resource(), as this is exactly what this function
does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/thermal/rcar_thermal.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Geert Uytterhoeven March 8, 2023, 8:37 a.m. UTC | #1 
Hi Yang,

On Wed, Mar 8, 2023 at 7:17 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
> According to commit 7945f929f1a7 ("drivers: provide
> devm_platform_ioremap_resource()"), convert platform_get_resource(),
> devm_ioremap_resource() to a single call to Use
> devm_platform_ioremap_resource(), as this is exactly what this function
> does.

Thanks for your patch!

> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -435,9 +435,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>                          * Then, driver uses common registers
>                          * rcar_has_irq_support() will be enabled
>                          */
> -                       res = platform_get_resource(pdev, IORESOURCE_MEM,
> -                                                   mres++);
> -                       common->base = devm_ioremap_resource(dev, res);
> +                       common->base = devm_platform_ioremap_resource(pdev, mres++);
>                         if (IS_ERR(common->base)) {
>                                 ret = PTR_ERR(common->base);
>                                 goto error_unregister;

Note that there is a second opportunity for conversion in the same
function, a few lines below.

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang March 8, 2023, 12:16 p.m. UTC | #2 
> Note that there is a second opportunity for conversion in the same
> function, a few lines below.

This should be fixed in a V2, then, not in an incremental patch, please.
diff mbox series

Patch

diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index b8571f7090aa..ee2dde1fbe2a 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -435,9 +435,7 @@  static int rcar_thermal_probe(struct platform_device *pdev)
 			 * Then, driver uses common registers
 			 * rcar_has_irq_support() will be enabled
 			 */
-			res = platform_get_resource(pdev, IORESOURCE_MEM,
-						    mres++);
-			common->base = devm_ioremap_resource(dev, res);
+			common->base = devm_platform_ioremap_resource(pdev, mres++);
 			if (IS_ERR(common->base)) {
 				ret = PTR_ERR(common->base);
 				goto error_unregister;