Message ID | 20230307232340.2370476-1-bmasney@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp36859wrd; Tue, 7 Mar 2023 16:09:24 -0800 (PST) X-Google-Smtp-Source: AK7set/i/36fVPf7XVt2I8fwrAacWvK8go/vr4c/w8ma/6UheKqV4AtQq96W+txoaF/AxD7w812X X-Received: by 2002:aa7:c485:0:b0:4ad:6064:76c5 with SMTP id m5-20020aa7c485000000b004ad606476c5mr12621625edq.11.1678234164717; Tue, 07 Mar 2023 16:09:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678234164; cv=none; d=google.com; s=arc-20160816; b=GbJhayHuosoKNMDlQkn1/HvWlrmYoxjIk1FOEB+fO8w9CbuVyS8TUG6XE7T/RmxiCd GHn3CvUuWsVosFZiZnQyU2E+PAB7kKRBzIGjdjrhH5zVK5D/h4p/3YXb5SKisJOHsud+ kZXHNBUMWLlx+aSlEI6q852HaWYUlLYtthuWTSf6KLhyIFqPEk29RAvQJWbe/pmec4nJ qKit1qT/oO3DhaBLM1Ns0vPdGX3HXJ1D5u7zgMwwOqBrNF0Kyj8cGDQe3RdObxNQ0PB/ 664JvG4OVMM3wTMzuQNtyYK+TTMsW0/QxR3pAcAFHiDt5MKdwFgsnhkQKtsvccf0Yf+E OA/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=L1VSODuSHT6h/z9IAuPAvJcAN7vDMCMVV0tl0uco2PU=; b=ucrrZiTZu1cSYEGEroxhF4Kxp319NgXqaB/PNpXuRpZPV7CskDuJ58WKRbtCCRijCx rPbhrQQQr7+TU+mb/d7LnzpBIH0W679xroeABdlvjDHSA+8BkewOjljXrxEQB302bD6p 2KGO+MuWZJUTZEmzZuEBdSC7k84XzFsJ7gETzZJq+hhU8W3gE4Eh6+afuyQDvdin1B0Z gG4yxAPqULYAYqmCf2ls4VeXzYkj6o8LOyTzy6jifyubaUvZMqGMKRNywRdMZ/LRB/D0 ITPFlAeGx5exFouM2qNp+ybBLYzZccZZ9tqtzHoByNllPaeSUQ+V093bQs3U/4xA0fXE lU2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VtsQ3MY4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v26-20020aa7cd5a000000b004acbebc9408si11661057edw.383.2023.03.07.16.09.01; Tue, 07 Mar 2023 16:09:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VtsQ3MY4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbjCGXYg (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Tue, 7 Mar 2023 18:24:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjCGXYf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Mar 2023 18:24:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECA937C3DD for <linux-kernel@vger.kernel.org>; Tue, 7 Mar 2023 15:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678231430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L1VSODuSHT6h/z9IAuPAvJcAN7vDMCMVV0tl0uco2PU=; b=VtsQ3MY4wrad9qA8bppUqeceRDC3Xfo1+llADGnbD/WUWXLl8J51krUX9v91LQ2R4pgfuf C4hBcNMml7BT2EKT8gNnWUPojUzevu38e10gIal3RvUJzJpRLlpHbSUhaJVRHQmtISpZ24 PQ/RZLZELPO+xfszskjPArrqLYzxmgE= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-B4zzyCR6OtyVoAqLY6_1hA-1; Tue, 07 Mar 2023 18:23:48 -0500 X-MC-Unique: B4zzyCR6OtyVoAqLY6_1hA-1 Received: by mail-qk1-f199.google.com with SMTP id pc36-20020a05620a842400b00742c715894bso8308551qkn.21 for <linux-kernel@vger.kernel.org>; Tue, 07 Mar 2023 15:23:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678231428; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L1VSODuSHT6h/z9IAuPAvJcAN7vDMCMVV0tl0uco2PU=; b=6eKQpyIWnef8xVxg3fhXNqlPp2NMUFQGq39p2M2AYAiz67pDxEQU8p73uXLVeD3UjJ 0qVC6fOfpxFflQ28YFSkVVlKJWdiEQqTrSkYfnDLUWYLwtZ8UWKdTmjTPJjQd36J2T+/ TL+Oq3yShIRKbKkvfgZBtgQEY2OcEHFql0OLhsSBsu+UJoEm8Kk1zxRyGy2P5Yw3jXM6 Kk42D3NhvEvN2jTcnpx3/RQXSH5XXr4pbfNZw+mDS07kAh2uZSB+FQdJR8x64JU42j5t rfX6k1QP+/K+AfgInW932GRUJLdWCZsh6MzJqtpEQnOXKU0Z+02WfvdIrOa6Ye39iz/p JxiQ== X-Gm-Message-State: AO0yUKX53tezlpYkcGzf44xFA9MJX4qWBnD9AmYw/Z0HsBTN9d71Z/Yu RVZGgYXwJGtT6NLvL5v/oLO4xmrmnKkpGcuYeYWPXoa0MKMytcJgl/vGVnzlZJWozC4vUZhgKo/ XsFc7ivPG/2SmOPdLtWvgmExV X-Received: by 2002:a05:6214:1250:b0:538:a431:862e with SMTP id r16-20020a056214125000b00538a431862emr28167920qvv.19.1678231428404; Tue, 07 Mar 2023 15:23:48 -0800 (PST) X-Received: by 2002:a05:6214:1250:b0:538:a431:862e with SMTP id r16-20020a056214125000b00538a431862emr28167899qvv.19.1678231428131; Tue, 07 Mar 2023 15:23:48 -0800 (PST) Received: from x1.. (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id do32-20020a05620a2b2000b0073b7568d998sm10280819qkb.2.2023.03.07.15.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 15:23:47 -0800 (PST) From: Brian Masney <bmasney@redhat.com> To: andersson@kernel.org Cc: quic_shazhuss@quicinc.com, agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware Date: Tue, 7 Mar 2023 18:23:40 -0500 Message-Id: <20230307232340.2370476-1-bmasney@redhat.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759756067236783360?= X-GMAIL-MSGID: =?utf-8?q?1759756067236783360?= |
Series |
arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware
|
|
Commit Message
Brian Masney
March 7, 2023, 11:23 p.m. UTC
The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually
named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and
correct the name to match what's in Qualcomm's deliverable.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 08/03/2023 00:23, Brian Masney wrote: > The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually > named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and > correct the name to match what's in Qualcomm's deliverable. I don't think vendor deliverables matter. linux-firmware is here more important. The file will be cdsp.mbn in the firmware, won't it? Best regards, Krzysztof
On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2023 00:23, Brian Masney wrote: > > The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually > > named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and > > correct the name to match what's in Qualcomm's deliverable. > > I don't think vendor deliverables matter. linux-firmware is here more > important. The file will be cdsp.mbn in the firmware, won't it? cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I far as I know there's no plan for someone to submit those since QC would need to approve that. I can ask though since the DTS for these two bits has been submitted upstream. Brian
On 08/03/2023 13:06, Brian Masney wrote: > On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote: >> On 08/03/2023 00:23, Brian Masney wrote: >>> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually >>> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and >>> correct the name to match what's in Qualcomm's deliverable. >> >> I don't think vendor deliverables matter. linux-firmware is here more >> important. The file will be cdsp.mbn in the firmware, won't it? > > cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I > far as I know there's no plan for someone to submit those since QC would > need to approve that. I can ask though since the DTS for these two bits > has been submitted upstream. If they are never going to be submitted, vendor is allowed to rename them all the time in their "deliverables". Are you going to rename the file every time Qualcomm decides to rename them? There is no single guarantee the names would be fixed, because vendor is allowed to do absolutely anything. Sorry, but any argument in upstream DTS that "someone downstream does something" is deemed to fail in many cases. Best regards, Krzysztof
On Wed, Mar 08, 2023 at 01:36:52PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2023 13:06, Brian Masney wrote: > > On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote: > >> On 08/03/2023 00:23, Brian Masney wrote: > >>> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually > >>> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and > >>> correct the name to match what's in Qualcomm's deliverable. > >> > >> I don't think vendor deliverables matter. linux-firmware is here more > >> important. The file will be cdsp.mbn in the firmware, won't it? > > > > cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I > > far as I know there's no plan for someone to submit those since QC would > > need to approve that. I can ask though since the DTS for these two bits > > has been submitted upstream. > > If they are never going to be submitted, vendor is allowed to rename > them all the time in their "deliverables". Are you going to rename the > file every time Qualcomm decides to rename them? There is no single > guarantee the names would be fixed, because vendor is allowed to do > absolutely anything. > cdsp0.mbn and cdsp1.mbn are better names, so let's use this patch to define that if/when they are pushed to linux-firmware it should follow this scheme. > Sorry, but any argument in upstream DTS that "someone downstream does > something" is deemed to fail in many cases. > That is indeed an insufficient argument, in many cases. Regards, Bjorn
On Tue, 7 Mar 2023 18:23:40 -0500, Brian Masney wrote: > The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually > named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and > correct the name to match what's in Qualcomm's deliverable. > > Applied, thanks! [1/1] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware commit: b891251b40d4dc4cfd28341f62f6784c02ad3a78 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts index 6c547f1b13dc..0f560a4661eb 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -177,7 +177,7 @@ &qup2_uart17 { }; &remoteproc_nsp0 { - firmware-name = "qcom/sa8540p/cdsp.mbn"; + firmware-name = "qcom/sa8540p/cdsp0.mbn"; status = "okay"; };