From patchwork Tue Mar 7 19:24:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 65821 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2631269wrd; Tue, 7 Mar 2023 11:58:21 -0800 (PST) X-Google-Smtp-Source: AK7set+hAb9L4yc7ymJINnFZnQ1rJsmCgreXOCPLvHIe+3DIpZ5S0MQdAb+SuF11qQMvJKuf19k1 X-Received: by 2002:aa7:c1d6:0:b0:4c1:88e:6ac9 with SMTP id d22-20020aa7c1d6000000b004c1088e6ac9mr14491695edp.10.1678219100875; Tue, 07 Mar 2023 11:58:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678219100; cv=none; d=google.com; s=arc-20160816; b=iP0G0fvgAJcNQTGZgm8TnlIQ0+QRzzz/zydp46zh9EDB7VTdSHnoR1WBLYA5Kwc5O9 gr6gI//Hf29+Fx/q9NLE7QNRop1st8CamaUrrim+xY3/sZR2iPIBcFS8ldRQwp/29y0x lMt2W6xX6NRZDt28nRzKRsS3/W8Ciua87W3verIBo65JwTGuWGNq8ROFlAYS3SdNqVTM GRFzFyQrOn6ur5HwbSbu4njexS6zje/H+GE3ItoXdKFeJUP1TLdf86ak1lsMRxLKxTA7 3tmgOArL5gqOoh2BIfGcjdMGvuu/rhQy+ziVre2zz3dLwDSmu97dhxORic0CqUV89TD0 WUFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KcgkIWNvodDr5x36a9j1+pJT663ai9fqYOsgYzxEZYk=; b=X2GzH2ZL/WB1HEVUuThW4bVM3BN5g5Q1dqDm9BWkT6E9VWmUgy1hGcccqudf9x1O2r BMg6i9abFKiHIfiq1usiezBD6zDk+mcZF5uThrihSQ/gecw51GqqXYLKkts/8ErP6LUu v394yQHx4aWm4LPYy0C+RA1onbviG1PRC9MrRtkPSP1RYCFaq9pRvIwysnYHN3oFRiKM 06kz+kPlnXEt4gS+SQhDve42I9kMvEGQi7Raa+Axgj7XI+Ou1x+vx//FHNvyxN8tKWNO oyl+a7+jlYzegN6Y0KrczFTu2bL0HnnBQkmwEO2LjyBmKRQ2IDpuFiQAzTopTlkQkeoj /lKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=LOGioT+4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m6-20020aa7c486000000b004acd42c5911si847027edq.241.2023.03.07.11.57.57; Tue, 07 Mar 2023 11:58:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=LOGioT+4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234093AbjCGTiI (ORCPT + 99 others); Tue, 7 Mar 2023 14:38:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234128AbjCGThg (ORCPT ); Tue, 7 Mar 2023 14:37:36 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15ECB8574 for ; Tue, 7 Mar 2023 11:24:58 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2A16B1EC068D; Tue, 7 Mar 2023 20:24:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1678217097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KcgkIWNvodDr5x36a9j1+pJT663ai9fqYOsgYzxEZYk=; b=LOGioT+4S3qPypIbXtjQL01zmmGNuZ20p9ZyCb4TD0Smw3hDmdWZ60WSGcUBj5tJfF1ulJ yPXFX1Jd1AJ3aM/VvY8qdZcrkCo5bAWQYlN09+U0f+Q1eIrfc+e6NRXoQWbTKKu7DjjqXj qmg0s9drt+nvIml2t57kVuYScwGPgcU= From: Borislav Petkov To: LKML Cc: Dionna Glaze , Joerg Roedel , Michael Roth , Nikunj A Dadhania , Peter Gonda , Tom Lendacky , linux-coco@lists.linux.dev, x86@kernel.org Subject: [PATCH -v3 02/11] virt/coco/sev-guest: Check SEV_SNP attribute at probe time Date: Tue, 7 Mar 2023 20:24:40 +0100 Message-Id: <20230307192449.24732-3-bp@alien8.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230307192449.24732-1-bp@alien8.de> References: <20230307192449.24732-1-bp@alien8.de> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759740272161422714?= X-GMAIL-MSGID: =?utf-8?q?1759740272161422714?= From: "Borislav Petkov (AMD)" No need to check it on every ioctl. And yes, this is a common SEV driver but it does only SNP-specific operations currently. This can be revisited later, when more use cases appear. No functional changes. Signed-off-by: Borislav Petkov (AMD) --- arch/x86/kernel/sev.c | 3 --- drivers/virt/coco/sev-guest/sev-guest.c | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c index 679026a640ef..c644c34372e8 100644 --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -2183,9 +2183,6 @@ int snp_issue_guest_request(u64 exit_code, struct snp_req_data *input, unsigned struct ghcb *ghcb; int ret; - if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP)) - return -ENODEV; - if (!fw_err) return -EINVAL; diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c index 7b4e9009f335..ed5d6ae1a144 100644 --- a/drivers/virt/coco/sev-guest/sev-guest.c +++ b/drivers/virt/coco/sev-guest/sev-guest.c @@ -703,6 +703,9 @@ static int __init sev_guest_probe(struct platform_device *pdev) void __iomem *mapping; int ret; + if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP)) + return -ENODEV; + if (!dev->platform_data) return -ENODEV;