From patchwork Tue Mar 7 18:19:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65814 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2629751wrd; Tue, 7 Mar 2023 11:54:42 -0800 (PST) X-Google-Smtp-Source: AK7set+abOxVT0tuuYSr3OsoM2zP9Bvd4o2EJvchYC7gwZwHNTNTeB+RZJ6Ppl6qdWLIOTqls5V8 X-Received: by 2002:a17:902:f691:b0:19d:1fce:c9ec with SMTP id l17-20020a170902f69100b0019d1fcec9ecmr19676683plg.37.1678218881861; Tue, 07 Mar 2023 11:54:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218881; cv=none; d=google.com; s=arc-20160816; b=sqRIrJP6p6IDOcFMRILCKpMs0P65GcL483wVKifik+hB0toIDCxVKqBdkRr7E2gkxE uO7s5uDdtcelELb9LUNQE5f307v9o3IelLQtgzJ2jm/BjA5wUnuCi106y5Tqe97cmNUk bEYV6YwlLOnpPV7xkVFy+8efTSY6tq2m65APUWVghH9UZiI4hF8nyqBv+QXbje5oOdKe gQa+dC4aGZrl1D7kzmTfR7byHZT5cjh73ATmhNhb0JOsP6YuZ/TaF1WgV8BqBKrmG1Ie U2D+qGAXA7IbWXVSF2Fz+vHHehNWUP6yl2NDJP3yplWECUNIe9QVNWcBAZj4EQCYnRNl ItRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Sn2fxt+0EJv5lIvLbNUL8ejRVCplbfRFG2MTH+GQqqo=; b=fzqkHLJ1QxjlzrNWHU1HHEXPfQ5XyXoa8W4xHMvNFRVGMMS3uAn92wYrMx1u7IrERC ODOl0lpWMzE/5Vym+J2fIRvl9ubV+vjKft4fb4ysmkkTAyQ2/NgRXzzcPMuU+S7jb1bk cQgqwxSPg2Bshs+xilfR62HinX//K2OspbeXtxhdnNM3pK/zpgoomgrvKhHIoKQYCBFI zc4wkrpt32UZHaTj3BspQ+D9KqwVO6mmKZig6VegkRqODUQ3UT5ap3JG3K266HorkNOP T4MeFavYM0lJvOA3A5krC/utGJLc64qcpTLamKfaZgx7qn0kB8Gj3Ky36WQLzA+PiqGD xTFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kyNeenAR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h193-20020a636cca000000b004fc1da19518si13028832pgc.1.2023.03.07.11.54.29; Tue, 07 Mar 2023 11:54:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kyNeenAR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232903AbjCGS0C (ORCPT + 99 others); Tue, 7 Mar 2023 13:26:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232812AbjCGSYj (ORCPT ); Tue, 7 Mar 2023 13:24:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24BBA4023; Tue, 7 Mar 2023 10:20:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 521C06154C; Tue, 7 Mar 2023 18:20:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F4B7C4339C; Tue, 7 Mar 2023 18:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213209; bh=LbCwYJ20y8eWkgkIiA04QacuVyTv59uOi6c3cF4SrJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kyNeenARGKJlqG3HD8EnysYP8c51Ld33M6PWizLGt8ypsiCtcUuossg80YghysKLN zBdbdOiz1ORJt8/CRSnBHrJIM52Hdgs9cQmDfZz4g8g7rmRwplEYzB1WV8QyZSpfkr 9yZD0xNCw032IjlfyIJiaKpBc0H4zN4b7AvrG0NipBsXlxcHnIUQMoi6G5OFw09WrO sebTljQ4yfzf14ka11TlzF7JjLHnaCuV6FM68ybWPUgKKhCoYjm6qT3XT2Mjw2IwyH 0GFegLnlSQ9xenDfva7lMyNmCMWTT3gnrdDrMWFvYR9ZIfUB0BjYp+++8yb+4h0Ap0 fe0JN2OjYrflQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Dimitris Michailidis Subject: [PATCH 07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:18 -0600 Message-Id: <20230307181940.868828-8-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739282447185729?= X-GMAIL-MSGID: =?utf-8?q?1759740042074306403?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Dimitris Michailidis --- drivers/net/ethernet/fungible/funcore/fun_dev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/fungible/funcore/fun_dev.c b/drivers/net/ethernet/fungible/funcore/fun_dev.c index fb5120d90f26..3680f83feba2 100644 --- a/drivers/net/ethernet/fungible/funcore/fun_dev.c +++ b/drivers/net/ethernet/fungible/funcore/fun_dev.c @@ -1,6 +1,5 @@ // SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) -#include #include #include #include @@ -748,7 +747,6 @@ void fun_dev_disable(struct fun_dev *fdev) pci_free_irq_vectors(pdev); pci_clear_master(pdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); fun_unmap_bars(fdev); @@ -781,8 +779,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev, goto unmap; } - pci_enable_pcie_error_reporting(pdev); - rc = sanitize_dev(fdev); if (rc) goto disable_dev; @@ -830,7 +826,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev, free_irqs: pci_free_irq_vectors(pdev); disable_dev: - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); unmap: fun_unmap_bars(fdev);