From patchwork Tue Mar 7 18:19:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65789 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2625647wrd; Tue, 7 Mar 2023 11:44:16 -0800 (PST) X-Google-Smtp-Source: AK7set8afIXSQl1ZbM3X71fM30eB+Vcw20m+9HvTFWJE02w6OAkKSh+F00sGBuQocLXw2VtOqd5Z X-Received: by 2002:a17:906:28d3:b0:8b2:3eb6:8661 with SMTP id p19-20020a17090628d300b008b23eb68661mr14791824ejd.8.1678218256003; Tue, 07 Mar 2023 11:44:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218255; cv=none; d=google.com; s=arc-20160816; b=y60ip3M7zQ7alfeITjKHCzul8sl5e8VmeMdof5TbuOFK0ed2UJUKtXMUukUGMlQICY CzVUd2pj8qeNEJuTB9a4x+JCVz0RhBWsYAe+DGvjdwnqFhgPlqxhqzZ4+aBr9LKIUukl twXf1pJRK6cMaN9yTKx4FtE3J6i0ATpTHRWkelS+OBzQah03OxcslccXD0ByHtK3IDLD Rs/+pI/i/GjjeqVv/B2+xDN5nTdwsGp53/kFqXuFzreJ0dOrtAX6vnXqA7BK0zY95cDL /7jFOz7FCj4lwWAmdySpelRLdV8y3F3MqnE3CmUqfuGDv07kKX9wFa2skb3ioRLt1RBm yEzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D6JuY3d/LdT1rmPoQ2v89XbFWbXOl8ak742OVIsM+rw=; b=YBRRJWa3831WZigdLVmD2aKxe0gtA++b4aDaoJbnquDcMJ9HWFE+790KdBVWgPOQCn l6hnQfVacwHUAwtgSl48dCKJ4krFw0u7rtaAdrwJg7TPeSBN1HBb3JDK9csaxhhndEXi +a5N68+d6n+Yn/oKuiUitXrHDWUyA0P6NHQ7F6hPkLBfGhxp5PNdnJpIL+OFylCuXbBV bwIrfdgpOdjAQ0NPBgP3gYKQXnhhyxFGw+u+YZSzzAf7NDmHUH3ipzenud4VqsmxLrRN As0/F+eUfaonJ/rVBH7DOtoznCJ0Z2XJCDt6/zEvR4L649GCU870MbavvO+LKdysLo5c 40FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cS8ss2Gp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p11-20020a1709066a8b00b008c9434c4b8asi401719ejr.234.2023.03.07.11.43.52; Tue, 07 Mar 2023 11:44:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cS8ss2Gp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232673AbjCGSY6 (ORCPT + 99 others); Tue, 7 Mar 2023 13:24:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232792AbjCGSYU (ORCPT ); Tue, 7 Mar 2023 13:24:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6C639CBF7; Tue, 7 Mar 2023 10:19:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EFAD6150F; Tue, 7 Mar 2023 18:19:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72D34C433EF; Tue, 7 Mar 2023 18:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213198; bh=5kyhbiBEtsJwMz5HCmxLv5VbTa4UdxUccaqPgY32uh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cS8ss2GpmOsDF5I8H1FALF4fgvR6vvWwMqBHwvoV3rPKwozyXYj68u9hukliqEYYf 5jliPnkvObXjJfS9jAbwiRZjSo4uSmwl51bZ/MscD5jUX2OfIO8ZHO5oiycrusfGas 8LKp++6SWDThELLs28W4YQzIGNrONDflbIdpmjGHzgshsK+3W+xLQXtAu6mGTr7A4t uHlbk0k5/nkXIo2TBpUQCp8bWwVSV2xaBjoX1OjXzCiky4nA2m1zO/T7XCmnSyvnaM RfeBDqkSsq4v/LKL5eUXGNKXXUdUMnfZhQEPQcqcYOyEGEOdMoK1yWGAzpKgAGcWW2 FpzmLQ4AyAT4w== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Chris Snook Subject: [PATCH 01/28] alx: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:12 -0600 Message-Id: <20230307181940.868828-2-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739386160376484?= X-GMAIL-MSGID: =?utf-8?q?1759739386160376484?= From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Chris Snook --- drivers/net/ethernet/atheros/alx/main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index 306393f8eeca..49bb9a8f00e6 100644 --- a/drivers/net/ethernet/atheros/alx/main.c +++ b/drivers/net/ethernet/atheros/alx/main.c @@ -39,7 +39,6 @@ #include #include #include -#include #include #include #include @@ -1745,7 +1744,6 @@ static int alx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto out_pci_disable; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); if (!pdev->pm_cap) { @@ -1879,7 +1877,6 @@ static int alx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) free_netdev(netdev); out_pci_release: pci_release_mem_regions(pdev); - pci_disable_pcie_error_reporting(pdev); out_pci_disable: pci_disable_device(pdev); return err; @@ -1897,7 +1894,6 @@ static void alx_remove(struct pci_dev *pdev) iounmap(hw->hw_addr); pci_release_mem_regions(pdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); mutex_destroy(&alx->mtx);