From patchwork Tue Mar 7 18:19:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 65788 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2625612wrd; Tue, 7 Mar 2023 11:44:11 -0800 (PST) X-Google-Smtp-Source: AK7set88uzlgXYgLxd/QU8Negp+OrZ065wCHwUHRIa+0Ahn8SAiN6bXXOvCy8QbW7kgTU0srbHrw X-Received: by 2002:aa7:d60b:0:b0:4bd:94b9:b8a8 with SMTP id c11-20020aa7d60b000000b004bd94b9b8a8mr13404675edr.26.1678218251319; Tue, 07 Mar 2023 11:44:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678218251; cv=none; d=google.com; s=arc-20160816; b=T+j7HAu6lCmnbTJcVrFaB38IP6pHckefj7KR7z4ahEghScATh8Yz/0TIH2DpT3O8qG i6aaB3vtNJzsbdS0cW25kPtP6+2ipw4RfWoqlfSzJOfTh3Z93chhwlhAmnSpNHkA6J66 MO4KVAqpNMpS9JD7wDpmtRI7N59jqj5xC7gXYJ5Az7Lr4ulnY/rUYsAFiPgps9b8z4ap M4H7nKBubGh7yxtCj7n51TNVXNV7OMeW+IbRPSU2x63KnkUKUtcTwve+Ry/AECh4w0D7 1MRWVU4K0vlVQFpK4AzUobfPyO8DQv1v2Dz+OcsAdzA102c+21b+ImAdgTDEJo9AY/Mu /X+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Lhk3DKu486ZkygOpVPiCzVMgY9OCPPQwgXnoJuEzzNc=; b=KUbl5NLYdwiBiC0VB2Dp5FFK8vqY65D4wvMUYhq59du1pBjgbRlhYfLi0+sONRPelv OsMjoCJAYmm27udhdt08MKN47U0momXl5vdiSkVisKO4WzoARbXxRhoDwikk4tnjOFmf NhAkbq6ZcMDpogkCLLSkBBzNHffpZrVenWp1ifQJEk8Ic2vsTGVb7z26gYqwFkMlrPxH 5uT1y2Nu5FqeejQmT6Ne3qnhXAwpRjw86+AXcYonZexfEJZKJuzTmV4fIwM4yjzA6mB1 HejRvmA14Is/zbp0jttcxOB9B21gJ63kDY+/YfyvzFzXEdgMwx7vXf/EMe+wS1yZD1xC uPsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kQYvDfn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i25-20020a056402055900b004adbb59bc8fsi836056edx.16.2023.03.07.11.43.47; Tue, 07 Mar 2023 11:44:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kQYvDfn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233014AbjCGS1t (ORCPT + 99 others); Tue, 7 Mar 2023 13:27:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232831AbjCGS0D (ORCPT ); Tue, 7 Mar 2023 13:26:03 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F67FA92FF; Tue, 7 Mar 2023 10:20:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A452FCE1C81; Tue, 7 Mar 2023 18:20:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9034C433D2; Tue, 7 Mar 2023 18:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213230; bh=nZWihkCB3+64Nvms7t3o5MvdKzSCnCMWUPwklzyFewQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kQYvDfn3TwVSoLlYr0Fli6KVLssSRynOqK7WfDIh1Fjs7cmSNir8VTvzfVL8rbwx6 KGwz3Ue5obr5LHMOYcAMhNuC8xTiXTNg/cGZI3tGQUO/F4q1IrAIpKxnCJEgugJXdM 5uAVhnruzYqFo4qLg1cjdmuctc/itLePLhZ34VcvZbCplgXAo7w9sXRt4Eq9Kvoqdt QoCIlKmG54H8SC2FvbtBcOqG++V2HZls0hUlW/pLIquLRRXW5dZ/7hNDyjx7GoxxCo dfnkLg9FvZO6lMy3mb6/QcE95iouWRbBS8R8OV0DzC/WRHkFqgj6W1jsZxc3StZwH7 lFD1zplDLQ8xQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:29 -0600 Message-Id: <20230307181940.868828-19-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759739381059941589?= X-GMAIL-MSGID: =?utf-8?q?1759739381059941589?= From: Bjorn Helgaas 51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to pci_disable_pcie_error_reporting() in ef100_pci_remove(). Remove this call since there's no apparent reason to disable error reporting when it was not previously enabled. Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core enables PCIe error reporting for all devices during enumeration, so the driver doesn't need to do it itself. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/ef100.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c index 71aab3d0480f..6334992b0af4 100644 --- a/drivers/net/ethernet/sfc/ef100.c +++ b/drivers/net/ethernet/sfc/ef100.c @@ -11,7 +11,6 @@ #include "net_driver.h" #include -#include #include "efx_common.h" #include "efx_channels.h" #include "io.h" @@ -440,8 +439,6 @@ static void ef100_pci_remove(struct pci_dev *pci_dev) pci_dbg(pci_dev, "shutdown successful\n"); - pci_disable_pcie_error_reporting(pci_dev); - pci_set_drvdata(pci_dev, NULL); efx_fini_struct(efx); kfree(probe_data);