diff mbox series

[18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()

Message ID 20230307181940.868828-19-helgaas@kernel.org
State New
Headers
Series PCI/AER: Remove redundant Device Control Error Reporting Enable |

Commit Message

Bjorn Helgaas March 7, 2023, 6:19 p.m. UTC 
  From: Bjorn Helgaas <bhelgaas@google.com>

51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to
pci_disable_pcie_error_reporting() in ef100_pci_remove().

Remove this call since there's no apparent reason to disable error
reporting when it was not previously enabled.

Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core enables PCIe error reporting for all devices during
enumeration, so the driver doesn't need to do it itself.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>
Cc: Martin Habets <habetsm.xilinx@gmail.com>
---
 drivers/net/ethernet/sfc/ef100.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Edward Cree March 8, 2023, 4:16 p.m. UTC | #1 
On 07/03/2023 18:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> 51b35a454efd ("sfc: skeleton EF100 PF driver") added a call to
> pci_disable_pcie_error_reporting() in ef100_pci_remove().
> 
> Remove this call since there's no apparent reason to disable error
> reporting when it was not previously enabled.
> 
> Note that since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core enables PCIe error reporting for all devices during
> enumeration, so the driver doesn't need to do it itself.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Edward Cree <ecree.xilinx@gmail.com>
> Cc: Martin Habets <habetsm.xilinx@gmail.com>
> ---

Yeah it looks like we meant to add an enable too but lost it somewhere
 in the upstreaming process.  Anyway,
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c
index 71aab3d0480f..6334992b0af4 100644
--- a/drivers/net/ethernet/sfc/ef100.c
+++ b/drivers/net/ethernet/sfc/ef100.c
@@ -11,7 +11,6 @@ 
 
 #include "net_driver.h"
 #include <linux/module.h>
-#include <linux/aer.h>
 #include "efx_common.h"
 #include "efx_channels.h"
 #include "io.h"
@@ -440,8 +439,6 @@  static void ef100_pci_remove(struct pci_dev *pci_dev)
 
 	pci_dbg(pci_dev, "shutdown successful\n");
 
-	pci_disable_pcie_error_reporting(pci_dev);
-
 	pci_set_drvdata(pci_dev, NULL);
 	efx_fini_struct(efx);
 	kfree(probe_data);