From patchwork Tue Mar 7 16:44:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 65708 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2540450wrd; Tue, 7 Mar 2023 08:58:37 -0800 (PST) X-Google-Smtp-Source: AK7set9LeBtz6TigqBboRikL7Z2UyqD2jTqZUAShzqrqWVAE8epuzO9VlYElpk0sbITwRj/ZAbAc X-Received: by 2002:aa7:c589:0:b0:4af:6e08:319 with SMTP id g9-20020aa7c589000000b004af6e080319mr19227021edq.15.1678208316878; Tue, 07 Mar 2023 08:58:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678208316; cv=none; d=google.com; s=arc-20160816; b=QzBoIiORTFJSDNG9JZIPhFZKTdAskyzdxJZ6TUJNHEC6EJMF6DmWYtIc46zT2F5R1L BYR43ughEvrRe+EuHAoCW28+M1WhKcDVW1gOBaQ0dti3wXBeOWKl+uQz2i3jLO5h+tfw 4qbUQh6cTT0WSgnnaUPJjwxNFggO+Jqm4jpuNAIsRIP9uHv/srgpRFStThJbzuKNTAuG BsGlgtYxMTS1Pea8wPr0hFx+jHTnnVgqqxTVvEUW1o1sGfppqJ4/54eLZ06Wtxvor6qO Eh7mD8cMzXkTjXYAbTUpXTw475zDWPODFZbyQq/bpq4dQEG8aZT/OzErbiXuR3iOd/ct jdSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/5j+uLA9hx0qhDY/pP8ftBODCp74kQCH4cYymHokHLU=; b=nxuH+WfeP4Y2+Vask4o5iGsJRRBBFiCQmrz0ya9DYTh74FkB8ZgA9zFfogzqIx0jfT SdtdtlqlDFZiIv9IxZUYneBpsXF2erMbJOtilIUPF6/7h1Ex3inYei8EvaEfgqz6GPcy bacQ2bfYE0tWAvQ9YxsTNIs6EPG5Lr95ATIpjVXVblxdigZd9JXpdTPu29uD8LjlYvPF jwXmvziwlasxZVF0dFi3mbaPrHCoAtB8U0+MQp8C1ZGKTs5uQh2GxtG0CwVD/cBwrTmq /gDeZN4BwL95E+lhK+UHZMHnKuJz0urpU5okICuKvnkFJKAowfTvK8WqMWaENed9w5Gq 38lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s5eQ16Pb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m9-20020a1709066d0900b008b17ac3edb8si11044381ejr.675.2023.03.07.08.58.13; Tue, 07 Mar 2023 08:58:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s5eQ16Pb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbjCGQrN (ORCPT + 99 others); Tue, 7 Mar 2023 11:47:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229976AbjCGQqh (ORCPT ); Tue, 7 Mar 2023 11:46:37 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6701D211D5; Tue, 7 Mar 2023 08:43:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB288614D1; Tue, 7 Mar 2023 16:43:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18C71C4339C; Tue, 7 Mar 2023 16:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678207417; bh=nr7223xxoM6+3D2kuSbPhGCYTqq1ERzivz361j3EF3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s5eQ16PbFgS8bt+xxIG7HhBp99LyC48qMXEOdCl6Hkw4Snt938cXBRWAhRcYqo6PZ Uyw4joS7AXANqJSP4HrrzO3WfSkYU/HtVtalesDI1LMXLdxZd2koXkS2+j5+6hePsp zdWLa9GAT9L33Z+KN7+wHKUxde0AgkIpV3CF/ZpRgQkQYZL5Cdo59YJQMUfBBX0VWZ CbnjgDNhd4VFNUr/4KTCyee1nhqjsgHtp4NaGC5w4EliWWd1i1YaI0L2Al6YXzh+1g TuQcTLtcN1+z0gtCENyv8dueZI4J55Ljn1jCiyhqoOF/Fa7+M4zlSe15sirQp0yjXA +X723GnvHb8sQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pZaQH-0003i9-6y; Tue, 07 Mar 2023 17:44:21 +0100 From: Johan Hovold To: Greg Kroah-Hartman Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Jiri Slaby , Bartosz Golaszewski , Douglas Anderson , Daniel Thompson , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 4/4] serial: qcom-geni: drop bogus uart_write_wakeup() Date: Tue, 7 Mar 2023 17:44:05 +0100 Message-Id: <20230307164405.14218-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230307164405.14218-1-johan+linaro@kernel.org> References: <20230307164405.14218-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759728963907080333?= X-GMAIL-MSGID: =?utf-8?q?1759728963907080333?= Drop the bogus uart_write_wakeup() from when setting up a new DMA transfer, which does not free up any more space in the ring buffer. Any pending writers will be woken up when the transfer completes. Signed-off-by: Johan Hovold Reviewed-by: Douglas Anderson --- drivers/tty/serial/qcom_geni_serial.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 9871225b2f9b..28fbc927a546 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -634,10 +634,6 @@ static void qcom_geni_serial_start_tx_dma(struct uart_port *uport) if (uart_circ_empty(xmit)) return; - xmit_size = uart_circ_chars_pending(xmit); - if (xmit_size < WAKEUP_CHARS) - uart_write_wakeup(uport); - xmit_size = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE); qcom_geni_serial_setup_tx(uport, xmit_size);