From patchwork Tue Mar 7 12:31:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 65433 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2404980wrd; Tue, 7 Mar 2023 04:39:27 -0800 (PST) X-Google-Smtp-Source: AK7set+l6f+QRQ50TLvoIhUPfssTlg44xe5BOcrpy+UzZHmKgvAAFRKQelJUxx0Tw/QOoZIaxq1f X-Received: by 2002:aa7:968e:0:b0:5a9:bba9:f25b with SMTP id f14-20020aa7968e000000b005a9bba9f25bmr14177036pfk.17.1678192766888; Tue, 07 Mar 2023 04:39:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678192766; cv=none; d=google.com; s=arc-20160816; b=TJfukiTi9jY7CEIDjnbFJLJoTgoamOh7HVBqHbcgduGXTvCvUsgkHgYpwR6IYjCXB6 l7FkzYAdOtVgGCZuR6LOGABNvdsQsueXnUpEi883lfaLQhzf2laRQ+RIEFluZOI0F5Gj NmsHuW0TLPLwhmDsJQD6+bdx6w2m9JcAoLmDSQaFkhW7nGSCHUS94EG8xbSA9E5ykY5/ MelWyBhmd4c/niJBYBtPHeRVnh5vXPlV4a3bi2EqvIYQIFjpsVfT38eDTql+WQzlNMRK aolfje8NSUfiDAuQkf3OZmwEvJimhO0lQt+B1m7f55j2vQOUf9ncuDFOcaNXNYch2pwL c1ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xoKKJZFHs/8MSrXZ3Q3rY87HaTCz1bnlS/tCHR2CSg8=; b=C7ZK6Ao5uask0sTax6p2sivMqru7ccTWXiBD5GJ0MtX0MY4zJlCHDUBbN9NpuLjPxG o6lScDKN1w9+7mF9vvrYEpGt5qnpaOV7J7R/CMvXLukADAFYk6XND0k9WsIcNs5Ym4rv I6uScxK8G5ogAF6iuDM/DaChYstW2hv9/hWYC6obB0qu/s8igwM1eD91PAzqhQjbBnYU NSLJLfr8YJvLbbRyiY4+v8WVjTfLR6ECynsHaGPjjsWdSNrFdEH4avhJIbKqTSn5RFmp MyxvgQtEwGgOw8vlJbF5XKYtNsSc5EfzWx3Es38eGpn20kjGsuPtyL1eegEyvucT3QNX Xqqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="iukR/+gr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f13-20020aa79d8d000000b00593ac87bbadsi11471478pfq.202.2023.03.07.04.39.13; Tue, 07 Mar 2023 04:39:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="iukR/+gr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbjCGMcN (ORCPT + 99 others); Tue, 7 Mar 2023 07:32:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjCGMcJ (ORCPT ); Tue, 7 Mar 2023 07:32:09 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B875E77CAB for ; Tue, 7 Mar 2023 04:32:06 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id t14so12957463ljd.5 for ; Tue, 07 Mar 2023 04:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678192325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xoKKJZFHs/8MSrXZ3Q3rY87HaTCz1bnlS/tCHR2CSg8=; b=iukR/+gr8EDtbfyWkLTmOTMQnMAsxA/0IeNzNwgq/dhuq9kO6YGSJosg68f368zs15 YstaY/Co/MOS3Qp3JiWxIWMuC21LDZWh03BFpQKUDWfdx3935xpOSs8fPXDwYAIkHcAg CH/HQ3F8DMCCNRdR4VFlCJhmbLftuEpuioYs28eaX9BzZHmtDgl/8B9vuHe527AMUNrp rt/fT+PhZJbUQKKPYrfjuhZ8oStjiQSkHtyRuHmK/f5NiuCQL9phOn70TJwUaZE5cG4z HbdZHc35xbDUnRBrad5Rm5jt3Xau35GnjeMdzmSjIfJ4WjfD8OlEgUt1DqwTCfaFa6a9 P7ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678192325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoKKJZFHs/8MSrXZ3Q3rY87HaTCz1bnlS/tCHR2CSg8=; b=w2iW2IPprHmu9tN4TKNYb133Rw2fFzWQ1z5pX8LogkcS7blhBpVSk13C/hsfgn/ycP gms9k4eNo3O0PW5P0+C+VALY0tv78zHa7Zla8o6MUqZ9VsQ0P47wva2NLBb1O8hzSHlK NRwD0Nx0bY1oUzvE0vHYQQPbOjmVMj2WBmQEzKL0Z9xc9+su6FxcLExhq9Y+9LXZTSnY 8Dyjd+rzH4Jqja++LyyA+ejiIGPEeHI1l+SyhtXuTtAt8Xnj4hCmUUzGe8/X7EPOeq1J MOfIa7/WmGyjcvNEQjGfiVKkcaPWdCresNDGCmRcafWALlc8n6TH/uHiwhnGL8UbfssN fBUw== X-Gm-Message-State: AO0yUKXZvXY5cKRmv7o1ZMuNf1bI+Vx+AHsR3ABRN9HRAouGG7U2mt7G len+LQsggxyaoIFH7tpPbAENsA== X-Received: by 2002:a2e:808e:0:b0:295:9ba2:8a78 with SMTP id i14-20020a2e808e000000b002959ba28a78mr4869643ljg.17.1678192325107; Tue, 07 Mar 2023 04:32:05 -0800 (PST) Received: from localhost.localdomain (abyj16.neoplus.adsl.tpnet.pl. [83.9.29.16]) by smtp.gmail.com with ESMTPSA id t20-20020a2e7814000000b0029462e98c07sm2156501ljc.35.2023.03.07.04.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 04:32:04 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] clk: qcom: gcc-msm8998: Update the .pwrsts for usb gdsc Date: Tue, 7 Mar 2023 13:31:59 +0100 Message-Id: <20230307123159.3797551-3-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230307123159.3797551-1-konrad.dybcio@linaro.org> References: <20230307123159.3797551-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_HTTP,RCVD_IN_SORBS_SOCKS,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759712658325725981?= X-GMAIL-MSGID: =?utf-8?q?1759712658325725981?= The USB controller on msm8998 doesn't retain its state when the system goes into low power state and the GDSCs are turned off. This can be observed by the USB connection not coming back alive after putting the device into suspend, essentially breaking USB. Work around this by updating the .pwrsts for the USB GDSCs so they only transition to retention state in low power. This change should be reverted when a proper suspend sequence is implemented in the USB drivers. Signed-off-by: Konrad Dybcio --- v1 -> v2: New patch drivers/clk/qcom/gcc-msm8998.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c index f1aacbfe6bb4..8790bbdcd2e2 100644 --- a/drivers/clk/qcom/gcc-msm8998.c +++ b/drivers/clk/qcom/gcc-msm8998.c @@ -2901,7 +2901,8 @@ static struct gdsc usb_30_gdsc = { .pd = { .name = "usb_30_gdsc", }, - .pwrsts = PWRSTS_OFF_ON, + /* TODO: Change to OFF_ON when USB drivers get proper suspend support */ + .pwrsts = PWRSTS_RET_ON, .flags = VOTABLE, };