diff mbox series

[v2,3/3] clk: qcom: gcc-msm8998: Update the .pwrsts for usb gdsc

Message ID 20230307123159.3797551-3-konrad.dybcio@linaro.org
State New
Headers
Series [v2,1/3] clk: qcom: gcc-sm6375: Update the .pwrsts for usb gdsc |

Commit Message

Konrad Dybcio March 7, 2023, 12:31 p.m. UTC 
  The USB controller on msm8998 doesn't retain its state when the system
goes into low power state and the GDSCs are turned off.

This can be observed by the USB connection not coming back alive after
putting the device into suspend, essentially breaking USB.

Work around this by updating the .pwrsts for the USB GDSCs so they only
transition to retention state in low power.

This change should be reverted when a proper suspend sequence is
implemented in the USB drivers.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
New patch

 drivers/clk/qcom/gcc-msm8998.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
index f1aacbfe6bb4..8790bbdcd2e2 100644
--- a/drivers/clk/qcom/gcc-msm8998.c
+++ b/drivers/clk/qcom/gcc-msm8998.c
@@ -2901,7 +2901,8 @@  static struct gdsc usb_30_gdsc = {
 	.pd = {
 		.name = "usb_30_gdsc",
 	},
-	.pwrsts = PWRSTS_OFF_ON,
+	/* TODO: Change to OFF_ON when USB drivers get proper suspend support */
+	.pwrsts = PWRSTS_RET_ON,
 	.flags = VOTABLE,
 };