From patchwork Tue Mar 7 12:31:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 65434 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2407485wrd; Tue, 7 Mar 2023 04:46:11 -0800 (PST) X-Google-Smtp-Source: AK7set9c6l3JGjdw0hrkZmZPhrUy2xUHoy8PFNB+OswMgwCKVyNiQht11yYIZMy30jY2+MID91KG X-Received: by 2002:a05:6a20:1582:b0:cb:c266:3f6b with SMTP id h2-20020a056a20158200b000cbc2663f6bmr14889756pzj.12.1678193171136; Tue, 07 Mar 2023 04:46:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678193171; cv=none; d=google.com; s=arc-20160816; b=vwB7EOknYQrG+DkJA8NrIwzPd0hW/avAMrHwA0sAa1FZEH+PVwk5Fd+LhdCGBeMnm/ nHtXuF8u+8qpgs9EvRYvorEmyNe1uR8rybfIXgyi30ETZedFGYd2wm2UzJLFBR0ItHLR M3aAx6yft7sJUptb1vbI6HA125fHaPcLpo11bB3RyfRpRFI4m2F9QjvEGA64qYA1PfSc /8BoZyD/6fOeie8ks2h4Qz/qnOvD+uQ4j4tkZO+W77+S9yLl0M8vNkt97YkIv/SJRFzV isiG+dd5vOejKp9A5Bis4SbKGuOZumO+Vb5JT9amCYU291U9BCpL7PUGlYjM041dKGci zxFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vcymAsSfgo0T3+vs1DGeeROeS5a7cMEN49XDIkMpxfg=; b=QPz9+4aDGIv30ZDo7Y+YEfNyEyFDMytPMohypOhTYvfobj0mtEE+hIE98sDIwL/sfz NFeAu3JGBKM+xqODtIn1/Kih+u1pN5pPldQ+584AlX6rqjv8BWeSOQs0/M3svpzXWLlo xLaHte/EoyeHvhzTfVf2SNe/a7HRb7U539ARrk3Fi/1mjzS5xpujjHrtxZHzwYIIvTtf 1h7jg2yOMikgGRwZkzfBHBZl3dM0p8mhQjaAA/SF6aOH+EeiaFAEbs7voJsHvgqAsOeb fJdJ7a/o61YvJ0HHcBKrDvu5Ieq2xc4qQq/ORqpIENDxOhS6LgHmFoNdqTD4bWO++uuX CRVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MpcYncKv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p27-20020aa79e9b000000b005a911b0a4e0si12087435pfq.240.2023.03.07.04.45.55; Tue, 07 Mar 2023 04:46:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MpcYncKv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbjCGMcK (ORCPT + 99 others); Tue, 7 Mar 2023 07:32:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbjCGMcI (ORCPT ); Tue, 7 Mar 2023 07:32:08 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B62E477C97 for ; Tue, 7 Mar 2023 04:32:05 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id z42so12916779ljq.13 for ; Tue, 07 Mar 2023 04:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678192324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vcymAsSfgo0T3+vs1DGeeROeS5a7cMEN49XDIkMpxfg=; b=MpcYncKvmfwJI9vzqRxHDqSv5X7Je8evTDWTOx5wvFHZcXomu1VweUaiPNyzlsduEm 4P1Q1jBSFlnB+gItEhtlEcregtrwdezxyGMZV5GgWfiFA1y4Ij2C+LIIG7hv9BxSRh// wlIPD93XE4CKqzxO8zcZ40MEEoXqE2prYPonzjp2277dKoIqCxhxuqec+20N++G/XI8E CvnJaEqWl5WYsdozc12OfHWvO/FD6ydGxLe/ZZ8LQ3tBUi5emx9nic8MuwyJB0iJKhmi 7J+f//sZon4XMK6izt1ffXgPicd6ZR+8xRnOJWEvsjpzgQttiWAULtI8lgkl5CDWsIoD OytQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678192324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vcymAsSfgo0T3+vs1DGeeROeS5a7cMEN49XDIkMpxfg=; b=drfMyBPbQPK/y+xdAMwW1kHamRYxj/rAnowEbxtItQNVeNutdYQs49SweZnGCSbrPT RsL35FWSwq2Rpw1wfNF04ddhmmgss7Ge1GKrkxS7motEmoElLXJps6rRUY7z7Jg3fT4d 82Qu76VgdfTJ3paJIr5V84pTFMrtqvpaJl2ee38bcESAOQdLhVjtKyqoG7PFS/R7KR+L EPK0AHoQZfGxOFhVdLrox9Aslx0+mo97brYXm2ITHdNejbrdcXXRl7v6gAVFMkV2zkNA GmBCG858PTkp/t378lisgCsQl6aM3/yeejbRqRQ0OYWRde4unyTpiAtSLcArbZx+pXWZ IYrA== X-Gm-Message-State: AO0yUKW2c8GItLNRoa+I5YnH1gtegXV/CDFXd7lR1S03ABrKqYYBw/Nn PbOV5CjtWoup+Vj5JfYIxTw7+A== X-Received: by 2002:a05:651c:1682:b0:293:2bf4:d939 with SMTP id bd2-20020a05651c168200b002932bf4d939mr4188139ljb.12.1678192323932; Tue, 07 Mar 2023 04:32:03 -0800 (PST) Received: from localhost.localdomain (abyj16.neoplus.adsl.tpnet.pl. [83.9.29.16]) by smtp.gmail.com with ESMTPSA id t20-20020a2e7814000000b0029462e98c07sm2156501ljc.35.2023.03.07.04.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 04:32:03 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] clk: qcom: gcc-msm8996: Update the .pwrsts for usb gdsc Date: Tue, 7 Mar 2023 13:31:58 +0100 Message-Id: <20230307123159.3797551-2-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230307123159.3797551-1-konrad.dybcio@linaro.org> References: <20230307123159.3797551-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_HTTP,RCVD_IN_SORBS_SOCKS,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759713082872704771?= X-GMAIL-MSGID: =?utf-8?q?1759713082872704771?= The USB controller on MSM8996 doesn't retain its state when the system goes into low power state and the GDSCs are turned off. This can be observed by the USB connection not coming back alive after putting the device into suspend, essentially breaking USB. Work around this by updating the .pwrsts for the USB GDSCs so they only transition to retention state in low power. This change should be reverted when a proper suspend sequence is implemented in the USB drivers. Signed-off-by: Konrad Dybcio --- v1 -> v2: - Reword "fix" to "work around", mention it should be temporary - Add TODO: drivers/clk/qcom/gcc-msm8996.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c index e16163706735..5e44d1bcca9e 100644 --- a/drivers/clk/qcom/gcc-msm8996.c +++ b/drivers/clk/qcom/gcc-msm8996.c @@ -3455,7 +3455,8 @@ static struct gdsc usb30_gdsc = { .pd = { .name = "usb30", }, - .pwrsts = PWRSTS_OFF_ON, + /* TODO: Change to OFF_ON when USB drivers get proper suspend support */ + .pwrsts = PWRSTS_RET_ON, }; static struct gdsc pcie0_gdsc = {