From patchwork Tue Mar 7 09:05:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dongliang Mu X-Patchwork-Id: 65335 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2329956wrd; Tue, 7 Mar 2023 01:23:01 -0800 (PST) X-Google-Smtp-Source: AK7set8FMyRtyZOvFXlKsV6nLKZx2t/shvAIvk1XJTvaOLQrWj9yhwaC5vmX9IWtbqz/JC0ieT9O X-Received: by 2002:a17:907:7b0a:b0:86f:b99c:ac8d with SMTP id mn10-20020a1709077b0a00b0086fb99cac8dmr15704820ejc.44.1678180981227; Tue, 07 Mar 2023 01:23:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678180981; cv=none; d=google.com; s=arc-20160816; b=cuWdLEjo0UetAjJhdXlltFSetB5ml6e743TZ6n7VGFGDPQRPCry2qVcoVpFKUcq6zo gyYYjJmsQOonopZH4zzhD/QeISMOjkLjW/k2LK5InbrN2MTWSVraU4eOM7di2pbKyBd1 Oxth8EzYWDX3A6NL2oQhPWk3bIdMBbo26N3AWNEp2w8YjoaMTzRka+QIRTIZ7IhkJeHc lpJMuozpoQRhn2Rc44Wz1/l1x9F5F8mr9JYZaexcA/aSUSwpY8As0JJu2LJ6Fi4TICN1 kPPA4Jw+mkxqgCL3PVu9wQD9kcBGAScRr+xSIgDj50QB4hB6JupepaInYRp6FOSNS/Ic EZxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NToO6SkrMYKakhmPFjrwO2G1ZL4wF4yjM0jooWYOUfc=; b=l1zGVxvTWp5kuu47r4q29dd6D4QJRl3yMcCwpJSS6dm+VoeDIsKWoRWD6dqQm//d2g +O5shzNjaey1SpRk5eu13DpfLvO1cuJuUGJsb7m/KAvHHKZgHToMyirBXp+DUhVclXmJ Lb1JzWBwcKTsrVl60/v5qPQVlvc4Lad0ZBoaG0pDpUs1ualoT6JJAJ77qOXhBfU4+cLW 5shlmCHdPalk9FU2jbLZIC5JgbtKI2c6HuF+I0hTJZoZfO9fep3ye6dDKvnZ+NwmtLNe xbCuO50thecDqzvJg986OQDXGhPXeGz2O//wgGwpTD1qYZKHdOuspcA9rjjaVEmBmtZf LI3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020aa7d5c1000000b004c0abff5545si11829648eds.614.2023.03.07.01.22.37; Tue, 07 Mar 2023 01:23:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbjCGJSf (ORCPT + 99 others); Tue, 7 Mar 2023 04:18:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230089AbjCGJSc (ORCPT ); Tue, 7 Mar 2023 04:18:32 -0500 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D5F372018; Tue, 7 Mar 2023 01:18:31 -0800 (PST) Received: from pride-PowerEdge-R740.. ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 32795l0Y024133-32795l0b024133 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 7 Mar 2023 17:05:51 +0800 From: Dongliang Mu To: Alexander Aring , Stefan Schmidt , Miquel Raynal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Dongliang Mu , syzbot+bd85b31816913a32e473@syzkaller.appspotmail.com, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] net: ieee802154: fix a null pointer in nl802154_trigger_scan Date: Tue, 7 Mar 2023 17:05:46 +0800 Message-Id: <20230307090546.994258-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-FEAS-AUTH-USER: dzm91@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759700300467254055?= X-GMAIL-MSGID: =?utf-8?q?1759700300467254055?= There is a null pointer dereference if NL802154_ATTR_SCAN_TYPE is not set by the user. Fix this by adding a null pointer check. Reported-and-tested-by: syzbot+bd85b31816913a32e473@syzkaller.appspotmail.com Fixes: a0b6106672b5 ("ieee802154: Convert scan error messages to extack") Signed-off-by: Dongliang Mu --- v1->v2: add fixes tag net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index 2215f576ee37..1cf00cffd63f 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1412,7 +1412,8 @@ static int nl802154_trigger_scan(struct sk_buff *skb, struct genl_info *info) return -EOPNOTSUPP; } - if (!nla_get_u8(info->attrs[NL802154_ATTR_SCAN_TYPE])) { + if (!info->attrs[NL802154_ATTR_SCAN_TYPE] || + !nla_get_u8(info->attrs[NL802154_ATTR_SCAN_TYPE])) { NL_SET_ERR_MSG(info->extack, "Malformed request, missing scan type"); return -EINVAL; }