diff mbox series

leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908

Message ID 20230307082936.16631-1-lukas.bulwahn@gmail.com
State New
Headers
Series leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908 |

Commit Message

Lukas Bulwahn March 7, 2023, 8:29 a.m. UTC 
  Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.

Probably due to concurrent development, commit a0ba692072d8 ("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support
for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
not visible during the config refactoring from the commit above. Hence,
these two changes create a reference to a non-existing config symbol.

Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
ARCH_BCM4908 to remove the reference to the non-existing config symbol
ARCH_BCM4908.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 drivers/leds/blink/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rafał Miłecki March 7, 2023, 9:41 a.m. UTC | #1 
On 2023-03-07 09:29, Lukas Bulwahn wrote:
> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 945c84286a4e..bdcb7377cd4e 100644
> --- a/drivers/leds/blink/Kconfig
> +++ b/drivers/leds/blink/Kconfig
> @@ -1,10 +1,10 @@
>  config LEDS_BCM63138
>  	tristate "LED Support for Broadcom BCM63138 SoC"
>  	depends on LEDS_CLASS
> -	depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> +	depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
>  	depends on HAS_IOMEM
>  	depends on OF
> -	default ARCH_BCM4908
> +	default ARCH_BCMBCA
>  	help
>  	  This option enables support for LED controller that is part of
>  	  BCM63138 SoC. The same hardware block is known to be also used

William: do we want LEDS_BCM63138 default on all BCMBCA devices?
William Zhang March 8, 2023, 12:45 a.m. UTC | #2 
Hi Rafal,

On 03/07/2023 01:41 AM, Rafał Miłecki wrote:
> On 2023-03-07 09:29, Lukas Bulwahn wrote:
>> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
>> index 945c84286a4e..bdcb7377cd4e 100644
>> --- a/drivers/leds/blink/Kconfig
>> +++ b/drivers/leds/blink/Kconfig
>> @@ -1,10 +1,10 @@
>>  config LEDS_BCM63138
>>      tristate "LED Support for Broadcom BCM63138 SoC"
>>      depends on LEDS_CLASS
>> -    depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
>> +    depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
>>      depends on HAS_IOMEM
>>      depends on OF
>> -    default ARCH_BCM4908
>> +    default ARCH_BCMBCA
>>      help
>>        This option enables support for LED controller that is part of
>>        BCM63138 SoC. The same hardware block is known to be also used
> 
> William: do we want LEDS_BCM63138 default on all BCMBCA devices?
Yes that is fine. We can always build this driver for BCMBCA but it will 
be only probed and running if dts enable such device.
William Zhang March 8, 2023, 12:49 a.m. UTC | #3 
On 03/07/2023 12:29 AM, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
> 
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
> 
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>   drivers/leds/blink/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 945c84286a4e..bdcb7377cd4e 100644
> --- a/drivers/leds/blink/Kconfig
> +++ b/drivers/leds/blink/Kconfig
> @@ -1,10 +1,10 @@
>   config LEDS_BCM63138
>   	tristate "LED Support for Broadcom BCM63138 SoC"
>   	depends on LEDS_CLASS
> -	depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
> +	depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
>   	depends on HAS_IOMEM
>   	depends on OF
> -	default ARCH_BCM4908
> +	default ARCH_BCMBCA
>   	help
>   	  This option enables support for LED controller that is part of
>   	  BCM63138 SoC. The same hardware block is known to be also used
> 
Acked-by: William Zhang <william.zhang@broadcom.com>
Rafał Miłecki March 8, 2023, 6:21 a.m. UTC | #4 
On 2023-03-07 09:29, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to 
> ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
> 
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use 
> was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
> 
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Acked-by: Rafał Miłecki <rafal@milecki.pl>
Pavel Machek March 25, 2023, 4:19 p.m. UTC | #5 
On Tue 2023-03-07 09:29:36, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
> 
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
> 
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Do we really want this "default Y" on those architectures? I'd understand
it for something critical but LED is not, and if it is not even present on
all such machines...

BR,
									Pavel
Florian Fainelli March 25, 2023, 4:34 p.m. UTC | #6 
On 3/7/2023 12:29 AM, Lukas Bulwahn wrote:
> Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA")
> removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
> 
> Probably due to concurrent development, commit a0ba692072d8 ("leds:
> bcm63138: add support for BCM63138 controller") introduces 'LED Support
> for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was
> not visible during the config refactoring from the commit above. Hence,
> these two changes create a reference to a non-existing config symbol.
> 
> Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of
> ARCH_BCM4908 to remove the reference to the non-existing config symbol
> ARCH_BCM4908.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
diff mbox series

Patch

diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 945c84286a4e..bdcb7377cd4e 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -1,10 +1,10 @@ 
 config LEDS_BCM63138
 	tristate "LED Support for Broadcom BCM63138 SoC"
 	depends on LEDS_CLASS
-	depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
+	depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST
 	depends on HAS_IOMEM
 	depends on OF
-	default ARCH_BCM4908
+	default ARCH_BCMBCA
 	help
 	  This option enables support for LED controller that is part of
 	  BCM63138 SoC. The same hardware block is known to be also used