From patchwork Tue Mar 7 15:32:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 65652 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:570d:b0:a1:2e52:cf23 with SMTP id h13csp1977416dyk; Tue, 7 Mar 2023 07:53:22 -0800 (PST) X-Google-Smtp-Source: AK7set/+4Jtrn77h4I7jPhGSw6MaQclCrlLQoNyOcyd4BXlI587GGOwjIU31CGCK5e8kPrOWSdR0 X-Received: by 2002:a17:907:3e07:b0:8b1:2867:380 with SMTP id hp7-20020a1709073e0700b008b128670380mr20485268ejc.22.1678204402049; Tue, 07 Mar 2023 07:53:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678204402; cv=none; d=google.com; s=arc-20160816; b=slOz2qJHfITpUqApxzGIc/3Ak1plf+TydIZHBRL80feGW0A1YIb5NagulhIdLAKt9i pfpqWSa6UVVv1abb9+kCieEhZhfXRgaZnBcN+XLStQquABpP5ESCflWnaKUpQp38328B NFLEUUhCvy4pYK+tVDAp81m96dpQx3WllyMHXqBTDJjs1PodxGGkGnQs3NbXcOHFCqwy JveCsBkyn9DMwjciTNMB/aYVlXeqy0MuZduzEQNL5qKbbgVEjdDpZXa3JEPUZHepSSL9 t5LaYHWUiL+HM684RLooqhn4Tu1VFxl6+yTzhvA5fPiFYK0snNk+FbPpfBBS1+noBnFa TG3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ON/hRDAPf2AptDjynSCH9JnA/LFyPWk7i2ryXctmn+Y=; b=Jh9WWAG4Cy/L7pi404152W+4LqdLw9hF7hhtca7ZBmA03ZHAA8AS9nlWDmk5XbqttM lFDBhM4CWFkpRuLlUJwI0v1IwswAWLDAvYOdw2Uv/T7nUKe9ZuNYYql5QEn/KCP2Ae3I ny0UCn+r6GyKxPvO5FvNUWp8XVFTycw3B5Z1EuryuJamfsn5GI+qseeQwSZeIy3LyKwn a9Se0aZyV+Y3wOLBzzRIpuWcZLvhNBBlpqzUDWGQkvfBctDdTPzmNov487FcTeNww0rL sQsuMQqA8k4pe2/FRJmoqsN22cIaZlDkL5h+7zESdukX3mmdFhRsydBNXZ9vnRiKmRps TeEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="k/thYJ/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r9-20020a170906280900b008d2c91d5119si11057749ejc.308.2023.03.07.07.52.58; Tue, 07 Mar 2023 07:53:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="k/thYJ/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbjCGPdO (ORCPT + 99 others); Tue, 7 Mar 2023 10:33:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231314AbjCGPdD (ORCPT ); Tue, 7 Mar 2023 10:33:03 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 141217C95F for ; Tue, 7 Mar 2023 07:32:50 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id x34so13611707pjj.0 for ; Tue, 07 Mar 2023 07:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1678203169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ON/hRDAPf2AptDjynSCH9JnA/LFyPWk7i2ryXctmn+Y=; b=k/thYJ/FejPWQY4Da3JnlIuxHSfFvf4jPgd0UIQ0b2XdTdjVTjlWvj9Vx0coE8ZGNf TSjcSYegW3Cq0PnDGKlL2Mfhd98ZxGSjG6XDb53DyE4nz6OldnbCqYZUKhF9YiHygxIC fnVimmDFtsACmxvO0ejshyH9K8EW9IuNupb40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678203169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ON/hRDAPf2AptDjynSCH9JnA/LFyPWk7i2ryXctmn+Y=; b=CJpAPJzTYxSzwZOPb/uip4N46GoNWkC+NOI1/3f2BQ343zjKgM7EPix+C8HR9JjzDB JrywKV1VXxSXiAs0ZLlE6h0eqQfuT53lqHlrK1dmRbQYxpy5bhzmrFStfplh1hDiWS40 HjWW7bB/fDmAMWW/eLWwrzPkpmMkjlkF1vegWoMMSaCqu04HJxbxRAVmcAiRE5FznW6U I7tFjTyMXmKjtv5sKZz8wrdymeycdVwx8dxGcQjZbT5DIhbu2F6lkQeJuV0si4A2CVpf wckg+eVKjhOQ/qvinRsN7ACcPbp7xD3vmbZTh1ciSfLJiaNAQJ2Dd2AFLOM5iPplhsa6 OzKQ== X-Gm-Message-State: AO0yUKWspO0MvVyyOK8+VwUJ1mT/xHP9hssjOFRjpiNPOuS7NecHPhxV IxAiM6BwhXH5YRtgBdujlVDJJQ== X-Received: by 2002:a17:902:7798:b0:19c:bcb1:d8c3 with SMTP id o24-20020a170902779800b0019cbcb1d8c3mr12668737pll.54.1678203169556; Tue, 07 Mar 2023 07:32:49 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:2023:7dda:98bb:96dd]) by smtp.gmail.com with ESMTPSA id jy16-20020a17090342d000b0019719f752c5sm8586843plb.59.2023.03.07.07.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 07:32:49 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Greg Kroah-Hartman Cc: Jiri Slaby , Bartosz Golaszewski , Daniel Thompson , linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, Konrad Dybcio , Douglas Anderson , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] serial: uart_poll_init() should power on the UART Date: Tue, 7 Mar 2023 07:32:12 -0800 Message-Id: <20230307073155.2.I106c39498d8094c6f5e7ada42c7db17aa5c64e48@changeid> X-Mailer: git-send-email 2.40.0.rc0.216.gc4246ad0f0-goog In-Reply-To: <20230307073155.1.Iaab0159b8d268060a0e131ebb27125af4750ef99@changeid> References: <20230307073155.1.Iaab0159b8d268060a0e131ebb27125af4750ef99@changeid> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759724859144812147?= X-GMAIL-MSGID: =?utf-8?q?1759724859144812147?= On Qualcomm devices which use the "geni" serial driver, kdb/kgdb won't be very happy if you use it but the resources of the port haven't been powered on. Today kdb/kgdb rely on someone else powering the port on. This could be the normal kernel console or an agetty running. Let's fix this to explicitly power things on when setting up a polling driver. Signed-off-by: Douglas Anderson --- drivers/tty/serial/serial_core.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 2bd32c8ece39..b14b5ed6fff4 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -2593,6 +2593,7 @@ static int uart_poll_init(struct tty_driver *driver, int line, char *options) { struct uart_driver *drv = driver->driver_state; struct uart_state *state = drv->state + line; + enum uart_pm_state pm_state; struct tty_port *tport; struct uart_port *port; int baud = 9600; @@ -2610,6 +2611,9 @@ static int uart_poll_init(struct tty_driver *driver, int line, char *options) goto out; } + pm_state = state->pm_state; + uart_change_pm(state, UART_PM_STATE_ON); + if (port->ops->poll_init) { /* * We don't set initialized as we only initialized the hw, @@ -2626,6 +2630,8 @@ static int uart_poll_init(struct tty_driver *driver, int line, char *options) console_list_unlock(); } out: + if (ret) + uart_change_pm(state, pm_state); mutex_unlock(&tport->mutex); return ret; }