From patchwork Mon Mar 6 19:55:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65098 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2049707wrd; Mon, 6 Mar 2023 12:11:54 -0800 (PST) X-Google-Smtp-Source: AK7set/Ux+6gEO1fCR613VnUFxOsSs/OmsSjFMnTymESMzzCqj/m75Yrfv01Po1RGiOWaIS8fto2 X-Received: by 2002:a17:906:b007:b0:8aa:c038:974c with SMTP id v7-20020a170906b00700b008aac038974cmr11458902ejy.54.1678133513915; Mon, 06 Mar 2023 12:11:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133513; cv=none; d=google.com; s=arc-20160816; b=UZoyvLY4Xq8czlWcsToKyvotOn3Rlbu2zDkEIGG7tXwHekjvCGdANmir5ntUMouKIf XWoSRMj3kFSEwOlJ7ssLcbkuqhDYEpNmKfz4DQmsAqo7jJTVr3O1Ejko3qxPFGHWIKKN zBpWNzd6g9ChKoanaJ3StBpaJt+QtMNHhU7Toh+k5x5UdXvrzudgFHHVih3ZF2/7KawM AILMrpr9QvhQu8UK7tx2CbRPF+CjOQLEY0Sz7KHa0hsE7k7FdqNzyFOL9+4udg1i/aNS wrrc80ekn4o4vRC+qohUa0wwJEETIsO1lEpX6BO2tW62QxjzkCXx13Zg3129fYu+XxIK JUEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+po55Fpho6SfKTHiIqp5YKPGyjpda/u+CJ46KtMzcWI=; b=aK2NNZMd8RlWZHzp19NUtKcCU6tfMbK2VXE/X6xUYpsPJRD6LRGpDxNXTb49NPh1Y6 N7QtnFV1R0Zmu/qNeR+HFOOd32/QwP/Iu1/ZgNa8IC52BhzEofpgWLRQPgPU0KAttODU +7j55+dJp+sRvRLzcY3jphirUfj0FQVN5W6NAvrsqyEMQt3Iaes91sPz9yqKiJZH9hLf f2dLXjOfkeFE9lgcyj2q24xD3OraiAo5krcqZdrxP90VxYMAGHRGn+jTIHj2fJxDEcGk RWMcGeEdGyZ43hpzA0CQtT7xbe0tpHfftHsJHGk4G6NFa5zRFkml9JEMMryXC8faUrqL LlDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ih5XHDYM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p12-20020a17090653cc00b008b17bca9226si10613687ejo.312.2023.03.06.12.11.29; Mon, 06 Mar 2023 12:11:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ih5XHDYM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230298AbjCFT4h (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbjCFT4Q (ORCPT ); Mon, 6 Mar 2023 14:56:16 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C8D7664C7; Mon, 6 Mar 2023 11:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132552; x=1709668552; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z9mXunzTxFtyQxWYx0D3ZdzQzJ0LQXRYVBzePKOyr2Y=; b=Ih5XHDYMjtD0cz0TMSQiXyHKSDKfnufpV//bJv0nhLgh5Wbn6VNAkcXw bpYN+QoLmOa9H7/Lm0940umiZUNAJZIwFQaJ2HcreJpdGOzM5fFaYOHem xiV8QTV28OLCjWT14GoTtXIx4bd4TdYV7Sg7/86jtGwC4CWWa8NCDiwbz 3MAGB+5ke+hfAaTIchNwV/1+nfWWu08UXf9sxQpWekfdAfnQliH+Ohy+R 6I4g1VUZ4hqLFOk69zK60pfoUz11VVNM32ZIvrk5DENmn9wNxUYOWAB1x 2r7bC38Wq2lUyO+R1d64CHuzasZKvhYqHGi6LJ+vXOXjhZBvPIvCRV/68 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129039" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129039" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185205" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185205" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:36 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id EDC5787; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 16/16] gpio: xra1403: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:56 +0200 Message-Id: <20230306195556.55475-17-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650527703709449?= X-GMAIL-MSGID: =?utf-8?q?1759650527703709449?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-xra1403.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c index 49c878cfd5c6..bc17beaba9e7 100644 --- a/drivers/gpio/gpio-xra1403.c +++ b/drivers/gpio/gpio-xra1403.c @@ -15,6 +15,7 @@ #include #include #include +#include /* XRA1403 registers */ #define XRA_GSR 0x00 /* GPIO State */ @@ -140,8 +141,8 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip) for_each_requested_gpio(chip, i, label) { seq_printf(s, " gpio-%-3d (%-12s) %s %s\n", chip->base + i, label, - (gcr & BIT(i)) ? "in" : "out", - (gsr & BIT(i)) ? "hi" : "lo"); + str_in_out(gcr & BIT(i)), + str_hi_lo(gsr & BIT(i))); } } #else