From patchwork Mon Mar 6 19:55:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65101 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050360wrd; Mon, 6 Mar 2023 12:13:20 -0800 (PST) X-Google-Smtp-Source: AK7set/rWct0oCcl71I4LRHu06VeKeXAglQH9bjxZABm7oX2+H7170fSCjn2vPPzqfQSwPocAZeQ X-Received: by 2002:aa7:d952:0:b0:4aa:a280:55b5 with SMTP id l18-20020aa7d952000000b004aaa28055b5mr11508242eds.20.1678133600208; Mon, 06 Mar 2023 12:13:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133600; cv=none; d=google.com; s=arc-20160816; b=aWJUv8HRliybElNu3iaDyP/wID0h9p/RgljZSmW0BhIz35NWToZ5kAiu5UAnIFj/FB /bFlh6qk+P5VTQiVXbmlgBKEKWiqBYqmeq59BnDbCkUGgtYKzGrHIO2zdjSLg6CrAgCQ JGbrhuvbZlSJWoIUxuXvDcQpBfoteRdWOrmIkMIgg4fNBcn1HL7Wz8qvc6v5mr+sZJg1 QEcpr374wNZ4ZRvGKLlQW3rXYZTpxkPUc0D6M0zxWWcMFZnlFa/MYgRTj8OMOroKh0Pb 1rUua7JCHZGtDtNxinfuc608gQdC9SsVOcIPCHRty1DSVYWcO5QtnFZYM/kdBZ5aDpLT cw3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=c+nUD+jN/oPKzjhb+GBp6UDwk/GwQiRVP7QziDWpjLo=; b=pW7a9eQBoHwPqayM9JCLt78LGLgR009ie/DLQ3U+5G4mcHvdbwUobvc7YMgNLrh2ue JFUKDOVdZDKBvaba4weadkJrrHQChlWc9asvKNSSu0DjKIWnc/BtK+6GqojUPa00iJId 8le8886IHXjWQEuHoB0L4y0/AhablZJrfYzQ1S3RHDokyGQ2jFoXUB7eVf841ri3JrfO wrLHvc11qKMcH9urn5Tderu8rnO98SrXXqXvbJpg+HWgL7nfpehkA7wQHanyKdcRGVUf vlKFpttcOFYF/k8Co9AAUOiaCDhaIAtygYJVBD9J7tx84BC+GqkyOr8ML+tJJxy0lwYo 7Jhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mlDz2Wr4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020aa7d450000000b004ad02c77d40si9050018edr.29.2023.03.06.12.12.56; Mon, 06 Mar 2023 12:13:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mlDz2Wr4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbjCFT4q (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbjCFT43 (ORCPT ); Mon, 6 Mar 2023 14:56:29 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71247C9E4; Mon, 6 Mar 2023 11:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132554; x=1709668554; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RK6y2QSRrHDRA5pznFKjVWh2L43LhEIXd/tLzjqoka0=; b=mlDz2Wr48JwU8k7+WTZtzMU/7jeuhVJXqN8wTq6TMP0Wlai2U/pnpw3l CO8OEf2q2V4QQSYXiUMzd/CMW4M3WwGbP6eZ/9n5nJnxWWsH+QGt90kQS opUTUaF7Y3HPDM07L+DGfeM7Qlv0k6PJKMR6nWlXIxDn9fMxQNGGnXhyD NlkBm6wmrultP5UplLPIA1ymTJpoOmavca2ejKBSidk7Y7QeTZEhUx+Yk wYxT2Rr4yuE5c9406WGvJX6JSaRy0XLLCf3UpSLLbj+RhZbZYaNQet5rE 2vsbrhrxcrk//aaZ/ZslRrIFk7Z/eSjyTvPpZEGDB2Vve+CoXUJg5pMUR Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129051" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129051" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185204" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185204" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:36 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E54AF65A; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 15/16] gpio: wm8994: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:55 +0200 Message-Id: <20230306195556.55475-16-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650617610452902?= X-GMAIL-MSGID: =?utf-8?q?1759650617610452902?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko Acked-by: Charles Keepax --- drivers/gpio/gpio-wm8994.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c index f4a474cef32d..15757d94448a 100644 --- a/drivers/gpio/gpio-wm8994.c +++ b/drivers/gpio/gpio-wm8994.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include @@ -215,10 +216,7 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) continue; } - if (reg & WM8994_GPN_DIR) - seq_printf(s, "in "); - else - seq_printf(s, "out "); + seq_printf(s, "%s ", str_in_out(reg & WM8994_GPN_DIR)); if (reg & WM8994_GPN_PU) seq_printf(s, "pull up ");