From patchwork Mon Mar 6 19:55:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65105 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050726wrd; Mon, 6 Mar 2023 12:14:10 -0800 (PST) X-Google-Smtp-Source: AK7set91wFxVrDftkXIGhcgKN4GdVOb2XsPJpbGgaGSwrbEfcQQRgKe4c+7zVLqWXdXpo2vTotgm X-Received: by 2002:aa7:c489:0:b0:4af:6409:30ea with SMTP id m9-20020aa7c489000000b004af640930eamr12453049edq.19.1678133650610; Mon, 06 Mar 2023 12:14:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133650; cv=none; d=google.com; s=arc-20160816; b=utKl4yLbCQdabXM7GxdGMcC3ZeuuIOWc1uVUr2TmZ5E31WbEHx+cqw20IdsPN1f6Qz fFdzwjV2SBe33vDL9JGMne1QZT4+TAqrLg0FvAQDOzlLUMShtggfaaToBzWcYV+4iJzA MzohAKyilHO6EBoYIOnz4dHiPn31flIFu7063RK3GU+iX+klq+8oAPHYsP8/0PfRj06n 9CLW2B0ljTcC0YQreVzRIcgJXCNE77SQxOytWWIejs81NOQuy72P4RoBti8TCgYXk0sw WQwRNRbUVi17H9AuxWyZSrpN4i1pmde05bsJIsoDRfuXcPa0reNk77IFjdw9NqGn8ksJ Ba3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8loi2Q20TT7JrkUUaL0WE77eVEwuIMbTOXN79ShyZFQ=; b=e+XbsD6OQBjt7AyKi+cjLtM7IlfFvrUOe/fR9ghsqq9iTl0GNUXoS+uw4luCsMpMop 4tVRjjio3WrvDfcf6uJ/jShKS7wN5ENG9XODudtEbJWm6BuZV9s46Jwf+A/JkTmFscsP 1/JMuvzoD2Rs3d8VehtsUhbP3XH2NVzbIZV2NYrY0QrdLth3WEDPiCzbJUp0khIBtyI2 HuI5QL3Os6kAb73OoJLMAf7jRAErqxwzSABonuVMDgkXa0xlyZOuIpSsDPa8ACLJ2CZ3 scAGs63jep5I0PZLu2nlLRGNWNWLeUvAj9BQ1PiwP8VOCfBZz0Wafnix3qU3o+tCsLws q4Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FwAUEpaS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m11-20020aa7d34b000000b004bc8b19b76csi792065edr.188.2023.03.06.12.13.46; Mon, 06 Mar 2023 12:14:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FwAUEpaS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230363AbjCFT4T (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230227AbjCFTzv (ORCPT ); Mon, 6 Mar 2023 14:55:51 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 730AE7585A; Mon, 6 Mar 2023 11:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132545; x=1709668545; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5nB1Cjf4Z6soJzkyRCy4W4jPVtCrh+QSwebJoZzzTHU=; b=FwAUEpaSGExn5eC9NtNZP3rmPDDCbVPRnA04unX4cNxt6BF+5RgMmS/z aiVpd8KAoipbYjLJik9KfdN3CmOVc1jYc5ImuP5Fk678lXXam+r4WWEAX 7TKec04RhLFu2TAdzhjKoegcM/iwGCDDeuH1UsraB2E+jzp38k5DZY+oL MLOL31JGoUgrUoL6vlenYMUddU8eWDPmOhB7vo8ncU/lhJ8rIT+CKFWVL iKpXoDUA0T8hFBWKwjjk/3+i1qRD+lu69DdEqvFf2y+qnO1BUR/aTrayO 1lDU/6dgau1OcfrDFpwgDm38tX0QjH76sP+79YdqYmztuPj6aVgPSzgJ8 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129031" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129031" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185197" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185197" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id D96A063E; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 14/16] gpio: wm831x: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:54 +0200 Message-Id: <20230306195556.55475-15-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650670944328413?= X-GMAIL-MSGID: =?utf-8?q?1759650670944328413?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko Acked-by: Charles Keepax --- drivers/gpio/gpio-wm831x.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c index 7eaf8a28638c..5456485ce801 100644 --- a/drivers/gpio/gpio-wm831x.c +++ b/drivers/gpio/gpio-wm831x.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -229,8 +230,8 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) seq_printf(s, " %s %s %s %s%s\n" " %s%s (0x%4x)\n", - reg & WM831X_GPN_DIR ? "in" : "out", - wm831x_gpio_get(chip, i) ? "high" : "low", + str_in_out(reg & WM831X_GPN_DIR), + str_high_low(wm831x_gpio_get(chip, i)), pull, powerdomain, reg & WM831X_GPN_POL ? "" : " inverted",