From patchwork Mon Mar 6 19:55:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 65099 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2050106wrd; Mon, 6 Mar 2023 12:12:49 -0800 (PST) X-Google-Smtp-Source: AK7set++KWX0KNsKLbY2/MO3uayAv/UYDB+CG9McQIrwd0IbYRGWfJEaB2MMCKIH0+5n+1Ko/1Jn X-Received: by 2002:a17:906:5dcb:b0:8b1:7eb7:d53d with SMTP id p11-20020a1709065dcb00b008b17eb7d53dmr13490517ejv.49.1678133569220; Mon, 06 Mar 2023 12:12:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678133569; cv=none; d=google.com; s=arc-20160816; b=nPCJJE/WA/xfWrtLfKbdMjmOj20RzNXsDT2V0tFGgLMvLr2fyx4WZEUysBcj9TqnOx 5250suCjQec0nWOyeX/vbtsbET6klt+qCJxNZ4StlS4jdrViYby8Ma3IqWb0RpgvF0D0 qRXtPTBPEiOoRR2NvS8Y/nklQm62gDGwwbn4GgEy/kEzYOpxtYu9ZmZZb+7WKqwo5BEk XH1a5doZYY+C/HmgSREBAAepG/A60nxK0x+ruKxoX9mKz414Fuo0cG65JuSX2Sv4lhsi MEh4CffWyupPVcEamzy6HFFm9TH8+KRUdhUrJ8J0wGats8hMQjyf8eKF09izHCHD9A8l daLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ejVRKYAtBl21io7tyklIQUu1u+uj2dqWxxjN2JJ74yE=; b=G+Bi41mR4C6uXserRG2CvNYntlEULJFxuCn1iGx8I/VuhHEOKC0yAvM7Xjx0hCsZc2 TNmVIMyaYP7uLHyqApfyj/oLpJ6wd1T3MlVMRqhaTw+18HJWTvo6rf/Qs7xz8A55F3Q9 y4ABrZOpaR82h45qAhKsOO2BkRy1VdgCvSf/HtCSQ3J++YBGt5wrbm8Q97xT7lkg+H+m 46+tUJGMIwrkqwfvjwYMdLMPXA39eXP07CuCTAog1zM7UIShdlbPs/CZLxVeGEtudWmb JG6eirCyQSaPdCbgqxJeaZX5B8Gu0pQOmTM/yfkg6H5qmzUCgnVdN5B/RIDeafCldwIr nAuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k3CVGC5x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h16-20020a170906829000b008cc17a6e394si10373932ejx.779.2023.03.06.12.12.25; Mon, 06 Mar 2023 12:12:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k3CVGC5x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbjCFT4e (ORCPT + 99 others); Mon, 6 Mar 2023 14:56:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbjCFT4P (ORCPT ); Mon, 6 Mar 2023 14:56:15 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4D1874A61; Mon, 6 Mar 2023 11:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678132550; x=1709668550; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jf/vTVPAzC30zKR0ZUsN6jr/4cQFfkw43STBYea8M0I=; b=k3CVGC5xyALFHyqjoLIKUI5rjXyvajzGt757PmOi2FvcyaYlrfr/YSMS 2PXTsLn05NprAm3X35oYjDVhGiyqFNOjwlF6D41EbrOf+8PUBkk5/x6C5 FgjFiCD+94x40oTuXiXOMXBLfu+iUTt0/uOE/JL2Ugh3ljhAoEjskStx9 qVeX1iUHL86fmHZJI7gkUkcSJyzCcpQBLo0iSpCwCZzgBLg5Iszlz0Yky mcD2icMW2voY1vCPNeEil1CsnzR7ZnsWWLiqVjq8oiAzttT6Eg+PUGxlF NSjKd9DlB6mtMTwBTDiRSDW3NOmAJ1ywkZ75J2Rf2e4mK1d7qksiuonsw A==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333129033" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333129033" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 11:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="745185196" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="745185196" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2023 11:55:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id B81905B3; Mon, 6 Mar 2023 21:56:12 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Schspa Shi , Marc Zyngier , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com Cc: Linus Walleij , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andy Shevchenko , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Maxime Coquelin , Alexandre Torgue , Kuppuswamy Sathyanarayanan , Nandor Han , Semi Malinen Subject: [PATCH v1 11/16] gpio: pl061: Utilize helpers from string_choices.h Date: Mon, 6 Mar 2023 21:55:51 +0200 Message-Id: <20230306195556.55475-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> References: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759650585315686537?= X-GMAIL-MSGID: =?utf-8?q?1759650585315686537?= There are a few helpers available to convert a boolean variable to the dedicated string literals depending on the application. Use them in the driver. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-pl061.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 9fc1f3dd4190..99e71b4490a1 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -25,6 +25,7 @@ #include #include #include +#include #define GPIODIR 0x400 #define GPIOIS 0x404 @@ -165,8 +166,7 @@ static int pl061_irq_type(struct irq_data *d, unsigned trigger) gpioiev &= ~bit; irq_set_handler_locked(d, handle_level_irq); dev_dbg(gc->parent, "line %d: IRQ on %s level\n", - offset, - polarity ? "HIGH" : "LOW"); + offset, str_high_low(polarity)); } else if ((trigger & IRQ_TYPE_EDGE_BOTH) == IRQ_TYPE_EDGE_BOTH) { /* Disable level detection */ gpiois &= ~bit;