From patchwork Mon Mar 6 17:27:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ondrej Zary X-Patchwork-Id: 65056 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2015096wrd; Mon, 6 Mar 2023 10:54:59 -0800 (PST) X-Google-Smtp-Source: AK7set/MJJ6Jvv5lVTJ6rEGqqZwJ9N1JtawPjlKL2b0TR33R1RWK8zkndu2nARBGNtUULWLywUNQ X-Received: by 2002:a17:906:bcda:b0:8a4:e0a2:e77f with SMTP id lw26-20020a170906bcda00b008a4e0a2e77fmr12660350ejb.34.1678128899166; Mon, 06 Mar 2023 10:54:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678128899; cv=none; d=google.com; s=arc-20160816; b=Cv7wUnsuZDv73S+zpOlolIEux2MGVZqtB5yqdOu4ASknpPcMZT2ZHGlRIkIPki6uxQ tJTjUuRc8rcbEp8U8/q4R1IbKHa+eXNRqLjONmiLLU+5GiNWDo3cTajy7XkqSHzMDx1H lrQaV/uJwYwfOyLZ6cCEYcwkq0LTIw1dZKo+cwtISzH4biJBMVIUHVTIVTaNOZru30vW 3bctk8u0RpFsvQt6FVrM4asVntGTb0jl1+ZZ6RGqRFivmxotzgIDjSM0AQJjU9lBxCNb Fukxvp/koPdwZis+Qt0xEmsBVfI8wppHOuEEndaM+JlRGt8L0O2Gw7kxj/R3WRJunlZ5 7eVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zSZBNY6cygH1vui0n1WEwiOURezUZ2ESUYmLcjXfdYc=; b=Bix5OC06G1QZ6jlWNKRyjuAaIR7Jd7ZLrEEjkRgFE688bp+BI1BgvtXp4/PtZPqiY7 cbr3qkswfq9off5IVdctBJCtDpOPiR7dcdYhgE7t2FsnKQprrPJcf+l+uNSSOpCENkDr /t5Uka99W47IqTCqPP/PnbM6268kJ/w2qyo6xYRhl2sy/83QyDvewUBUjq+Zjctp5hkc PEPgZevSAA4fB3tLcdHRLPwnoWKJZhyd7pu+WFAizMQUwDkQl9gqn0/9LT5EOdgnp7PI yAeU+R3sLOvniPceDJJuJxDaE+GEI0KjQIayEkKQmkXNcJ7bUAmVO6tPWVnhHDNEsE6W MDTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k9-20020a170906158900b008c8165f7c25si6536844ejd.951.2023.03.06.10.54.35; Mon, 06 Mar 2023 10:54:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbjCFSY0 (ORCPT + 99 others); Mon, 6 Mar 2023 13:24:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbjCFSYR (ORCPT ); Mon, 6 Mar 2023 13:24:17 -0500 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 96A0E497DA; Mon, 6 Mar 2023 10:23:59 -0800 (PST) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 8840E7A0708; Mon, 6 Mar 2023 18:28:29 +0100 (CET) From: Ondrej Zary To: Damien Le Moal Cc: Christoph Hellwig , Sergey Shtylyov , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/18] pata_parport: use print_hex_* Date: Mon, 6 Mar 2023 18:27:46 +0100 Message-Id: <20230306172752.7727-13-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230306172752.7727-1-linux@zary.sk> References: <20230306172752.7727-1-linux@zary.sk> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759645688763782172?= X-GMAIL-MSGID: =?utf-8?q?1759645688763782172?= Use print_hex_* for debug dumps. Reviewed-by: Sergey Shtylyov Signed-off-by: Ondrej Zary --- drivers/ata/pata_parport/bpck.c | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c index 1cba098b4b82..dec24983d140 100644 --- a/drivers/ata/pata_parport/bpck.c +++ b/drivers/ata/pata_parport/bpck.c @@ -334,12 +334,9 @@ static int bpck_test_proto(struct pi_adapter *pi, char *scratch, int verbose) } - if (verbose) { - printk("bpck: 0x%x unit %d mode %d: ", - pi->port, pi->unit, pi->mode); - for (i=0;idev, "bpck: 0x%x unit %d mode %d: ", + pi->port, pi->unit, pi->mode); + print_hex_dump_debug("bpck: ", DUMP_PREFIX_NONE, TEST_LEN, 1, buf, TEST_LEN, false); e = 0; for (i=0;i '~')) - scratch[i] = '.'; - printk("bpck EEPROM: %64.64s\n", scratch); - printk(" %64.64s\n", &scratch[64]); -#endif - + print_hex_dump_bytes("bpck EEPROM: ", DUMP_PREFIX_NONE, scratch, 128); dev_info(&pi->dev, "bpck %s, backpack %8.8s unit %d", BPCK_VERSION, &scratch[110], pi->unit); dev_info(&pi->dev, " at 0x%x, mode %d (%s), delay %d\n", pi->port,