Message ID | 20230306162751.163369-1-francesco@dolcini.it |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1943633wrd; Mon, 6 Mar 2023 08:40:24 -0800 (PST) X-Google-Smtp-Source: AK7set8t3Re9TMVZyRfKRBp7aSKJvPZP4ufDG+TRlD7+FMM/cHxaSge+yzF0FiaE1smOxDy/ZPmN X-Received: by 2002:a05:6a20:431a:b0:cb:77ef:b502 with SMTP id h26-20020a056a20431a00b000cb77efb502mr13114321pzk.5.1678120824121; Mon, 06 Mar 2023 08:40:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678120824; cv=none; d=google.com; s=arc-20160816; b=eRy8u+IVo/59hJsCQ3+RBUjSBXFPoxQG89AVVx1+wZRicYGjhW8CzFMA1VstxH+LT4 pj7xS5ervtL4mV52Ca7oPSBEkU/YzZGo4VCJiHTISs7a2wZfpwBMyKH7DJNkBfc3Tjtc SRWV3jKdN6b1hVm8MJrH/3IcHGzQpTxn57MlzNVulc6+tkZf/I/ot9Ghy/fzfdX79NIW J5Rcq2cIym0+u46JUtPzJJVxv3+Jey9NP2qlejSTggmsQtg/KW5b2XwUCRn0HQLhW1zP qdxuQubK5c7cT8dgAXtrZd/fibBRdsbcAgfgKp8Frl1OLMCZlBzbuL6Vo1lf/Jg3sYYZ gdTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FBwzz+f6v4Dn4pGZPgKMhcbz4zUhegRXEH/C7X6hDPE=; b=jYO25cdUGM7gq8tSecTbS6P3coxdt7DMQWtFpR+xP/68pdAtgSMeevFAV735qDGCpe toPaHYpOtXfTWMEObgtVMleLPvZvdAtb5AOCrSVu5IedgDztJ6aJGzij95PHSTtFQ2+Y rzVD7FEynqOrnWF0mg6nyeJ/y4CtqYLC3+97RVn3Kd+zW30c2FArl7XbSGZYfXLnZwL1 H0EcfFaUCIsdmRAN8pAotlR3I7NgByAdMv7sIpOLyL75bbyeMhzlGUKzW0vAcjiAQkc+ Zb0U3ybHVBMLw6Os/2TRew8d4Hqomiu9V8AOUaPoo5nJn5TayaxEgm75op4JDdHoGM1q SuPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s6-20020a634506000000b004fbd4ae5651si9839265pga.170.2023.03.06.08.40.11; Mon, 06 Mar 2023 08:40:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbjCFQhV (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Mon, 6 Mar 2023 11:37:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230140AbjCFQgi (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 6 Mar 2023 11:36:38 -0500 X-Greylist: delayed 413 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 06 Mar 2023 08:36:11 PST Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B608938675; Mon, 6 Mar 2023 08:36:11 -0800 (PST) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 9256021E38; Mon, 6 Mar 2023 17:27:56 +0100 (CET) From: Francesco Dolcini <francesco@dolcini.it> To: Ulf Hansson <ulf.hansson@linaro.org>, linux-mmc@vger.kernel.org Cc: Francesco Dolcini <francesco.dolcini@toradex.com>, linux-kernel@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>, Faiz Abbas <faiz_abbas@ti.com> Subject: [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity Date: Mon, 6 Mar 2023 17:27:51 +0100 Message-Id: <20230306162751.163369-1-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759637221148425768?= X-GMAIL-MSGID: =?utf-8?q?1759637221148425768?= |
Series |
[v1] mmc: sdhci_am654: lower power-on failed message severity
|
|
Commit Message
Francesco Dolcini
March 6, 2023, 4:27 p.m. UTC
From: Francesco Dolcini <francesco.dolcini@toradex.com> Lower the power-on failed message severity from warn to info when the controller does not power-up. It's normal to have this situation when the SD card slot is empty, therefore we should not warn the user about it. Fixes: 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect debounce timer") Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> --- drivers/mmc/host/sdhci_am654.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 6/03/23 18:27, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Lower the power-on failed message severity from warn to info when the > controller does not power-up. It's normal to have this situation when > the SD card slot is empty, therefore we should not warn the user about > it. > > Fixes: 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect debounce timer") > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci_am654.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c > index 7ef828942df3..89953093e20c 100644 > --- a/drivers/mmc/host/sdhci_am654.c > +++ b/drivers/mmc/host/sdhci_am654.c > @@ -369,7 +369,7 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg) > MAX_POWER_ON_TIMEOUT, false, host, val, > reg); > if (ret) > - dev_warn(mmc_dev(host->mmc), "Power on failed\n"); > + dev_info(mmc_dev(host->mmc), "Power on failed\n"); > } > } >
On Mon, 6 Mar 2023 at 17:27, Francesco Dolcini <francesco@dolcini.it> wrote: > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Lower the power-on failed message severity from warn to info when the > controller does not power-up. It's normal to have this situation when > the SD card slot is empty, therefore we should not warn the user about > it. > > Fixes: 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect debounce timer") > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> Applied for fixes and by adding a stable tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci_am654.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c > index 7ef828942df3..89953093e20c 100644 > --- a/drivers/mmc/host/sdhci_am654.c > +++ b/drivers/mmc/host/sdhci_am654.c > @@ -369,7 +369,7 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg) > MAX_POWER_ON_TIMEOUT, false, host, val, > reg); > if (ret) > - dev_warn(mmc_dev(host->mmc), "Power on failed\n"); > + dev_info(mmc_dev(host->mmc), "Power on failed\n"); > } > } > > -- > 2.25.1 >
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index 7ef828942df3..89953093e20c 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -369,7 +369,7 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg) MAX_POWER_ON_TIMEOUT, false, host, val, reg); if (ret) - dev_warn(mmc_dev(host->mmc), "Power on failed\n"); + dev_info(mmc_dev(host->mmc), "Power on failed\n"); } }