From patchwork Mon Mar 6 16:00:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 64929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1942366wrd; Mon, 6 Mar 2023 08:37:54 -0800 (PST) X-Google-Smtp-Source: AK7set/Kt1TSEhpHGW1Wtb3nM5uslpmZnZoupIHLlrCr672RRsvhZuBxVJho/heP5V1aHRdGFwtf X-Received: by 2002:a17:90a:e7c3:b0:237:d867:222c with SMTP id kb3-20020a17090ae7c300b00237d867222cmr11982941pjb.42.1678120674677; Mon, 06 Mar 2023 08:37:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678120674; cv=none; d=google.com; s=arc-20160816; b=SemTuET5QlMzPYsyXIqKX5U3oKmBoSvClQ18iR7FK3T3oAPgIb5z1v+9ESm1D4sjn6 mO0/LUQY5jp9w0T3MqvTPEUAfH9oama/4VwWbi8Dfdjs96vLuh5j1gOu+W05PFsnVjBb VcVzezd2KwEI3vt7km2hIeMrBN6Kas+fMgjJG7bwERePzsGwoZqbFsYatyVnkIXhL4ce iuIRkaNCQ190Prm8tVf7q0C0F4b/mJJZ1Dmez8skkwQVZB2jpF6bTlyfVZqx6e1M+O5T hYvsYr8nU3KsCyNiJAtHUqpH0OT45hQ1l47enJBLfedcvkG0r0thuUEOj/L3tQJY5XjJ J3/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=9jPw1gekX+dS3alKpIhYWuod0yFkaKVmgthd+u+9Q3I=; b=lUhFTsAjHn5vkheNtEEm+ELTbHXkvd2k2eBLgI2QTaC4DI/wmsvspxDmwjWQ0cP7ix 4OGNcs5CJ/pK/ikGPvzD1nnZzf/fNQrYhHY8z4txgjneC93aGrE4fRnSi23s4mGZmObQ vgmedWnWgnM04h92xU5I17gOlI5k1rTbGE98cMCDvUXIYFXn+SHOI+2s4amrNKwssR73 F6uXxs44ssBj7kw8BfDL24ui6NigxMnwA31NUutLgwOo+XsNJ0Iss80tlPWLSaaNpnTd p74Kyv3DYtBR2FxgU7GMOs+mlxda2Cx1xxbqlddF8g4rBqdxjKn35X6450EHOopoXNlE 6zpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=BZCIBnjT; dkim=neutral (no key) header.i=@suse.de header.b=Xj87SiI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y186-20020a638ac3000000b004fc1e4751dbsi9457449pgd.867.2023.03.06.08.37.42; Mon, 06 Mar 2023 08:37:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=BZCIBnjT; dkim=neutral (no key) header.i=@suse.de header.b=Xj87SiI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231659AbjCFQG5 (ORCPT + 99 others); Mon, 6 Mar 2023 11:06:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbjCFQBK (ORCPT ); Mon, 6 Mar 2023 11:01:10 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 926702E0D3; Mon, 6 Mar 2023 08:01:03 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3427B2245B; Mon, 6 Mar 2023 16:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678118462; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9jPw1gekX+dS3alKpIhYWuod0yFkaKVmgthd+u+9Q3I=; b=BZCIBnjT4VG2watd8QiYGZnfT3gnTX0oWbbZ/wo0QDvu1fLYkpFx8+kzl197N8PW9XiMgK dK8wIAlA4l5TYEOwT3EpDASIhkF5Ain2/FyssDJ9BvNyQDHPqWHxxabnciQI9Fc0rDeOnm HRLN5ZIRHvdY51yTQDrtWsM6emHsZAI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678118462; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9jPw1gekX+dS3alKpIhYWuod0yFkaKVmgthd+u+9Q3I=; b=Xj87SiI0F2lYajydSZ9VDJqbuHcFCbMfqbg59Q1PzPiAgepDEYeJTtbYJQUfEIF9IdLmBR wyl+8GbplWzpOLDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BF9B813513; Mon, 6 Mar 2023 16:01:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2EfpLT0OBmQ/PwAAMHmgww (envelope-from ); Mon, 06 Mar 2023 16:01:01 +0000 From: Thomas Zimmermann To: deller@gmx.de, paulus@samba.org, benh@kernel.crashing.org, linux@armlinux.org.uk, pjones@redhat.com, timur@kernel.org, adaplas@gmail.com, s.hauer@pengutronix.de, shawnguo@kernel.org, mbroemme@libmpq.org, thomas@winischhofer.net, James.Bottomley@HansenPartnership.com, spock@gentoo.org, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, geert+renesas@glider.be, corbet@lwn.net Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH 97/99] fbdev/vt8623fb: Duplicate video-mode option string Date: Mon, 6 Mar 2023 17:00:14 +0100 Message-Id: <20230306160016.4459-98-tzimmermann@suse.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230306160016.4459-1-tzimmermann@suse.de> References: <20230306160016.4459-1-tzimmermann@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759637064499317338?= X-GMAIL-MSGID: =?utf-8?q?1759637064499317338?= Assume that the driver does not own the option string or its substrings and hence duplicate the option string for the video mode. The driver only parses the option string once as part of module initialization, so use a static buffer to store the duplicated mode option. Linux automatically frees the memory upon releasing the module. Done in preparation of constifying the option string. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vt8623fb.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/vt8623fb.c b/drivers/video/fbdev/vt8623fb.c index 034333ee6e45..cbdca42d1708 100644 --- a/drivers/video/fbdev/vt8623fb.c +++ b/drivers/video/fbdev/vt8623fb.c @@ -929,8 +929,17 @@ static int __init vt8623fb_init(void) if (fb_get_options("vt8623fb", &option)) return -ENODEV; - if (option && *option) - mode_option = option; + if (option && *option) { + static char mode_option_buf[256]; + int ret; + + ret = snprintf(mode_option_buf, sizeof(mode_option_buf), "%s", option); + if (WARN(ret < 0, "vt8623fb: ignoring invalid option, ret=%d\n", ret)) + break; + if (WARN(ret >= sizeof(mode_option_buf), "vt8623fb: option too long\n")) + break; + mode_option = mode_option_buf; + } #endif pr_debug("vt8623fb: initializing\n");