From patchwork Mon Mar 6 15:10:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Schnelle X-Patchwork-Id: 64805 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1921850wrd; Mon, 6 Mar 2023 08:02:26 -0800 (PST) X-Google-Smtp-Source: AK7set8EaacDOLeNeuuKs9ECcPJM7Fpl7gYJsjCDLTYSGBr++e6GoosA/1Ve6qzvzUavttbG3HnQ X-Received: by 2002:a17:90b:4b41:b0:234:f4a:8985 with SMTP id mi1-20020a17090b4b4100b002340f4a8985mr12249700pjb.15.1678118546317; Mon, 06 Mar 2023 08:02:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678118546; cv=none; d=google.com; s=arc-20160816; b=KY8X1iBflkzD5qrsiIlnLYg/Ci6eNwOybC3mIWiSZ7jfNvW7ONZLiqB4tQYJxnCiZl /7qVnRU1NW6vTEx6mdR5Ki1+5bNeB4oZBNF1raoquWcEdcxrA6jO6gfIQb0lKtuqZC2e AnijvbvEhkTKA370C2o9HweBx8Dd42FlBK9fRnFgi4dm+8X2N7pKzIlgqXkMX/d9F6kC Jo5mUUpI6Qx/NXZ7CHU9Obx/BIW+hBVFvGnH9JLPZ8/nUZwWarc6eon5EmNb6t6rZnvx gqKCRmTVoK6u8M8KD/bJqkJltuUUuxGX2tI/ZTQefqYHdGTN0BnQ91fD4l4xBwL3UFnp PU+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=y/YyNieYbjzn7JIiKHtS24mjVTN20HTpFwwmJykUrWs=; b=tK2CNu+5299SbhKdrIPnB9yJ6EL0HOzP0SULhChiu5Hmzsnd1vtvUiNaKggg/gw9qZ jQacL55yiEq71jow9ZQ+oDFIo5gcK2l0PR4qZMmxC6pA3XH6ibS+IMOuo1XfX1S0ACE3 iJX3/uR2GUZsF6amuVI7QqHRvK2Vh1Eq9eiwFBX7prDVjv4tbgupwhB1oWhlLLr6c/Dj npZbrgWeaTV4AdgBrNstK2YBhsnGI6KMnhVMtl+gXyFDakLVRI7nRWlwTfcoeHCJGmjM GjwUnMi+UdB6AuXT6h2sHa1lZuJ1nPHEyKKlCPY1JIfEoImVOI8m4nKjp1V5PmPJbpRY dR0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=CBH6oSDe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lb1-20020a17090b4a4100b00233efa8d3e5si13846458pjb.20.2023.03.06.08.02.14; Mon, 06 Mar 2023 08:02:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=CBH6oSDe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231350AbjCFPKn (ORCPT + 99 others); Mon, 6 Mar 2023 10:10:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjCFPKc (ORCPT ); Mon, 6 Mar 2023 10:10:32 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC886222DF; Mon, 6 Mar 2023 07:10:23 -0800 (PST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 326F6QxC002064; Mon, 6 Mar 2023 15:10:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=y/YyNieYbjzn7JIiKHtS24mjVTN20HTpFwwmJykUrWs=; b=CBH6oSDeGlYEjD+z7uG/YOtXWimBC1BRahVkv0XN94WCl/KB0GHO9GPulCfXpAkqBRHC owwKun60SYO1mv+rnmurOTUt5ELnD94DWtH02xPZtbkPbVq/bGijFqyPIgIEe+pd+Hw9 jRqByl0CukjrR3EOZ/saMjbrAa4F/n08/Fd7OOcY2Ze2RCHmwLHfIta3EhKnSj7/Sxho +JEvs+GNovl2kNV+nA/Zbwec7SFnOa+1T8ebOW2z8/IpN9uXyBdTh3zfR1Ek12tBB0DC zWM/SXVWYqREQzkIzJtqP6jsnDAvhdn1jT1w4zWlWrZ5ZObgqLpSHk2xgTy8IPekG0Hj cA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3p4yhqypkp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 15:10:22 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 326CafVR030044; Mon, 6 Mar 2023 15:10:21 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3p4yhqypk2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 15:10:21 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3265Q2eb002533; Mon, 6 Mar 2023 15:10:20 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma03fra.de.ibm.com (PPS) with ESMTPS id 3p41c3t9eh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Mar 2023 15:10:19 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 326FAGcK28705388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Mar 2023 15:10:16 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4E2B320043; Mon, 6 Mar 2023 15:10:16 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C4F52004B; Mon, 6 Mar 2023 15:10:16 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Mar 2023 15:10:15 +0000 (GMT) From: Niklas Schnelle To: Bjorn Helgaas , Lukas Wunner Cc: Gerd Bayer , Matthew Rosato , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v2 3/4] s390/pci: remove redundant pci_bus_add_devices() on new bus Date: Mon, 6 Mar 2023 16:10:13 +0100 Message-Id: <20230306151014.60913-4-schnelle@linux.ibm.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230306151014.60913-1-schnelle@linux.ibm.com> References: <20230306151014.60913-1-schnelle@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 8ZV9spihV-45ptrSOt9McaOQtUK-wBnP X-Proofpoint-ORIG-GUID: fKuPVIx_-3WMgfJpQ450_XOGmDBAUlLZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-06_08,2023-03-06_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303060133 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759634832544308757?= X-GMAIL-MSGID: =?utf-8?q?1759634832544308757?= The pci_bus_add_devices() call in zpci_bus_create_pci_bus() is without function since at this point no device could have been added to the freshly created PCI bus. Suggested-by: Bjorn Helgaas Signed-off-by: Niklas Schnelle Reviewed-by: Matthew Rosato --- arch/s390/pci/pci_bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/s390/pci/pci_bus.c b/arch/s390/pci/pci_bus.c index ae46c280b35f..f8778cd2c029 100644 --- a/arch/s390/pci/pci_bus.c +++ b/arch/s390/pci/pci_bus.c @@ -210,7 +210,6 @@ static int zpci_bus_create_pci_bus(struct zpci_bus *zbus, struct zpci_dev *fr, s } zbus->bus = bus; - pci_bus_add_devices(bus); return 0; }