From patchwork Mon Mar 6 11:28:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danila Chernetsov X-Patchwork-Id: 64628 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1812999wrd; Mon, 6 Mar 2023 04:37:11 -0800 (PST) X-Google-Smtp-Source: AK7set88WVLMHkpciFweyPUDa9SNwvlGO8TcnmRNa6pHIByPnF9PaoYXU2Wc3g7z60+hWwJrgbXW X-Received: by 2002:a17:907:9702:b0:82e:a57b:cc9b with SMTP id jg2-20020a170907970200b0082ea57bcc9bmr11011074ejc.24.1678106231776; Mon, 06 Mar 2023 04:37:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678106231; cv=none; d=google.com; s=arc-20160816; b=GM5P9As/z6p7NQAGcfjncTOCGEgdUOZ7pdH2EBW9gveGwWoQa8p+iGT8/Xwvop5/+w Ivp8ahJJBUyjItjwBSrcTFcfNd+XJhNJQhNsGv9txTgJp4MEXPWJiZXS0N4ickFxbcj9 enQ1DStBeg3KeAV59j4wkA3nErls1j7uFy73vaD+jU4cPgrKlken2g4DRcf/WFLKSP0J U4gNuqfqoF6YAxtV79XCr8qF16ETcNvRM9ns5i+RDvk8AWv+t2sQkfoFeXZMKWn04zDd ajLi7EgJl8o1q+QPOrgjuL/IyWQTC6kMg+NMLXbOuPr+9+8O7x3Q4zoo+8GEzCiI/Vf+ uSkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=h4VGDoBsgspJTdXbCO7qW1b7WGjbWxU1wQ/lWinoSAg=; b=n03Pe/KUFKLTLi3Pau1P9qJXXMRojzrmFtlP6wat9p9oCBTWv8qfCf4D5MGZBqF62y GMYuOq9hPLX0LFV/0lv57XnJaPmbvD+fr3DoXG158Ycn4LPaDgY8DRO8EsYgZBuuvY9z VQtpYqwb+FCy/bNucu7dIbV38r6TyWKq7QTWXeGP1E96tIiiDLRkqgzuxswYkpsXAqQO KzSFPrY3+aRiqRih57jg9wtpNPgZgqOs5RPoHnZ3ZDnCWtFapFfSMjxtoKHvxL46Qotu L/JcZwSzKK+jNfX8363tWsdNOxN7WP9IeQzimzXPgUdHWgbk7BNFcT3eHy2dDqeIKRv/ RWRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mail.ru header.s=mail4 header.b=TQt5dH8i; dkim=pass header.i=@mail.ru header.s=mail4 header.b=KDV6nmbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=mail.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e18-20020a17090658d200b008b194cc10acsi12688086ejs.381.2023.03.06.04.36.33; Mon, 06 Mar 2023 04:37:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mail.ru header.s=mail4 header.b=TQt5dH8i; dkim=pass header.i=@mail.ru header.s=mail4 header.b=KDV6nmbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=mail.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229554AbjCFMGW (ORCPT + 99 others); Mon, 6 Mar 2023 07:06:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbjCFMGT (ORCPT ); Mon, 6 Mar 2023 07:06:19 -0500 X-Greylist: delayed 2213 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 06 Mar 2023 04:06:10 PST Received: from fallback18.i.mail.ru (fallback18.i.mail.ru [79.137.243.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2F04206A3 for ; Mon, 6 Mar 2023 04:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail4; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From:From:Subject:Content-Type:Content-Transfer-Encoding:To:Cc; bh=h4VGDoBsgspJTdXbCO7qW1b7WGjbWxU1wQ/lWinoSAg=; t=1678104370;x=1678194370; b=TQt5dH8iNEP+ztSDwEPnjT9VCfgIcSQSbzGCIwavRFUIQ3dJb1e/vBuCNvPNaJKU5D1r5t1v2T9hKPYkzpL89FslynicThDGsjAV+6W0/1ZbGf0d2hvqlsZeEHgcuwBUbyBZjGGV9mInjm4HbYUTa2n+WO2eLn9L9SaLa3CQ8ga6+REdsVPYkfe3kn0banTe3Nhxhq5J+BU1JaXNmmiSqt54pFGRvk084s4kxNbtx2vHk2ZuGqWZ56FVq1IeUePehbxQ9K53Vqcae1v6sB/6x2a4VhMpy9QydGneb7uxIPvmjj4sb3/3Xgu8WZ1OYGcMgTksQphSdzrcCh/pkTLg0g==; Received: from [10.12.4.13] (port=37126 helo=smtp38.i.mail.ru) by fallback18.i.mail.ru with esmtp (envelope-from ) id 1pZ91n-00F3Q2-OQ; Mon, 06 Mar 2023 14:29:15 +0300 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail4; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From:From:Subject:Content-Type:Content-Transfer-Encoding:To:Cc; bh=h4VGDoBsgspJTdXbCO7qW1b7WGjbWxU1wQ/lWinoSAg=; t=1678102155;x=1678192155; b=KDV6nmbexfHzVoxjnMW7ElvGyq0AQcMFwvfCe4UQHfCeHEP+CDlGin33bZjd8S+dJNxLbre9E6pJ9Tu+6m+jip32QTBn5BqFagGZKtO/uY3B6LPQigqyMWTV3/yEiNnfNTfWT/ISgnHlBwfc23IFl5xYn+2bp6jX7lAsWCrelT6q/gwlr88NFQ8dwKYY/9mJHmhJwE2aHiH+3M1UQTMuuWw4WhgkeRcBO03sDjHOJ7kn/TlyASO6K3nw8R4nlQ0WB776TU8mO+DGO1LY//29rfvL+fEJ/ovWRBPMJr5G2VJj3F7MF3rq7fZCrMu0tIKGH8ahMKWH1tECxFaYj4iB5Q==; Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1pZ91c-00FgqB-9M; Mon, 06 Mar 2023 14:29:04 +0300 From: Danila Chernetsov To: Harry Wentland Cc: Danila Chernetsov , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] drm/amd/display: remove an unnecessary NULL check Date: Mon, 6 Mar 2023 11:28:24 +0000 Message-Id: <20230306112824.8049-1-listdansp@mail.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Mailru-Src: smtp X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9BCEC41593EBD8357C44FF2494EBC845BD7AEF656CFC8618A182A05F5380850407AAAB7044E02CB9B414A6F5C01DD568A1464148261DD8DAB87349C382CCD176E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77BF46084C0059042EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CE17C7754E00FC028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B016A246DDE16CE6CE9C66B9EF8B9FEF6F9789CCF6C18C3F8528715B7D10C86878DA827A17800CE7212612128AA291179FA2833FD35BB23D9E625A9149C048EE3F735096452955E3C26CFBAC0749D213D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BD77DF2741F6D7EBCA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCE93681558A2C9BD03AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F790063720748F29B94A53BDD81D268191BDAD3D3666184CF4C3C14F3FC91FA280E0CE3D1A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FE3CA985283E39ABD6D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A549E2961E890F56F30BEA83F3CBBF9969DE678A5BD2C0A5E74EAF44D9B582CE87C8A4C02DF684249C2E763F503762DF505830FD47C92F6C63 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EC58E35A639A24717EF9FFCB2582C4CE9685E1A881FD599AF437D96B6782AAB28FA5DE920320117D1D7E09C32AA3244C03A6BB35BA37848FCB5D409686E6C48C853296C06374E60298DBA7662A2C9987 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojo8yGo04U2e24zAj8bFTDMA== X-Mailru-Sender: 4CE1109FD677D2770147F6A9E21DCA7BAAB1B1B66B3222840ED6C1C441B85F206115718EBCD968C67E3C9C7AF06D9E7B78274A4A9E9E44FD3C3897ABF9FF211DE8284E426C7B2D9A5FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok X-7564579A: 78E4E2B564C1792B X-77F55803: 6242723A09DB00B4BD2EB812D5A6E5F7D3C1BE093F4DBF3EB2D947066E19A99D049FFFDB7839CE9E8A9D5799ED9E1A2444D8461CACA1603EE94E99B57B1F40A8A4D66971C28B3C74 X-7FA49CB5: 0D63561A33F958A59C14BF51AC7C436FBB2F4EF9A83765FF9435D9682D80C156CACD7DF95DA8FC8BD5E8D9A59859A8B6A096F61ED9298604 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5xhPKz0ZEsZ5k6NOOPWz5QAiZSCXKGQRq3/7KxbCLSB2ESzQkaOXqCBFZPLWFrEGlV1shfWe2EVcxl5toh0c/aCGOghz/frdRhzMe95NxDFdAc2jUOxWGfxps9h1Uf8DGQ== X-Mailru-MI: 800 X-Mras: Ok X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759621919600056091?= X-GMAIL-MSGID: =?utf-8?q?1759621919600056091?= The 'pipe' can't be NULL because it points to an element of array. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixed: 7cf2c840c6b5 (drm/amd/display: Commit validation set from state) Signed-off-by: Danila Chernetsov --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 0cb8d1f934d1..d3b850372eb3 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -1854,7 +1854,7 @@ static enum dc_status dc_commit_state_no_check(struct dc *dc, struct dc_state *c for (k = 0; k < MAX_PIPES; k++) { pipe = &context->res_ctx.pipe_ctx[k]; - for (l = 0 ; pipe && l < context->stream_count; l++) { + for (l = 0 ; l < context->stream_count; l++) { if (context->streams[l] && context->streams[l] == pipe->stream && dc->hwss.setup_stereo)