From patchwork Mon Mar 6 10:14:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 64562 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1760435wrd; Mon, 6 Mar 2023 02:24:49 -0800 (PST) X-Google-Smtp-Source: AK7set+N+hNXSmMU0uGQwjxiKLDHXsvyGXsN7TZimm6xh31E8VpniXRY7aOJ2j80jc0co/xbCKXv X-Received: by 2002:a17:906:9f28:b0:8b1:3813:7b6 with SMTP id fy40-20020a1709069f2800b008b1381307b6mr10355764ejc.30.1678098289371; Mon, 06 Mar 2023 02:24:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678098289; cv=none; d=google.com; s=arc-20160816; b=sGhohBanK535D+uEuF2/iSL5UIHd2XP5IlqV0Qwk+9h7vGHfDO1nOsWj46FGtQrzWN g698dyHGGOtL51hqWlE/DpvzT7tHPwxs+8mZuAWdREj1ZkCgQevDYUAxcIHFXBlJVovY UiNQWDgGFseNBeZM0BNlgyl3Zo3MG9rEtynhv3Yztj9o4nnhj67Vs7hBl088AXUCbN/6 CWq8+wP0iVFzs4CcqAfDUcQs4jmhHbxNl8mxJk6zCzvbb7coG2PnjCVcOCegToyH1jyQ bd7G2GD75ftgPUGpM/HINVxMKe3VSYSqR66tXFWaU++0su7d4lj25e3cSxaPEl/HQZ8X n07g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rB7bKokAOFsa5bqaY/OlyPoy312qdrZ5e196c/QkHdc=; b=gAWMt7tto0qXyuMz98iPRO41q3iH3KAE47Ld+dqZIg1Kshr80zhmeyR8de/wCzwkFl K//ECGx033HKHMQHo/ZfnQeBCIyehKdGZK2T1OuhSQxM7zOidCx46gGUPEd8M2wYGJ7w wkynuBRTYGpT37L+5yfB6R9kgQrpTFotTvm7Mc4Aiq2DFE3u56IvYvWoU7Omg3nSFQUv Lk+ntcjNovMdTTMqW7y6oUXMfqxSgh/E1E5aECySye18Suw9nvVwXuT9CGXn8UMpprMN 3RNFyi/y3QrTAsjNOnlgLno8d8mhQnkCz78u7B6zxI4QC+8DRQLYSDwqJDona+ss/QqB 6R6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i2TaLotz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w23-20020a17090633d700b008cbb481fc7asi3940937eja.614.2023.03.06.02.24.26; Mon, 06 Mar 2023 02:24:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i2TaLotz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230409AbjCFKQB (ORCPT + 99 others); Mon, 6 Mar 2023 05:16:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbjCFKPm (ORCPT ); Mon, 6 Mar 2023 05:15:42 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96F467DAB; Mon, 6 Mar 2023 02:15:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32C2F60DBD; Mon, 6 Mar 2023 10:15:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C162EC433AA; Mon, 6 Mar 2023 10:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678097704; bh=gMn8LBo4YTVz4DCKbMOG8G2eyzp1G0ta2S/O8jCHVPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i2TaLotztsUci/exTzbvk9XHqyKP3LCim+/r3AbtTx2DCWDp5H4PHEvbFsyO51sNp p8rbs/qYmr5RYL9B+Ib7kqYO/h5Mqx9tFRPGudGqigweySeDAjAlPpZJWwCap4LYH4 I3U8G6hSaAiYdjG9AVDB6OqjG92pWLcdN/4KS8twDy76XcF5c/6mFfMWtaXuGDPsc2 nAtAdDqt+KeQWlJaqaOg8tdJRLjfl/Mgj+k/0EGB/FfAlitpg0wHx956pRFsg8YuGv igujcesHHxhQad991EbKxKYbpS6I0kcZ1NLo1yhw4Kdrb/yA98gbH9lPjPA8YER5S7 5wJI7DPfOi3Rg== From: Arnd Bergmann To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , Zhen Lei , Boqun Feng , Luis Chamberlain , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH 2/2] kallsyms: expand symbol name into comment for debugging Date: Mon, 6 Mar 2023 11:14:51 +0100 Message-Id: <20230306101451.375844-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230306101451.375844-1-arnd@kernel.org> References: <20230306101451.375844-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759613591651373590?= X-GMAIL-MSGID: =?utf-8?q?1759613591651373590?= From: Arnd Bergmann The assembler output of kallsyms.c is not meant for people to understand, and is generally not helpful when debugging "Inconsistent kallsyms data" warnings. I have previously struggled with these, but found it helpful to list which symbols changed between the first and second pass in the .tmp_vmlinux.kallsyms*.S files. As this file is preprocessed, it's possible to add a C-style multiline comment with the full type/name tuple. Signed-off-by: Arnd Bergmann --- No idea if there is already a better way to debug this kind of problem, or if this causes a notable slowdown. --- scripts/kallsyms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index a239a87e7bec..ea1e3d3aaa6b 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -525,7 +525,8 @@ static void write_src(void) table[i]->addr); exit(EXIT_FAILURE); } - printf("\t.long\t%#x\n", (int)offset); + expand_symbol(table[i]->sym, table[i]->len, buf); + printf("\t.long\t%#x /* %s */\n", (int)offset, buf); } else if (!symbol_absolute(table[i])) { output_address(table[i]->addr); } else {