From patchwork Mon Mar 6 09:09:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 64524 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1738233wrd; Mon, 6 Mar 2023 01:17:55 -0800 (PST) X-Google-Smtp-Source: AK7set9swZpD2NAT5nm40fchGzdQULq8FWls9npn+KjAdMILftLb+PCKW/mow/GLkLcmVcDofunE X-Received: by 2002:a17:907:868b:b0:907:9bda:93b9 with SMTP id qa11-20020a170907868b00b009079bda93b9mr14212453ejc.17.1678094275021; Mon, 06 Mar 2023 01:17:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678094275; cv=none; d=google.com; s=arc-20160816; b=YGDh14jH7cTJQipT0FeIHtxT0/UA0XQEVBlCnjAJPfKi70NSL3/1cH+ePitKaRxMcq gghwGmE6hCkbYn4KQSKeaVT27D+9WMvVwETmSC/Zs6LGMslQmRKhCgcZpMqKbVefW/Bg 4JV/R0BaknqDlgqT69W7gZb5B1d0cfhHnTTbmuKEgN6PuIKNGnyBHTSeejY9dW5FbBrR vM7y+Jvij52X1fkcsqnMPbJ6pj44f6HyDaXvtOhbRdfLICtbngzO3OWuqBAq4sigGOhL CiQNlijcbO0AJKbWtXBpnz8mM483+vPSejJrTbFB0GnIg5ZQ3MDY7cR2/2ZouIV4v3D6 ix7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=lUJOHsj4PiOd3l/SeO2AAyrKLOtgpEvMw7TtwElgb8I=; b=O8BqWee7yOsxXctI2Dt6tIzLgojDsu9ulYR/QmZJowB4pPIi7F6FNOcS9w52zd3C2J mxgSJJ0yI58LMajRH6FPxrTfWx6jnSyHwehQ/rvtxRlpo6gMHuMalwxMt4ahzNrwHxsa Fo65MpI9ODuuvlzev/2+QkasuGaa0OydKMJCg3UcETSst1YD4nPOs9EdrqRnapKksJX7 G0BevR5IwJkMVcUVMHUqF6zpF3QvNOc/KhchyGsoDRg5BE3o/yBRmkxSuma26Y6JlVqz LvBElg5KpMrXYm9mWwm2msRUYLSsjtXSZlouDY62++BWXDcCztE7ISbLbISj26uEh2YQ 64aQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u3-20020aa7d0c3000000b004ab250bcee6si10490927edo.648.2023.03.06.01.17.31; Mon, 06 Mar 2023 01:17:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbjCFJJ5 (ORCPT + 99 others); Mon, 6 Mar 2023 04:09:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbjCFJJo (ORCPT ); Mon, 6 Mar 2023 04:09:44 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E67E1985 for ; Mon, 6 Mar 2023 01:09:43 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ6qV-0006Z4-Aj; Mon, 06 Mar 2023 10:09:27 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ6qS-002D7h-JA; Mon, 06 Mar 2023 10:09:24 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ6qR-002coM-Jt; Mon, 06 Mar 2023 10:09:23 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski , Guenter Roeck Cc: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, Christophe JAILLET , Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: [PATCH 2/3] watchdog: s3c2410_wdt: Unify error logging format in probe function Date: Mon, 6 Mar 2023 10:09:18 +0100 Message-Id: <20230306090919.2206871-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306090919.2206871-1-u.kleine-koenig@pengutronix.de> References: <891023d7-9510-445e-9053-ad5c0398d350@roeck-us.net> <20230306090919.2206871-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2391; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=0wy6Dy0bHuq9AT7DkIaobmqRGVHmG+KhTNYskb2dtn8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBa22JhVhmITJILO59i+so650I69rUMjT4609C q72jCkU8EWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWttgAKCRDB/BR4rcrs CT6CB/oCAJExWw3gqAoAPs4ZmIvkNXaaagqyh+IRMVZZ4hEGJY/VpRTigM6WcMQOLOPlnFMTG83 hPuUzTeccJl04LrUVaUuhtlLeicjaaRyPGsUCdft3UKkofojSpG5sEYU/c89kqcBH8h2Ln0yps2 ZZWLuS9YgoOuME/4z9h7XS5wXqpRITBiI+C93y7lL0KK4LDCjtvA1acBW2yD6l7aK8HdFi556bs HJ7ahmZlgA/SwTyNzibVG1KgsanPUcq5GyYtXZTSHk2Xw6x3xZNeC6tPPb0pwcujuAVcPmpSh5T JlyqZyjPl2sxq9ztB3VRRBYVafF31SVP4XXSNP503EeUC7ig X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759609382116077273?= X-GMAIL-MSGID: =?utf-8?q?1759609382116077273?= In the probe function a mixture of dev_err() and dev_err_probe() is used. Align the format of the error messages when dev_err() is used to that of dev_err_probe() for consistency. Apart from consistency this also mentions the human readable error code. Signed-off-by: Uwe Kleine-König --- drivers/watchdog/s3c2410_wdt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index 7382bf038161..93df6ee331a0 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -617,7 +617,7 @@ static int s3c2410wdt_probe(struct platform_device *pdev) ret = of_property_read_u32(dev->of_node, "samsung,cluster-index", &index); if (ret) { - dev_err(dev, "failed to get cluster index\n"); + dev_err(dev, "error %pe: failed to get cluster index\n", ERR_PTR(-EINVAL)); return -EINVAL; } @@ -631,7 +631,7 @@ static int s3c2410wdt_probe(struct platform_device *pdev) variant = &drv_data_exynosautov9_cl1; break; default: - dev_err(dev, "wrong cluster index: %u\n", index); + dev_err(dev, "error %pe: wrong cluster index: %u\n", ERR_PTR(-EINVAL), index); return -EINVAL; } } @@ -642,7 +642,7 @@ static int s3c2410wdt_probe(struct platform_device *pdev) wdt->pmureg = syscon_regmap_lookup_by_phandle(dev->of_node, "samsung,syscon-phandle"); if (IS_ERR(wdt->pmureg)) { - dev_err(dev, "syscon regmap lookup failed.\n"); + dev_err(dev, "error %pe: syscon regmap lookup failed.\n", wdt->pmureg); return PTR_ERR(wdt->pmureg); } } @@ -686,7 +686,7 @@ static int s3c2410wdt_probe(struct platform_device *pdev) dev_warn(dev, "tmr_margin value out of range, default %d used\n", S3C2410_WATCHDOG_DEFAULT_TIME); } else { - dev_err(dev, "failed to use default timeout\n"); + dev_err(dev, "error: %pe: failed to use default timeout\n", ERR_PTR(ret)); return ret; } } @@ -694,7 +694,7 @@ static int s3c2410wdt_probe(struct platform_device *pdev) ret = devm_request_irq(dev, wdt_irq, s3c2410wdt_irq, 0, pdev->name, pdev); if (ret != 0) { - dev_err(dev, "failed to install irq (%d)\n", ret); + dev_err(dev, "error: %pe: failed to install irq\n", ERR_PTR(ret)); return ret; }