From patchwork Mon Mar 6 07:34:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 64483 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1711055wrd; Sun, 5 Mar 2023 23:52:52 -0800 (PST) X-Google-Smtp-Source: AK7set9eUFHeL+4nLtqJ9CPLWANK7gLFxmscUy8dx0LswPa5UdQRewZ1OfXJZYsLe9wH7O4c8PX1 X-Received: by 2002:a17:906:12cc:b0:8f4:ec13:d599 with SMTP id l12-20020a17090612cc00b008f4ec13d599mr11306041ejb.27.1678089172556; Sun, 05 Mar 2023 23:52:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678089172; cv=none; d=google.com; s=arc-20160816; b=lZRFL3oPQRHPYN94Holp1ZoJZcIirrR+sb8WS+Xqkb/vEZCCcmtF5J4HSf5grSqI8y D7P7jq6xTBW+o70oKhZjDzW+1bF+PiySOoJXIHUTnVJ+m2nYJMNZnPp+PpSObFnzW5rA WUs9MyZwcdzCmUisf62LBkZ5t++a2+h5Ex31l0G1LdY3ul4NNm3EXl7os3pLl6/1IaMN HMCYT5fwwKnsGsh/FVxwWF794audyxzjmrmSwXrB/Itgl0nuI/glX/Nfqw6lvVMFTKhj R7tKXj2/9x20kVNovgedEF608oHwFEQDOvc8+RucqOSQPXj69Q40OsK4l370Znqt96Ia Ldzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=FP9CEH+jFZEeD0HHqef7ZlPL4FNzLI9dtaAJ3uwHa00=; b=gw60siPiImg9y6ql3tnbc78WdY1kLZF9fw63oYtpwM5mo7+ytvNBxarlvuBE5QfJ9E Ag+Dv5AOQgH02enH0qOgl6s1XCbYjzykx7omBuQS4r25s7Y3aXRBKXSxhaeGj1odnxsE 1+8TJvclXvLPzEApwsG1bbUXG7r/b7vp9TplNmQ0NzK6UmmSA2wr4PAAvpW1pTABpgrw E9Dnw9hzNPSTfP7lphv8gTjh/64qB6qEyi9vNTCCAl6xEoBW+S+jvWkWkygFBIir6mUT AMcpRK5/hudeETbbrIPB82ufyTn2weZafbUO8JWP7UE/eBLnyVy7c4tWrPM7p6NJ1lw3 c76w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a17090619c900b008b540d6ba52si9332740ejd.227.2023.03.05.23.52.28; Sun, 05 Mar 2023 23:52:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbjCFHfB (ORCPT + 99 others); Mon, 6 Mar 2023 02:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjCFHe7 (ORCPT ); Mon, 6 Mar 2023 02:34:59 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B0F1DBFA for ; Sun, 5 Mar 2023 23:34:58 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ5N2-0008P1-MR; Mon, 06 Mar 2023 08:34:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ5N2-002C0w-2o; Mon, 06 Mar 2023 08:34:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002bav-Bi; Mon, 06 Mar 2023 08:34:55 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/3] spmi: pmic-arb: Convert to platform remove callback returning void Date: Mon, 6 Mar 2023 08:34:46 +0100 Message-Id: <20230306073446.2194048-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> References: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1945; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=baC8Vc/YYIcpg5sQZ20fOmFcBz45wH3J4Jd35FckU7k=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBZeRp+KOukWfnCDPaNKuarCheUCsR4j1f92CH 4fGT4kzvDeJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWXkQAKCRDB/BR4rcrs CelrB/90x7/EalnevrxJZcp1D/0ZVT9Qwb22O7hv3KGfzxwXX+MNYARa1UkQRRESCFg/oMaykPC goVnkcez3yqNT8HCqOxInLxi5eI+yC1Rku0v4TevyrGeFGmpIiwb72WfL+A1vEiYJsXHbv1zX3g WwL8W7emEcTfMFnp3TJTtqz9I7r+kiEdCvvSV7lPvwODFyMsa1+kW4N9KnCvt358Y5hMOIbIgPM m65LMVO7D98Ws5pBzj7gACTCTuQvSrOIKhoDuMnEjNwGfa8BrmyQ1OAXXeJGbRTTtQj9ipQPaJ7 uN0IqJWcPIrH/8upCp3LZqB5daygZaQb/Fe03pblg6s9WeuZ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759604032608711520?= X-GMAIL-MSGID: =?utf-8?q?1759604032608711520?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/spmi/spmi-pmic-arb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 8b6a42ab816f..42a593418aad 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1674,7 +1674,7 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev) return err; } -static int spmi_pmic_arb_remove(struct platform_device *pdev) +static void spmi_pmic_arb_remove(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct spmi_pmic_arb *pmic_arb = spmi_controller_get_drvdata(ctrl); @@ -1682,7 +1682,6 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev) irq_set_chained_handler_and_data(pmic_arb->irq, NULL, NULL); irq_domain_remove(pmic_arb->domain); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id spmi_pmic_arb_match_table[] = { @@ -1693,7 +1692,7 @@ MODULE_DEVICE_TABLE(of, spmi_pmic_arb_match_table); static struct platform_driver spmi_pmic_arb_driver = { .probe = spmi_pmic_arb_probe, - .remove = spmi_pmic_arb_remove, + .remove_new = spmi_pmic_arb_remove, .driver = { .name = "spmi_pmic_arb", .of_match_table = spmi_pmic_arb_match_table,