From patchwork Mon Mar 6 02:45:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dongliang Mu X-Patchwork-Id: 64392 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1629236wrd; Sun, 5 Mar 2023 18:59:34 -0800 (PST) X-Google-Smtp-Source: AK7set/bR+0Q475MqEbdQu6+BxJJkctbIt+rpFxbvTo5IakzJ8AIG/HiZ3xy+kdI+T2cStvkNXRv X-Received: by 2002:a05:6a20:6699:b0:cb:6f9c:166d with SMTP id o25-20020a056a20669900b000cb6f9c166dmr9101117pzh.43.1678071574220; Sun, 05 Mar 2023 18:59:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678071574; cv=none; d=google.com; s=arc-20160816; b=AVrNsahSPLbJpiZRTY+0cvor9Lv5NM4zWPfUtLk7hx0X61isccuAnQn2StQglpHU8b GbyFqL3gkypyowYKx6/ev+WFzJw7WwHrLrEc1PB/X2dUNhIP0d3GtlDeOi7QKutHvOH3 72Msu4/LwgcY9wX73Rj5gLlzauJZAoq7zX3OW0mLbH5I/1b9wCF/npBGYDnt6IPN8bJ8 00EACLTji36YruESMcwJzCYhN64ZDQdZdaOIS/2VVAzQ34pe1EkL2Ng3U8xEduPiBzkJ 1lAdX5GwKMaVkoATq5MBlBFmKyKWiHYJfURx2iUjB/z4W2IrIt1cqJIuln3w2dElz0lR /v7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=cOlTqqTEb55eYfMzfuW6wP5Pr/314/lq/m0631hGFxE=; b=jyk6L7wZLUM5HpzOHk/o5MAMZWRMbuzvXFzkRn4AXCGdRblb3K/WkzlzZaB12PwdlZ EcrAPYVZV0kvhSi4aaVU0mfUOyKW8/hXuMqPJUANys5Q7fX+zzTv/oUePUakNUlnv5cs mbq8Iu8de9pLKGPKjmd3kaCZfPFf0zfIwg05VY2Ght/9K1Qi1K1OL+B9ZUGxcYX+GVcu PSb9Q9fpXmtHzPWSCm408XkTIU1Uz5poYzWeopWNlJbsRMjgYq6YWVpCvI5iofeFJdF2 vdXSHPCiFxkQBMnBPHfEehYWNBuQ8BE1pzX0GKzHoPxmSVpwDKe6WVl6pEZdKgeiTU9R E7fA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b23-20020aa79517000000b005de484ca9d0si7711286pfp.342.2023.03.05.18.59.22; Sun, 05 Mar 2023 18:59:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229562AbjCFCtu (ORCPT + 99 others); Sun, 5 Mar 2023 21:49:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjCFCtt (ORCPT ); Sun, 5 Mar 2023 21:49:49 -0500 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDE38F963 for ; Sun, 5 Mar 2023 18:49:47 -0800 (PST) Received: from localhost.localdomain ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 3262m5om002740-3262m5op002740 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 6 Mar 2023 10:48:09 +0800 From: Dongliang Mu To: Sekhar Nori , Bartosz Golaszewski Cc: Dongliang Mu , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers: i2c: remove dead code in davinci_i2c_probe Date: Mon, 6 Mar 2023 10:45:23 +0800 Message-Id: <20230306024523.248216-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-FEAS-AUTH-USER: dzm91@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759585578983389449?= X-GMAIL-MSGID: =?utf-8?q?1759585578983389449?= From the comment of platform_get_irq, it only returns non-zero IRQ number and negative error number, other than zero. Fix this by removing the if condition. Signed-off-by: Dongliang Mu Reviewed-by: Bartosz Golaszewski --- drivers/i2c/busses/i2c-davinci.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index c836cf884185..9750310f2c96 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -764,11 +764,8 @@ static int davinci_i2c_probe(struct platform_device *pdev) int r, irq; irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - if (!irq) - irq = -ENXIO; + if (irq < 0) return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n"); - } dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev), GFP_KERNEL);