diff mbox series

[09/11] arm64: dts: qcom: msm8994: correct RPMCC node name

Message ID 20230305125954.209559-9-krzysztof.kozlowski@linaro.org
State New
Headers
Series [01/11] arm64: dts: qcom: drop incorrect cell-index from SPMI |

Commit Message

Krzysztof Kozlowski March 5, 2023, 12:59 p.m. UTC 
  The bindings expect RPM clock controller subnode to be named
'clock-controller':

  apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests: 'rpmcc' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8994.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio March 6, 2023, 10:58 a.m. UTC | #1 
On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The bindings expect RPM clock controller subnode to be named
> 'clock-controller':
> 
>   apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests: 'rpmcc' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/msm8994.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
> index 9ff9d35496d2..768fe2326933 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
> @@ -242,7 +242,7 @@ rpm_requests: rpm-requests {
>  				compatible = "qcom,rpm-msm8994";
>  				qcom,smd-channels = "rpm_requests";
>  
> -				rpmcc: rpmcc {
> +				rpmcc: clock-controller {
>  					compatible = "qcom,rpmcc-msm8994", "qcom,rpmcc";
>  					#clock-cells = <1>;
>  				};
Petr Vorel March 7, 2023, 7:49 p.m. UTC | #2 
Hi all,

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
Krzysztof Kozlowski March 8, 2023, 8:39 a.m. UTC | #3 
On 07/03/2023 20:49, Petr Vorel wrote:
> Hi all,
> 
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

It's empty email with review tag. What did you review?

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
index 9ff9d35496d2..768fe2326933 100644
--- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
@@ -242,7 +242,7 @@  rpm_requests: rpm-requests {
 				compatible = "qcom,rpm-msm8994";
 				qcom,smd-channels = "rpm_requests";
 
-				rpmcc: rpmcc {
+				rpmcc: clock-controller {
 					compatible = "qcom,rpmcc-msm8994", "qcom,rpmcc";
 					#clock-cells = <1>;
 				};