From patchwork Fri Mar 3 17:21:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 63830 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp310687wrd; Fri, 3 Mar 2023 01:27:21 -0800 (PST) X-Google-Smtp-Source: AK7set8xA8NEFVbtWVzwz5Yh0/FSRw1SIBnKPwuY8swAdZjBeeF1jCQPmFsHlmyJhWYJd+tdRlBb X-Received: by 2002:a05:6402:5154:b0:4af:8247:273 with SMTP id n20-20020a056402515400b004af82470273mr1203942edd.7.1677835641174; Fri, 03 Mar 2023 01:27:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677835641; cv=none; d=google.com; s=arc-20160816; b=DmT1hIhnsL9AWheF31gOrq0M20I553WzcIvWDfRyVZHQ6Dm18tQjiuSXkgHFeaKATR 9ZbYi1ZBWSb2thgyY497YbhA3yAz7O7HuTSRYvVsHDtE0UZA6278yQIr2q2P8ip9XTjF 1JQxu/QH9ZD1ilBCGbwFAUztdzDFETu8r4qHiHgSskpbZUsWFEhLZGQ0US3cA81LbfvO kqSyFT6UKqhNihlk89Cef3IgUcv2QY6iHs0zuYpBOpMRTefRaeEns5lM7ssrdbu7sMIR o6n9bAg7kZ9zTEiF7uHAiQaZaHUFZ9pjgBh17L1R2U2w+rDrOQKvUwyDHC0tfboDmX8m ujCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EUBGU5tWiAXXKz4Jeihy1Ef0XVAG4+kABWCP+GKuhJk=; b=UpvhPXR+O9ma94YMj2YNIO9bHhAF2bX23qqF9DhF7z9lFaSKZRTs5PacTsRiuVnZeE gTiPklhH/zBjJvjFMqfqXthyYiej+Dr44mF7syk1VTyjGTvWpofa+uJTqzY94oRkIFmh ayfeGg/bIX1fdQxMSi8Rft+ZWOtZ9qMZU3S1XCq/lNgFSPoM675zQb0m6Skgd3+4iKPP reDAqzRSiAfkDDMuB8E/345yhYqR1uG/XMzuLNNLSBV8zporX7bTEN1K/zqPEOEqY0xC VDH2T6zVaCyqT+scbvE0XnQe29AoSbK91cucR21hcXzUn5CMTscUVRN3QPb/a6rhSN7/ 87/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b4-20020aa7c6c4000000b004ad745ab9cdsi2165787eds.530.2023.03.03.01.26.58; Fri, 03 Mar 2023 01:27:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbjCCJU4 (ORCPT + 99 others); Fri, 3 Mar 2023 04:20:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbjCCJT4 (ORCPT ); Fri, 3 Mar 2023 04:19:56 -0500 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E48E42BD2; Fri, 3 Mar 2023 01:19:56 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4PSj9M4vJQz4f3mJg; Fri, 3 Mar 2023 17:19:51 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgDnnbGyuwFkFpqfEg--.45687S18; Fri, 03 Mar 2023 17:19:53 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca, ojaswin@linux.ibm.com, ritesh.list@gmail.com Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com Subject: [PATCH v3 16/20] ext4: remove unnecessary count2 in ext4_free_data_in_buddy Date: Sat, 4 Mar 2023 01:21:16 +0800 Message-Id: <20230303172120.3800725-17-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230303172120.3800725-1-shikemeng@huaweicloud.com> References: <20230303172120.3800725-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgDnnbGyuwFkFpqfEg--.45687S18 X-Coremail-Antispam: 1UD129KBjvJXoW7KFWkWFWxAw4ruw18Ww48WFg_yoW8GF1rpa s8Ca4Uurs5Wr1kuanrC3yvqw1Iv3929Fy7try5ur1fXFy3Jr9YqFn3tryruFy8JFZ7Ar1a vFyj9ryUC3W3G3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPI14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62vIxIIY0VWUZVW8XwA2048vs2IY02 0E87I2jVAFwI0_JF0E3s1l82xGYIkIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0 rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6x IIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xv wVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFc xC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_ Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2 IErcIFxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVW8JVW5JwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Gr1j6F4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr 0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRv JPtUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759338185428556355?= X-GMAIL-MSGID: =?utf-8?q?1759338185428556355?= count2 is always 1 in mb_debug, just remove unnecessary count2. Signed-off-by: Kemeng Shi Reviewed-by: Ojaswin Mujoo --- fs/ext4/mballoc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index f05af818c14e..731810d01bbb 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3590,7 +3590,7 @@ static void ext4_free_data_in_buddy(struct super_block *sb, { struct ext4_buddy e4b; struct ext4_group_info *db; - int err, count = 0, count2 = 0; + int err, count = 0; mb_debug(sb, "gonna free %u blocks in group %u (0x%p):", entry->efd_count, entry->efd_group, entry); @@ -3606,7 +3606,6 @@ static void ext4_free_data_in_buddy(struct super_block *sb, db = e4b.bd_info; /* there are blocks to put in buddy to make them really free */ count += entry->efd_count; - count2++; ext4_lock_group(sb, entry->efd_group); /* Take it out of per group rb tree */ rb_erase(&entry->efd_node, &(db->bb_free_root)); @@ -3631,8 +3630,7 @@ static void ext4_free_data_in_buddy(struct super_block *sb, ext4_unlock_group(sb, entry->efd_group); ext4_mb_unload_buddy(&e4b); - mb_debug(sb, "freed %d blocks in %d structures\n", count, - count2); + mb_debug(sb, "freed %d blocks in 1 structures\n", count); } /*