From patchwork Fri Mar 3 17:21:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 63823 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp307496wrd; Fri, 3 Mar 2023 01:21:17 -0800 (PST) X-Google-Smtp-Source: AK7set8e2xCUKE2XUyVzPQQp4zasvfm33QZ/BkjGb60HlBlnC3TanwNZdI9AtiAXzqElVSY85s+K X-Received: by 2002:a05:6a20:2a12:b0:cc:e0fb:a835 with SMTP id e18-20020a056a202a1200b000cce0fba835mr1407584pzh.47.1677835277651; Fri, 03 Mar 2023 01:21:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677835277; cv=none; d=google.com; s=arc-20160816; b=SChhsl1gm8RnFoMzBqsD396GHXjN0heu5yLJCdJCDkY7mXCRb91oL4omw/fq4Xfbq1 jnbANYiYOD4uGfuIUDtihBmhsOFt3yvcHOtT3rVRir149a6+61D4ouYKL4mbQLOp73FJ STpjqgnS1kLyUb9NCoOxP0u/kNn8EILH6SPh50h6u4CLHAbAZDrolZdlXjbXxrVE+EFD zzQ+wdVNuK9n6xGsRXeLcQcDUPsjrvvUWD10V9ljo73eKeVa04SZOA/5mB88qy7g9xDb JR5uga0G+01EWhIJIxbGsI/owEppMgrJuYsywDdEy9wViHe36GYt4z2Cn/Rv8UNrCKBn dGOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hQHDsWnnDD7PzbaFZovxwwByHKvVPqHvxEMZ3NKTfzY=; b=bcHsdc3y8qM6BSQrMaRtMy3fc4vtRgdk9yEmYPhfsPH5JBDBN1ARjP0Njz3KtooOmR A+poPQTYTWGlhSH12mcTlpYX1t78CinNuYEvsHO3Tsj2BpEjPuWXAUJTbQPJoxQInGPN 9ZlLpIq58A/geK59A4o97wYFMM5izgIT6nhuy9xZAxysaUwVlM33j6ADM2W/HsYith6F 4frzfMqCSWBXlDSF6IPt7agyu7GTnhlIDfG51678JEJMxNtHq7ZrXzrh/FQgH+lUTjDX DC1QoiR9KdZVtBzkLpSZXKqJJvy6JjUumbwpWljb/r8oZ9BXLb3gSsTPQcqE06RWmMu2 kdmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s2-20020a63ff42000000b00502d8370977si1670316pgk.526.2023.03.03.01.21.04; Fri, 03 Mar 2023 01:21:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230405AbjCCJUj (ORCPT + 99 others); Fri, 3 Mar 2023 04:20:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbjCCJT4 (ORCPT ); Fri, 3 Mar 2023 04:19:56 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E52D034301; Fri, 3 Mar 2023 01:19:55 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4PSj9M41J7z4f3m7G; Fri, 3 Mar 2023 17:19:51 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgDnnbGyuwFkFpqfEg--.45687S17; Fri, 03 Mar 2023 17:19:53 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca, ojaswin@linux.ibm.com, ritesh.list@gmail.com Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com Subject: [PATCH v3 15/20] ext4: remove unnecessary exit_meta_group_info tag Date: Sat, 4 Mar 2023 01:21:15 +0800 Message-Id: <20230303172120.3800725-16-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230303172120.3800725-1-shikemeng@huaweicloud.com> References: <20230303172120.3800725-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgDnnbGyuwFkFpqfEg--.45687S17 X-Coremail-Antispam: 1UD129KBjvdXoW7XFWUGrW5WF4rKr45Aw47Jwb_yoWDZwb_Aa y8JF48Wr48Jr1xGa1IgrZxtr48tF4rAr1DXF43t3y3WF1DWr4ru3WkArnxArZruay7Jry5 tr93JryxJF1IqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbqxFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AK xVW8Jr0_Cr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JV WxJwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7sRiVb yDUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759337803873338810?= X-GMAIL-MSGID: =?utf-8?q?1759337803873338810?= We goto exit_meta_group_info only to return -ENOMEM. Return -ENOMEM directly instead of goto to remove this unnecessary tag. Signed-off-by: Kemeng Shi Reviewed-by: Ojaswin Mujoo --- fs/ext4/mballoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 60b39fba2fce..f05af818c14e 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3069,7 +3069,7 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, if (meta_group_info == NULL) { ext4_msg(sb, KERN_ERR, "can't allocate mem " "for a buddy group"); - goto exit_meta_group_info; + return -ENOMEM; } rcu_read_lock(); rcu_dereference(sbi->s_group_info)[idx] = meta_group_info; @@ -3123,7 +3123,6 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, group_info[idx] = NULL; rcu_read_unlock(); } -exit_meta_group_info: return -ENOMEM; } /* ext4_mb_add_groupinfo */