From patchwork Fri Mar 3 14:33:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pin-yen Lin X-Patchwork-Id: 63950 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp443107wrd; Fri, 3 Mar 2023 06:37:39 -0800 (PST) X-Google-Smtp-Source: AK7set/896VY3kPERGVyGN3v9kq7liOa5cnPCgVQn0Yr56Ce1MUQtE3+idUR4bP61TLe1mmjz/LE X-Received: by 2002:a17:902:c94b:b0:19a:c65d:f93 with SMTP id i11-20020a170902c94b00b0019ac65d0f93mr2378862pla.53.1677854258754; Fri, 03 Mar 2023 06:37:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677854258; cv=none; d=google.com; s=arc-20160816; b=a4FYwbhYY8nQHxzecqyvjvKpxoq8e51CiyNOTw63MCAUcThVyiCi0iassygcgLnLIw lP3J0zX6kljFZQW9DcdYnXhP+PM9OD5Tlv/vok1Hh1/DNnvKJMwcpnBYCeIrvkH2dMy0 MEq7J66MNYXMJKacQuh8RVAOpKqFGX8a264Us1aA1vvPcO8wY7JAy3cG9KrRJoVAvCNy qzAhv+ETiZJ0yzTX9TDBzoyJ7Gf3+vaH8EmgZOhGCJw07o/ycQEQDgOTtTs8ma2UiuJQ mo0PcMlb6/HHg+u77F6B1WcQEBEGqcausEZ0SaVDJY/dj0vhkMuubNrIJjcHjX7ryy9L EsjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2GSheqbMM/y6fCvliFj+ppp2OtEu+n0XS7KkD2oZQEI=; b=FDnnGC4fWcybeM50ifQaREiUbdHd7bc9ux0Ty5VlxouM32Lsvl5vCTDT8HFE2W+SMz s7PHtebYdQ3SqShiMWyXxp32LKY4lwJE47h43wIVZb3GGZzp9j/VDA2WB4nezwGm+mw5 7/rCAInd7u0tnhT8Df4290sGa1Owea3H0qu3QYjxY/aj0cuaWaKpShbZdcTRSZ/R44bF eCdByFpbFNX+9EKT9mq/+vg3QELKoLLNvbWPoDVsMJ6Dwt/9fmT0kqZV+t4STzcp2JKU XQRMmQA5EmOT8IyWql/L1/tXpxENvstosdkk4e6iaYSx3MfUL0xB+LhtUui4v3shlk2U 5oxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ORbbhYWj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a1709028d8a00b0019e6b514d54si2241468plo.160.2023.03.03.06.37.24; Fri, 03 Mar 2023 06:37:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ORbbhYWj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbjCCOe3 (ORCPT + 99 others); Fri, 3 Mar 2023 09:34:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230428AbjCCOeX (ORCPT ); Fri, 3 Mar 2023 09:34:23 -0500 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6481032E6F for ; Fri, 3 Mar 2023 06:34:11 -0800 (PST) Received: by mail-pg1-x52d.google.com with SMTP id 130so1604353pgg.3 for ; Fri, 03 Mar 2023 06:34:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1677854051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2GSheqbMM/y6fCvliFj+ppp2OtEu+n0XS7KkD2oZQEI=; b=ORbbhYWjcrdUXddidK8/Nloe82mnQ35GzGIrhs2jzWwUds3rWOpv5nJxxTFmFm4oQC CxegqtfkKUBMnsHmL8wgadHHiWZTzQQJykfyyzVvvTHClW+d9gQvwTdN0YWV0WMXlgK5 1aL+kygtUTM9LfKuOD6awBgLOifkrbo1tJQpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677854051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2GSheqbMM/y6fCvliFj+ppp2OtEu+n0XS7KkD2oZQEI=; b=HMJN3UV1eMxaIXq8y8mzKIaY2yWd9qdJLDOIVSe+1XsL67CgjS4X+FBe9kCBe8bUbp F5EVCIBau5yskasZfqBBCqFx6RTQZZKjuudzLJrN0z0TWRgqQO3LooguVyoSu6n49oid Q7KYMsAkxe2qhUrNHKBFHg2FSSEWCc55sDNBCWRf34r7q0kVhfL/GX06vIUQ8Bit9591 JyyHlK8YbQKR9cjXAdF8c1d/hQsPsHk5jzZ90IFXE6XQM0iPFGXO/h3YYmaeSALjHhHA r0L0a63P2COk67rZf7DZVR9qckKU5wjftCZfattzo7mK8XuUc9O1EKj37VJNfqRh6laD Rc5A== X-Gm-Message-State: AO0yUKXNRVle8274CBraUAHU9CQmDgfhNAtpPFExnj/4SNxAeDy3wEZc qFz3BTGv2z8jlsAktzDyaZE2wQ== X-Received: by 2002:a62:6185:0:b0:5a9:d4fa:d3c7 with SMTP id v127-20020a626185000000b005a9d4fad3c7mr2301621pfb.7.1677854050757; Fri, 03 Mar 2023 06:34:10 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:55e5:8423:31ee:83dd]) by smtp.gmail.com with ESMTPSA id c18-20020aa781d2000000b005a8b4dcd21asm1767214pfn.15.2023.03.03.06.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 06:34:10 -0800 (PST) From: Pin-yen Lin To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck Cc: Xin Ji , Javier Martinez Canillas , Lyude Paul , linux-kernel@vger.kernel.org, Pin-yen Lin , AngeloGioacchino Del Regno , chrome-platform@lists.linux.dev, =?utf-8?q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_P?= =?utf-8?q?rado?= , Marek Vasut , Hsin-Yi Wang , devicetree@vger.kernel.org, Allen Chen , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Stephen Boyd , linux-acpi@vger.kernel.org, Chen-Yu Tsai Subject: [PATCH v13 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Date: Fri, 3 Mar 2023 22:33:42 +0800 Message-Id: <20230303143350.815623-3-treapking@chromium.org> X-Mailer: git-send-email 2.40.0.rc0.216.gc4246ad0f0-goog In-Reply-To: <20230303143350.815623-1-treapking@chromium.org> References: <20230303143350.815623-1-treapking@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759357707516133548?= X-GMAIL-MSGID: =?utf-8?q?1759357707516133548?= From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as a supplier, fw_devlink will not be able to resolve the cyclic dependency correctly. As a result, the mode-switch driver probe() never runs, so mode-switches are never registered. Because of that, the port driver probe constantly fails with -EPROBE_DEFER, because the Type-C connector class requires all switch devices to be registered prior to port registration. To break this deadlock and allow the mode-switch registration to occur, purge all the usb-c-connector nodes' absent suppliers. This eliminates the connector as a supplier for a switch and allows it to be probed. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Acked-by: Heikki Krogerus --- (no changes since v11) Changes in v11: - Collected Acked-by tag Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v7: - Fix the long comment lines Changes in v6: - New in v6 drivers/platform/chrome/cros_ec_typec.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 001b0de95a46..bbc95a3ba5a7 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -385,6 +385,16 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) return -EINVAL; } + /* + * OF graph may have set up some device links with switches, + * since connectors have their own compatible. Purge these + * to avoid a deadlock in switch probe (the switch mistakenly + * assumes the connector is a supplier). + */ + if (dev_of_node(dev)) + device_for_each_child_node(dev, fwnode) + fw_devlink_purge_absent_suppliers(fwnode); + /* DT uses "reg" to specify port number. */ port_prop = dev->of_node ? "reg" : "port-number"; device_for_each_child_node(dev, fwnode) {