| Message ID | 20230303125844.2050449-1-usama.anjum@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp396449wrd;
Fri, 3 Mar 2023 05:05:22 -0800 (PST)
X-Google-Smtp-Source:
AK7set8NnpbCpFsexFohZnm0fhknq2pNB90/mkd8CZXp5qf1j8zdooIffAeTu/omWXu38oN3rtOo
X-Received: by 2002:a17:902:d512:b0:196:704e:2c9a with SMTP id
b18-20020a170902d51200b00196704e2c9amr2183593plg.22.1677848722148;
Fri, 03 Mar 2023 05:05:22 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1677848722; cv=none;
d=google.com; s=arc-20160816;
b=SDN7iP7MjnF8FjMo+qKkpjbDdHmSHFH91QnDSmNrCNa0/0clZtpLR8W9RCaFk0lhXp
rERwOzt+TTAdsBrGsAi7tiRti07OcdGijYKb8NKBhgDuEBYiz81wyRZMSBpF73ojXQpv
WQGDc2yf1mIFbQ9Uq+m6qLzrMpM05pRSaJsrgCWmahPBg8mqHGbu9nDGx3FHQTIyhBEt
u+BCze9O4PDhANkq40CbDb8dDGGFLc/KVN7BrdzExAQIgBFEvvAIXqRQpPxuRp3IEV79
AgnCeCYzflnFTnAvXBe+jIKfobSgB6SOGNWr7zUwkd9x46e4PrzGtpDbhPTk/RJcMbEw
IVhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=O2+ZcuEgpvH00zA78qW5u241ikbdJhKXEgh8UA4aIF0=;
b=Y5pIc/aSTkRsgggrYBayctPtNxp0/+t3r9fDs0umeF4/qVajj3xYNcR79zPG9+pNYS
r0U/z/Td3ZZU49qK4Vyl1tz72wmsye/CL1zdu2tTkhndxYs/O6PCink1Li8tBKfJAYJW
iUyonvbhFlMwwHrqFdfj3YAkMDo8n2LkwQ9FoK074BkUJAzJpOARBb+hivIM/lM25jJl
6mHKuIfi6MG4LxoKz05ELhFpXua8/rGv4lPwQVmcH1ayCgmjX35HyO2NSwLSfaVrqHG2
mup+jB5nf2MnfiCttzQ+wjbnu6TpVi/wsl4kdcgl2cflLT4jLjKFtsh+OxypFPugriyz
SoKw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=RLZn0nje;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
e1-20020a170902744100b0019a66cb2194si2277273plt.101.2023.03.03.05.05.07;
Fri, 03 Mar 2023 05:05:22 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=RLZn0nje;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230247AbjCCM7c (ORCPT <rfc822;davidbtadokoro@gmail.com>
+ 99 others); Fri, 3 Mar 2023 07:59:32 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42706 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229541AbjCCM7a (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 3 Mar 2023 07:59:30 -0500
Received: from madras.collabora.co.uk (madras.collabora.co.uk
[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 868DC521D3;
Fri, 3 Mar 2023 04:59:27 -0800 (PST)
Received: from localhost.localdomain (unknown [182.179.171.187])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
(Authenticated sender: usama.anjum)
by madras.collabora.co.uk (Postfix) with ESMTPSA id C769E6602FB8;
Fri, 3 Mar 2023 12:59:22 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1677848365;
bh=MDOqV2RHO0eQ1qKkCRXV3uNsxpoqYhQQGsWN9W/E1oE=;
h=From:To:Cc:Subject:Date:From;
b=RLZn0njeawNYwS1ZNGYzL18IRaIhIRcVIfa36KBsISaD3ae31IG0Gw66EjuwZhdK+
fgsNEO9yRSGCom1UqHVWFS8qCV2QsiXIRwHgOMCUon3J1APkxaKK9nH8WvIuXLJ0GY
Iak0zz1BJUvuZjz4kaQlKs5BhROOUTLDtavEz2M17TOj1U1a3x8hBzI6lrkIuTGPyF
a/334sk7prYwg9yxcVx2RPG/bdXTzkELSZMlrsy4FfWDJ1MECJjfhiKT5BLmRsKwiS
yai/ee0YUTXhoSIhJ1M+yUGcady0xUyjTs2guC53Gl+rKuLFOyZxbqhjizbKhvLRqT
r1ieOWXIRuS+w==
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Ariel Elior <aelior@marvell.com>,
Manish Chopra <manishc@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
kernel@collabora.com, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] qede: remove linux/version.h
Date: Fri, 3 Mar 2023 17:58:44 +0500
Message-Id: <20230303125844.2050449-1-usama.anjum@collabora.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1759351901588073922?=
X-GMAIL-MSGID: =?utf-8?q?1759351901588073922?=
|
| Series |
qede: remove linux/version.h
|
|
Commit Message
Muhammad Usama Anjum
March 3, 2023, 12:58 p.m. UTC
make versioncheck reports the following:
./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
So remove linux/version.h from both of these files.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
drivers/net/ethernet/qlogic/qede/qede.h | 1 -
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
2 files changed, 2 deletions(-)
Comments
From: Muhammad Usama Anjum <usama.anjum@collabora.com> Date: Fri, 3 Mar 2023 17:58:44 +0500 > make versioncheck reports the following: > ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed. > ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed. > > So remove linux/version.h from both of these files. > > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > drivers/net/ethernet/qlogic/qede/qede.h | 1 - > drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h > index f90dcfe9ee68..6ff1bd48d2aa 100644 > --- a/drivers/net/ethernet/qlogic/qede/qede.h > +++ b/drivers/net/ethernet/qlogic/qede/qede.h > @@ -7,7 +7,6 @@ > #ifndef _QEDE_H_ > #define _QEDE_H_ > #include <linux/compiler.h> I think compiler.h is also unused, maybe this one too, while at it? > -#include <linux/version.h> > #include <linux/workqueue.h> > #include <linux/netdevice.h> > #include <linux/interrupt.h> > diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c > index 8034d812d5a0..374a86b875a3 100644 > --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c > +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c > @@ -4,7 +4,6 @@ > * Copyright (c) 2019-2020 Marvell International Ltd. > */ > > -#include <linux/version.h> > #include <linux/types.h> > #include <linux/netdevice.h> > #include <linux/etherdevice.h> Thanks, Olek
On 3/3/23 8:35 PM, Alexander Lobakin wrote: > From: Muhammad Usama Anjum <usama.anjum@collabora.com> > Date: Fri, 3 Mar 2023 17:58:44 +0500 > >> make versioncheck reports the following: >> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed. >> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed. >> >> So remove linux/version.h from both of these files. >> >> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >> --- >> drivers/net/ethernet/qlogic/qede/qede.h | 1 - >> drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h >> index f90dcfe9ee68..6ff1bd48d2aa 100644 >> --- a/drivers/net/ethernet/qlogic/qede/qede.h >> +++ b/drivers/net/ethernet/qlogic/qede/qede.h >> @@ -7,7 +7,6 @@ >> #ifndef _QEDE_H_ >> #define _QEDE_H_ >> #include <linux/compiler.h> > > I think compiler.h is also unused, maybe this one too, while at it?' Just checked, it is also not being used. I'll send v2. > >> -#include <linux/version.h> >> #include <linux/workqueue.h> >> #include <linux/netdevice.h> >> #include <linux/interrupt.h> >> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c >> index 8034d812d5a0..374a86b875a3 100644 >> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c >> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c >> @@ -4,7 +4,6 @@ >> * Copyright (c) 2019-2020 Marvell International Ltd. >> */ >> >> -#include <linux/version.h> >> #include <linux/types.h> >> #include <linux/netdevice.h> >> #include <linux/etherdevice.h> > > Thanks, > Olek
diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h index f90dcfe9ee68..6ff1bd48d2aa 100644 --- a/drivers/net/ethernet/qlogic/qede/qede.h +++ b/drivers/net/ethernet/qlogic/qede/qede.h @@ -7,7 +7,6 @@ #ifndef _QEDE_H_ #define _QEDE_H_ #include <linux/compiler.h> -#include <linux/version.h> #include <linux/workqueue.h> #include <linux/netdevice.h> #include <linux/interrupt.h> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c index 8034d812d5a0..374a86b875a3 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c @@ -4,7 +4,6 @@ * Copyright (c) 2019-2020 Marvell International Ltd. */ -#include <linux/version.h> #include <linux/types.h> #include <linux/netdevice.h> #include <linux/etherdevice.h>