accessibility: speakup: remove linux/version.h

Message ID 20230303125152.2030241-1-usama.anjum@collabora.com
State New
Headers
Series accessibility: speakup: remove linux/version.h |

Commit Message

Muhammad Usama Anjum March 3, 2023, 12:51 p.m. UTC
  make versioncheck reports the following:
./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.

So remove linux/version.h from both of these files.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 drivers/accessibility/speakup/genmap.c      | 1 -
 drivers/accessibility/speakup/makemapdata.c | 1 -
 2 files changed, 2 deletions(-)
  

Comments

Samuel Thibault March 3, 2023, 1:22 p.m. UTC | #1
Muhammad Usama Anjum, le ven. 03 mars 2023 17:51:51 +0500, a ecrit:
> make versioncheck reports the following:
> ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
> ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
> 
> So remove linux/version.h from both of these files.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> ---
>  drivers/accessibility/speakup/genmap.c      | 1 -
>  drivers/accessibility/speakup/makemapdata.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0125000e00d9..0882bab10fb8 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -10,7 +10,6 @@
>  #include <stdio.h>
>  #include <libgen.h>
>  #include <string.h>
> -#include <linux/version.h>
>  #include <ctype.h>
>  #include "utils.h"
>  
> diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
> index d7d41bb9b05f..55e4ef8a93dc 100644
> --- a/drivers/accessibility/speakup/makemapdata.c
> +++ b/drivers/accessibility/speakup/makemapdata.c
> @@ -10,7 +10,6 @@
>  #include <stdio.h>
>  #include <libgen.h>
>  #include <string.h>
> -#include <linux/version.h>
>  #include <ctype.h>
>  #include "utils.h"
>  
> -- 
> 2.39.2
>
  
Muhammad Usama Anjum June 16, 2023, 12:53 p.m. UTC | #2
Soft reminder.

On 3/3/23 5:51 PM, Muhammad Usama Anjum wrote:
> make versioncheck reports the following:
> ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
> ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
> 
> So remove linux/version.h from both of these files.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  drivers/accessibility/speakup/genmap.c      | 1 -
>  drivers/accessibility/speakup/makemapdata.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0125000e00d9..0882bab10fb8 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -10,7 +10,6 @@
>  #include <stdio.h>
>  #include <libgen.h>
>  #include <string.h>
> -#include <linux/version.h>
>  #include <ctype.h>
>  #include "utils.h"
>  
> diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
> index d7d41bb9b05f..55e4ef8a93dc 100644
> --- a/drivers/accessibility/speakup/makemapdata.c
> +++ b/drivers/accessibility/speakup/makemapdata.c
> @@ -10,7 +10,6 @@
>  #include <stdio.h>
>  #include <libgen.h>
>  #include <string.h>
> -#include <linux/version.h>
>  #include <ctype.h>
>  #include "utils.h"
>
  
Samuel Thibault June 16, 2023, 2:50 p.m. UTC | #3
Muhammad Usama Anjum, le ven. 16 juin 2023 17:53:12 +0500, a ecrit:
> Soft reminder.

It somehow hadn't appeared in my inbox.

> On 3/3/23 5:51 PM, Muhammad Usama Anjum wrote:
> > make versioncheck reports the following:
> > ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
> > ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
> > 
> > So remove linux/version.h from both of these files.
> > 
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> > ---
> >  drivers/accessibility/speakup/genmap.c      | 1 -
> >  drivers/accessibility/speakup/makemapdata.c | 1 -
> >  2 files changed, 2 deletions(-)
> > 
> > diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> > index 0125000e00d9..0882bab10fb8 100644
> > --- a/drivers/accessibility/speakup/genmap.c
> > +++ b/drivers/accessibility/speakup/genmap.c
> > @@ -10,7 +10,6 @@
> >  #include <stdio.h>
> >  #include <libgen.h>
> >  #include <string.h>
> > -#include <linux/version.h>
> >  #include <ctype.h>
> >  #include "utils.h"
> >  
> > diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
> > index d7d41bb9b05f..55e4ef8a93dc 100644
> > --- a/drivers/accessibility/speakup/makemapdata.c
> > +++ b/drivers/accessibility/speakup/makemapdata.c
> > @@ -10,7 +10,6 @@
> >  #include <stdio.h>
> >  #include <libgen.h>
> >  #include <string.h>
> > -#include <linux/version.h>
> >  #include <ctype.h>
> >  #include "utils.h"
> >  
> 
> -- 
> BR,
> Muhammad Usama Anjum
>
  
Muhammad Usama Anjum June 28, 2023, 10:11 a.m. UTC | #4
On 6/16/23 7:50 PM, Samuel Thibault wrote:
> Muhammad Usama Anjum, le ven. 16 juin 2023 17:53:12 +0500, a ecrit:
>> Soft reminder.
> 
> It somehow hadn't appeared in my inbox.
This patch hasn't been accepted yet.

> 
>> On 3/3/23 5:51 PM, Muhammad Usama Anjum wrote:
>>> make versioncheck reports the following:
>>> ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
>>> ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
>>>
>>> So remove linux/version.h from both of these files.
>>>
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> 
> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 
> Thanks!
> 
>>> ---
>>>  drivers/accessibility/speakup/genmap.c      | 1 -
>>>  drivers/accessibility/speakup/makemapdata.c | 1 -
>>>  2 files changed, 2 deletions(-)
>>>
>>> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
>>> index 0125000e00d9..0882bab10fb8 100644
>>> --- a/drivers/accessibility/speakup/genmap.c
>>> +++ b/drivers/accessibility/speakup/genmap.c
>>> @@ -10,7 +10,6 @@
>>>  #include <stdio.h>
>>>  #include <libgen.h>
>>>  #include <string.h>
>>> -#include <linux/version.h>
>>>  #include <ctype.h>
>>>  #include "utils.h"
>>>  
>>> diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
>>> index d7d41bb9b05f..55e4ef8a93dc 100644
>>> --- a/drivers/accessibility/speakup/makemapdata.c
>>> +++ b/drivers/accessibility/speakup/makemapdata.c
>>> @@ -10,7 +10,6 @@
>>>  #include <stdio.h>
>>>  #include <libgen.h>
>>>  #include <string.h>
>>> -#include <linux/version.h>
>>>  #include <ctype.h>
>>>  #include "utils.h"
>>>  
>>
>> -- 
>> BR,
>> Muhammad Usama Anjum
>>
>
  

Patch

diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
index 0125000e00d9..0882bab10fb8 100644
--- a/drivers/accessibility/speakup/genmap.c
+++ b/drivers/accessibility/speakup/genmap.c
@@ -10,7 +10,6 @@ 
 #include <stdio.h>
 #include <libgen.h>
 #include <string.h>
-#include <linux/version.h>
 #include <ctype.h>
 #include "utils.h"
 
diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
index d7d41bb9b05f..55e4ef8a93dc 100644
--- a/drivers/accessibility/speakup/makemapdata.c
+++ b/drivers/accessibility/speakup/makemapdata.c
@@ -10,7 +10,6 @@ 
 #include <stdio.h>
 #include <libgen.h>
 #include <string.h>
-#include <linux/version.h>
 #include <ctype.h>
 #include "utils.h"