From patchwork Fri Mar 3 12:02:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 63875 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp377297wrd; Fri, 3 Mar 2023 04:18:07 -0800 (PST) X-Google-Smtp-Source: AK7set9suQdKD7TJBqU/jR/cedniJvgmuqsIKyw9vOIbiLLdcfcGmePqPjITwPhlfAQfEgwWP6n7 X-Received: by 2002:a17:906:8156:b0:886:221b:44e5 with SMTP id z22-20020a170906815600b00886221b44e5mr1533229ejw.62.1677845887096; Fri, 03 Mar 2023 04:18:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677845887; cv=none; d=google.com; s=arc-20160816; b=ozlu56mtb1JUmop5NXrgjpFwK2VT1AxVpcHenBCcdCpdG6R8B8RYdaMYqrjakRAEdg DncXvQJDEARpVdkwKBzQFYI0gTCGbfx5Onk2QNJDl0/xtcAWDoyT4YpyAOoNjU1I1tgZ EczFGcyvsZUIlnMtxRM80RHt/oU4U5/pMtFacWluZMc6ggM2mOYouijhADS3a2aAzjSG kcgOYe2WvrZwC312ad+ZuR46LBSmJ6NLpjm+2drO3kOIq8svPakr/lz1t8wsi2R3F51O zcitCAd20mYZwWSOfkAeIZBpXKrUPHbcTA7TXzFbbMbo1KRMRdMvSSq+WioG00nxR+BC OoMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/Mq3sKJfMkg5bmW+N1FfZmsJS1EmjB8W9zhk59rbnVM=; b=WRh7FU1XxFPYWu5tj3/SCSOCe8sI6VGtJNgbcTOsjE7ozb4oxM3eU2+bQmxrcvNdK+ snGjPop4nDqcaNbKm0wA2FxZTidNqtM53kbLPzO8TfNUWKOMZs2uBdkbb94C+djgCanG IipaUWpEErQEfA5JYs58qu7rPQYZtbfrOhooBCGZpmevXWRCjkdPKBrkX6FGuEUW52io pnYxyafCt6GiLk5lHU1Vt6qlAlsfkUlnrekHGa/GrBSq5uYMMyOwt+A2KXalUe/rFWBl dH9uxvlQbZ4n09qBffk1HyMwAsHENc9qCj6FsYbAyJ2f2Ldvd1GN8Nn9qC1sy1+PGiHY SuKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JGNkfj0R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s16-20020a170906169000b008cec55af409si1957922ejd.411.2023.03.03.04.17.44; Fri, 03 Mar 2023 04:18:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JGNkfj0R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbjCCMDH (ORCPT + 99 others); Fri, 3 Mar 2023 07:03:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229925AbjCCMDG (ORCPT ); Fri, 3 Mar 2023 07:03:06 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41548768D; Fri, 3 Mar 2023 04:03:05 -0800 (PST) Received: from localhost.localdomain (unknown [182.179.171.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 08B366602F6A; Fri, 3 Mar 2023 12:02:55 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1677844983; bh=Hi8NWUOMMhmWak92kY1THi2+V5As1Gogx3xi3UhkAYk=; h=From:To:Cc:Subject:Date:From; b=JGNkfj0R1zmjv3rck3W64LfaNpmhpZiJvB4SF6QxmIUFL6E894MBBQ9jLy7cLa0UZ /WhSqN1k2/TX29VIffjcQeg+keZDXGN66tQtoHqU7Rdv1RWq1UmlUkcoCTKHjvuCqQ EGBzKHC8GmC5getS+aJ7vEaKCdXIMA6jNRNXJQWgkOzKGOLzVqDv87zPXVDKcXNcHi isDRmxTMhl25NtPlhcGviYxsFdMoj4GzFHp/zX+kPgS/J1FAZfh49fW7OwRhwA+UI+ wUp1z15IiQ/VpF21BNu5IjileBKwv60BjkKkS7nPhhXV9PYYgVV6z1mm1pHFmIAedG 66fkI/Ppm0EGA== From: Muhammad Usama Anjum To: Evan Quan , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Kun Liu Cc: Muhammad Usama Anjum , kernel@collabora.com, kernel-janitors@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu: remove dead code Date: Fri, 3 Mar 2023 17:02:32 +0500 Message-Id: <20230303120233.1878140-1-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759348929057581443?= X-GMAIL-MSGID: =?utf-8?q?1759348929057581443?= The less than zero comparison of unsigned variable "value" is never true. Remove dead code. Fixes: c3ed0e72c872 ("drm/amdgpu: added a sysfs interface for thermal throttling") Signed-off-by: Muhammad Usama Anjum --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index f212cae0353f..0ffe351c1a1d 100644 --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c @@ -1738,7 +1738,7 @@ static ssize_t amdgpu_set_apu_thermal_cap(struct device *dev, if (ret) return ret; - if (value < 0 || value > 100) { + if (value > 100) { dev_err(dev, "Invalid argument !\n"); return -EINVAL; }