From patchwork Fri Mar 3 09:23:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Jui Wang X-Patchwork-Id: 63842 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp316773wrd; Fri, 3 Mar 2023 01:37:21 -0800 (PST) X-Google-Smtp-Source: AK7set/F6RLHMQ8izaYR7A0kiZp+JdsfyY7AuR0b5eqqPfLbrrcRo8UgStknED82/t+ZgwQMyIBv X-Received: by 2002:a17:907:6eac:b0:8b1:2d7f:ed57 with SMTP id sh44-20020a1709076eac00b008b12d7fed57mr1161351ejc.42.1677836241412; Fri, 03 Mar 2023 01:37:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677836241; cv=none; d=google.com; s=arc-20160816; b=q6TAw6BcTHgRrPUS+e2xb61J4vFKB152/m4idXNGaTdjBg1A9vUiSGZrN6n52wjEGZ OiyctugkuQBpydfXVEbjA/eAs+rRGDAYNZSugY74ceD9A8g6ur2ZjhlRTT4zRFOz4osp 0Zz/PBpJwaALXFyXNNwWdJDsvRSu3VagEj2o48i1aN0L0pn9hOBpTuCkI1+zz3z3lnNg SPkb3gDKhx3POA7C98gG7H31Ab8WA19h5gKxqO8FQnF05NqZwKP3JW3xztTAQr46nq2n 9GjGaa1mQwNVGmU1a56veV4o3/+3RGQZw0N10pIwGtVZuN24S0gsFxIpxguPcugxNQrb zLtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Sh4Pn9fpBEAZmsI3UxrbkJdlT6TxlulP3ExKBV+rbeM=; b=N+SRqHFdE0F1p4LIGgP8pdk5xngWW2lbAI2YNvNlLzZdVWmAbcVPLMILjvmegGRw3o H3ykirEIjYzOfJYNERqTUGDM21NaqDmgXaa0xixfe1a+nrDbOQvkhJzAF3BLUMFhYx+p MxC+Uqi6T39PZ/IHxctY3d7ftXFHcScPO5QaDyYpqKSCyAPUGF77yaDp1pVeU2CADAOW TReLn7BTLpJ1pFif56uvUj4Krqf6VlvB1+NV2X5VBiaxpMLAtKUsM3oR0Ho1uch0x5Pe mg6YosRT5YkqQ34CS0q1e+tiFas+yYxH5prguOQ3I5Pr5pIpiy/4/FYBgb5BnmD9IS3p vxlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=DtqdSYiV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gz27-20020a170907a05b00b008eb6f52bf2bsi1854364ejc.936.2023.03.03.01.36.59; Fri, 03 Mar 2023 01:37:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=DtqdSYiV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230497AbjCCJ0f (ORCPT + 99 others); Fri, 3 Mar 2023 04:26:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231240AbjCCJZq (ORCPT ); Fri, 3 Mar 2023 04:25:46 -0500 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAE805B5F5; Fri, 3 Mar 2023 01:25:27 -0800 (PST) X-UUID: 5200c634b9a511eda06fc9ecc4dadd91-20230303 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=Sh4Pn9fpBEAZmsI3UxrbkJdlT6TxlulP3ExKBV+rbeM=; b=DtqdSYiVQFX3WU/Da4SoReNG6WVPTWDFXttgPCpyCGG5z5Qh/hJQ0NmFmSTxu+00ZEC+f2OqQz7mxhMi7VT5fZ3D4KdWV/0zIShfylGqaItL96emrzAJrel2LYwY6EyEq1jX8bYy2ezv7uCQncQz0fkhgG1iuIzKw8waw8X+clc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.20,REQID:58504ac7-4e0f-47dd-aaa5-6cbe8455e7fb,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:25b5999,CLOUDID:eabe1db2-beed-4dfc-bd9c-e1b22fa6ccc4,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0,NGT X-UUID: 5200c634b9a511eda06fc9ecc4dadd91-20230303 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 243878210; Fri, 03 Mar 2023 17:25:21 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Fri, 3 Mar 2023 17:25:20 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Fri, 3 Mar 2023 17:25:20 +0800 From: Cheng-Jui Wang To: , Russell King , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , "NXP Linux Team" , Matthias Brugger CC: Peter Zijlstra , Ingo Molnar , Suren Baghdasaryan , Cheng-Jui Wang , , , Subject: [PATCH 05/10] cpuidle, ARM/imx6: Push RCU-idle into driver Date: Fri, 3 Mar 2023 17:23:27 +0800 Message-ID: <20230303092347.4825-6-cheng-jui.wang@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20230303092347.4825-1-cheng-jui.wang@mediatek.com> References: <20230303092347.4825-1-cheng-jui.wang@mediatek.com> MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759338814366589638?= X-GMAIL-MSGID: =?utf-8?q?1759338814366589638?= From: Peter Zijlstra commit b3f46658ce40a3467cda82f920dd9d5325ab0eaf upstream. Doing RCU-idle outside the driver, only to then temporarily enable it again, at least twice, before going idle is suboptimal. Notably both cpu_pm_enter() and cpu_cluster_pm_enter() implicity re-enable RCU. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Tested-by: Tony Lindgren Tested-by: Ulf Hansson Reviewed-by: Frederic Weisbecker Acked-by: Rafael J. Wysocki Link: https://lore.kernel.org/r/20230112195539.821714572@infradead.org Signed-off-by: Suren Baghdasaryan Signed-off-by: Cheng-Jui Wang --- arch/arm/mach-imx/cpuidle-imx6sx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-imx/cpuidle-imx6sx.c index 74ea1720e3d8..1dc01f6b0f36 100644 --- a/arch/arm/mach-imx/cpuidle-imx6sx.c +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c @@ -47,7 +47,9 @@ static int imx6sx_enter_wait(struct cpuidle_device *dev, cpu_pm_enter(); cpu_cluster_pm_enter(); + ct_idle_enter(); cpu_suspend(0, imx6sx_idle_finish); + ct_idle_exit(); cpu_cluster_pm_exit(); cpu_pm_exit(); @@ -87,7 +89,8 @@ static struct cpuidle_driver imx6sx_cpuidle_driver = { */ .exit_latency = 300, .target_residency = 500, - .flags = CPUIDLE_FLAG_TIMER_STOP, + .flags = CPUIDLE_FLAG_TIMER_STOP | + CPUIDLE_FLAG_RCU_IDLE, .enter = imx6sx_enter_wait, .name = "LOW-POWER-IDLE", .desc = "ARM power off",