From patchwork Fri Mar 3 08:33:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tinghan Shen X-Patchwork-Id: 63788 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp293694wrd; Fri, 3 Mar 2023 00:35:44 -0800 (PST) X-Google-Smtp-Source: AK7set+a+g4xYGaqKtWtB1yGqbqBFfrsDZW1QeZqy+Skd/fneKCN3p1h5DDUeDtYhQPBFTbkWESW X-Received: by 2002:a17:906:af67:b0:8b1:2ebf:386c with SMTP id os7-20020a170906af6700b008b12ebf386cmr850714ejb.11.1677832544506; Fri, 03 Mar 2023 00:35:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677832544; cv=none; d=google.com; s=arc-20160816; b=gavOl4nz+g8i7ovfgUaKKU8p5FIdY6hKiNXNZoVb9ZAxoGkkaGCj8cV7vkQ+TDUkK6 BxwNMICu6PgUAPEoAEEFj3OJeAhn0MnwtuG322bqrhnDjvPpeVuLxx1WS6HfE6wK/9XL eP7FKUNirwCT9lbKwtIIXAYgtuOD0V5+akeVJbVjeYK9G/AjhuJBe4ogLyohrJGaLLcE VTR1XB83PouKlxpvepWz6Uvh5r+Zw+PNY0itxuDg2oqBMVNFbgg2PySuJRlRDSOXbIjt Kdky6MnUSsWNpy10zXZ4hIX0oBaiukxMRsOAAXvQwJgbzmqD9FqZa3xc5Dmpbq72epW4 ye0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ELFAv6mnjMIL1R/76fzrZkUpb1TnLkxsaCN2YHOI1ms=; b=zhOvyzqJ6JV0IXdN2OvlVs4RHJHyB0Mu6EQE64cKayVmmeBNbJVhweHOx7uNxLcZIK Yj41ek3+YHAn+4hJBv8X+s1UryjG7+O84ZpzaOBLmV0gOm0hDuR9l8PDk4NN01VuTbe/ b6GYalQ7sM8Z0xYGTrvR+Erb1xprdf1HssmlgfD+1GZOSESiQeSvJ4iOQCzLm0H1VS4/ iDOTL44bTzEJmd5/2E77owHSVoACxH2vFmirKTNWPtIlgHXx2KHEs2pgBMDOHGkDQFWG VGAFOnLoX8RbdHwgpePmRJyk1fqS8o1lR24RszM1X2GCFM0W0bXBOfhxY/U+8rdCf5Rq cQLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=YgdGeE4A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020a1709061e8700b008cf02438e0dsi1654360ejj.683.2023.03.03.00.35.22; Fri, 03 Mar 2023 00:35:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=YgdGeE4A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230260AbjCCIee (ORCPT + 99 others); Fri, 3 Mar 2023 03:34:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbjCCIeS (ORCPT ); Fri, 3 Mar 2023 03:34:18 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 889CE13D77; Fri, 3 Mar 2023 00:34:11 -0800 (PST) X-UUID: 26b85fa2b99e11ed945fc101203acc17-20230303 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=ELFAv6mnjMIL1R/76fzrZkUpb1TnLkxsaCN2YHOI1ms=; b=YgdGeE4Ay21UXir5GhXR+in/EabycuGcQnp66fY7H0nP+fK6yEv7cDvffxRkpliznUEgs5NC2uDqirmFhad80x6G9lAafaaO3Nr+yxHAN5OngCXKb3fuEnYkvnp8BI+aPCw6ttCsSAGit52UyQGtHOblCzQeJVM/JmZR0lslxIg=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.20,REQID:45128724-ae79-46eb-9bf8-db47d35454c9,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:25b5999,CLOUDID:dcc71bb2-beed-4dfc-bd9c-e1b22fa6ccc4,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-UUID: 26b85fa2b99e11ed945fc101203acc17-20230303 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1771808149; Fri, 03 Mar 2023 16:34:02 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Fri, 3 Mar 2023 16:34:00 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Fri, 3 Mar 2023 16:34:00 +0800 From: Tinghan Shen To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen CC: , , , , , Subject: [PATCH v8 10/11] remoteproc: mediatek: Refine ipi handler error message Date: Fri, 3 Mar 2023 16:33:54 +0800 Message-ID: <20230303083355.3378-11-tinghan.shen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20230303083355.3378-1-tinghan.shen@mediatek.com> References: <20230303083355.3378-1-tinghan.shen@mediatek.com> MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759334938093123975?= X-GMAIL-MSGID: =?utf-8?q?1759334938093123975?= The error message doesn't accurately reflect the cause of the error. The error is due to a handler not being found, not an invalid IPI ID. Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno --- drivers/remoteproc/mtk_scp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 056a814486a3..6094f79e9565 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -113,7 +113,7 @@ static void scp_ipi_handler(struct mtk_scp *scp) scp_ipi_lock(scp, id); handler = ipi_desc[id].handler; if (!handler) { - dev_err(scp->dev, "No such ipi id = %d\n", id); + dev_err(scp->dev, "No handler for ipi id = %d\n", id); scp_ipi_unlock(scp, id); return; }