From patchwork Thu Mar 2 14:47:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63442 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273482wrd; Thu, 2 Mar 2023 06:51:20 -0800 (PST) X-Google-Smtp-Source: AK7set8VEWWfqJh87VIdWxCS/TmcXhU+/Y/iDmjLUBxlC0fxkmeYBRBhhUvK6Ppq0rgQrMs7J/iV X-Received: by 2002:a17:902:f546:b0:19e:2ea1:c0f5 with SMTP id h6-20020a170902f54600b0019e2ea1c0f5mr12820558plf.33.1677768680352; Thu, 02 Mar 2023 06:51:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768680; cv=none; d=google.com; s=arc-20160816; b=Y2IKhckSK948tMlVcMKiEt4MaUZOzEdhVYBeR5APLN7NFZwCI5kyNd84785Mtb5OWZ YCqQM+5K0qoIaur1+zPVjdPqYwdFzg6CKq28oj9p+EL2aEQJFei1McDJJU+s4uqjOkau 54/Xs+f4GISvwuz6QjRFJPWW2MUVF+wHlmhUqzAGnUqc7+giCirAVMKFzUUjEGAGJYIM IESPDOX8PdPbEr2NpScvabK9YWp/3rrj1ee4WuLzSPl5yV5Lad8jwB3vAQLHnywwP6EO 8GfkAxoKjVZjSytNMemXX+2sh9i0nZvnBWVmZ1YPobUN0lizir3oCzQPJdsdAiiBCFSW qjPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sFB/LA/anL269WLEWVMjYo6E0SSsHjsYWJVeXU0Okb8=; b=XPldYF7pkj57d/otwXZQKegBM2Lcg1ReIGosM7z+5gI75teY65GbycljnKI+wwkSxe c3eMcBCSt/fb6ySBgv9wVtwy7pB3R9sws93zkA33rDvjTUGtxI3k4lNlA4Wg8DbRm+KE rsmF5dbWdtyFjqEsKEnXPKfLRstCZ6qSsDo+csEUql+ar3ewY5Wq7TOun54Z8YvDcrwW O0CtOI87tuAnVzHWJ+qH6dxWQ2IXEwsFeFt2xTQq8yAOhOHhuUdCLQFPfm8m45xKGoBf 37bU10737B5ePv4dqAl94a3sxKNGNb/QGD8lz5P6SD36+iuRNw+RZkMrWIHjZu8XEq5z 3aiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kn12-20020a170903078c00b0019e4124a43asi5706301plb.61.2023.03.02.06.51.05; Thu, 02 Mar 2023 06:51:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbjCBOsX (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 827FE474E3 for ; Thu, 2 Mar 2023 06:47:49 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003rJ-BC; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDa-001LrC-Bs; Thu, 02 Mar 2023 15:47:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Zpi-Kt; Thu, 02 Mar 2023 15:47:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Santosh Kumar Yadav , Peter Korsgaard , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/29] platform/x86: barco-p50-gpio: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:10 +0100 Message-Id: <20230302144732.1903781-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1730; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=3SITRhRSsSiq5nNlw0cLw6UVXc4FMRsIXWa8cM62MP8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALade3Gi1p/sJd8H8iXfaMV7bNpT7R16FeAlt mHVTQ9i3e+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2nQAKCRDB/BR4rcrs CYxWB/0T9N2ZDz5pxanXc2jdn15Ou5okIo+OA378H8eFhJmwvYWT8z4crokjCAlcWEzwa4cv+3P +rZX9fAQRiNbIBH8+1OCOBVoPTZ5k9omOFb0s2QMgmXfEgi/daEjB5wJmBGpaCZVYw92pbn5D7A qKn1YLoQctNI8bhW9gbeLMNaG0IwGNHMGywnxwYb7ruLPvybqYBRSqLRJz7Mcal0jXC/D0djcPz tShBXQRNLFixNR4CiyoKY5vkLOn0YIYt8Wt8cXDxU3SLtxsyUM74CIsVAonZCEdNUeJRGYFVhOy bv6cuIeSpFDjQOK/272o5cD/s88jM+6NiCRI3Wxy0lhvfase X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267971339756987?= X-GMAIL-MSGID: =?utf-8?q?1759267971339756987?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/barco-p50-gpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c index 8dd672339485..af566f712057 100644 --- a/drivers/platform/x86/barco-p50-gpio.c +++ b/drivers/platform/x86/barco-p50-gpio.c @@ -370,7 +370,7 @@ static int p50_gpio_probe(struct platform_device *pdev) return ret; } -static int p50_gpio_remove(struct platform_device *pdev) +static void p50_gpio_remove(struct platform_device *pdev) { struct p50_gpio *p50 = platform_get_drvdata(pdev); @@ -378,8 +378,6 @@ static int p50_gpio_remove(struct platform_device *pdev) platform_device_unregister(p50->leds_pdev); gpiod_remove_lookup_table(&p50_gpio_led_table); - - return 0; } static struct platform_driver p50_gpio_driver = { @@ -387,7 +385,7 @@ static struct platform_driver p50_gpio_driver = { .name = DRIVER_NAME, }, .probe = p50_gpio_probe, - .remove = p50_gpio_remove, + .remove_new = p50_gpio_remove, }; /* Board setup */