From patchwork Thu Mar 2 14:47:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63440 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273474wrd; Thu, 2 Mar 2023 06:51:19 -0800 (PST) X-Google-Smtp-Source: AK7set+Ktp8yJPLfrJr265++clWC0s3z3Prr5XtV4vaZjcHBNGpRdG3P3VvaXSeRRVYMB0Si4SIt X-Received: by 2002:a17:90a:7a8f:b0:237:8c4c:c908 with SMTP id q15-20020a17090a7a8f00b002378c4cc908mr11917697pjf.26.1677768679444; Thu, 02 Mar 2023 06:51:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768679; cv=none; d=google.com; s=arc-20160816; b=D1JBxI3cwKgaYZLiq4QuY4z1NtnvsyWsnoIcZPHmOv6295BWqIOEeVfr0kPV94PwIu 8zh8HFfr0DCAedQao3SFqqvXN++pQ/byjOGkprkIlpr/TKVXCNgcYxry2M0UwwtITOBd hXN5dq4ZqMzhPkwY8kI+ly26XpfnJs+aBVVP/aNrTnqBupjnP7gcjgt1zxzUL2leB/b/ GC5n/Yb1ANPHK3VVHFLpvOJ9PMKthvXwa/MAnfuoKfrjEHQGjZ7fwRjCrC0y2wubp6yR HDYzrReLLL40KSrGuYRT577MQV7gRcFsKgw5a6123AGmLsgM+p4dP2ztuytULr8+9e9k cToQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cmNLts5vqPwxZjnoqmJAK5KM0jk9L3qN7mSXGcOYJCw=; b=rQQfooMyocGSJ+HPMZ4nbBtdm2BdtZHkuPBokEpJXyWwHP/bkkmmhevw2PDqNh6L+9 mO0ljoelkNizvTKu3geh0j5Kn09nOVYewSDO3EQ/KlNNSXvDxFn6sd/dKyottI/q3sqo a09K+aMes2l++Ys3jD6UiwQW4WRKEpdl+y1QV6bdIn0NVzpClnD2ZwkNbDoTks3B0k/3 u0caffaZzSWxnBHF2bHr6fLFYupEQMJNW79GAy3Oqj3wl1bQ6SQhUGp+gaVQJ02Awd3e oOmgmj+gu/7qviEYDggS4AvjI3Q347hLb85V2Mqu4QRTEj8dkgjd1swONgwlbNZ8pS7T FDLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nk19-20020a17090b195300b0023670bc014dsi2462146pjb.110.2023.03.02.06.49.50; Thu, 02 Mar 2023 06:51:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbjCBOry (ORCPT + 99 others); Thu, 2 Mar 2023 09:47:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbjCBOrt (ORCPT ); Thu, 2 Mar 2023 09:47:49 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAED841B72 for ; Thu, 2 Mar 2023 06:47:47 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003rI-24; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDa-001LrA-9m; Thu, 02 Mar 2023 15:47:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Zpf-Dq; Thu, 02 Mar 2023 15:47:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/29] platform/x86: amilo-rfkill: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:09 +0100 Message-Id: <20230302144732.1903781-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1623; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=A8djoGpUAgNgkbWQ39wAp8VsGIh4VFkpPhaldfySJwA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaZ2pVqagkhwomGyOVT91iRR36ZU9e7wuLcT JPIITqf5Z2JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2mQAKCRDB/BR4rcrs CTfKB/95zYHTwLm7M3dAiiZI2Y5CA2UCdwVZr59pVKuWqZJ0rNZ5bUV9ygA/PIwL2AV90a5y6w/ EfytQEvPQhocXUu5Lo+e7yMqsvA5/9aclOMQONCv8MbV4zrudSKGnMXvPjNaUojoWyjDgdfc3Bv 83GB0TOQgKwNlAjktslFxkS0Rz+VrYBtxR8H5U1+S0LbSKUewDWRBJN9Uj4uPekHcllZJdbkd7L FYlTmEQcPSsiWX2IeURMmWxnOdyFIxLnhPz/BJiKrLaWT6m+0K5EwG8qwQDFLMfFrY2XaKmQRVf b3xZ7ijEMIYtc4j6EOrERAbky6dDSgM4tUJvz/SWfn9QQMHo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267970345989708?= X-GMAIL-MSGID: =?utf-8?q?1759267970345989708?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/amilo-rfkill.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/amilo-rfkill.c b/drivers/platform/x86/amilo-rfkill.c index 3e313c4d538d..efcf909786a5 100644 --- a/drivers/platform/x86/amilo-rfkill.c +++ b/drivers/platform/x86/amilo-rfkill.c @@ -124,11 +124,10 @@ static int amilo_rfkill_probe(struct platform_device *device) return rc; } -static int amilo_rfkill_remove(struct platform_device *device) +static void amilo_rfkill_remove(struct platform_device *device) { rfkill_unregister(amilo_rfkill_dev); rfkill_destroy(amilo_rfkill_dev); - return 0; } static struct platform_driver amilo_rfkill_driver = { @@ -136,7 +135,7 @@ static struct platform_driver amilo_rfkill_driver = { .name = KBUILD_MODNAME, }, .probe = amilo_rfkill_probe, - .remove = amilo_rfkill_remove, + .remove_new = amilo_rfkill_remove, }; static int __init amilo_rfkill_init(void)