From patchwork Thu Mar 2 14:47:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63435 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273342wrd; Thu, 2 Mar 2023 06:51:06 -0800 (PST) X-Google-Smtp-Source: AK7set+7gSYOwWTH6ESTNMnLN6Z2CXK73IxFy4PFEkRihkb+iCPYbj3i4CMqkBL+h3RkHrf/McEO X-Received: by 2002:a17:907:6d01:b0:8b1:76ca:f228 with SMTP id sa1-20020a1709076d0100b008b176caf228mr12417304ejc.39.1677768666415; Thu, 02 Mar 2023 06:51:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768666; cv=none; d=google.com; s=arc-20160816; b=wuI11uOFPXQrr+rEsStxp5ZXiHI/mnONFwiXbQqCz7/3vm2FM+Xi3m7X6zzhd/bKPu fxACUTy8JY2YSYl2MyNxLstI5kCzbsaFlNIvJqc05y+hwVlGJs5RMzg6MwCzcfCZgdf6 hPQDIVauVnkcCX9bFur3nA0Xcuhjme53jqCFNksEZOSC1wWmQxjMMbL9w5LJOsGWzLaZ PV6tyEvTrCfh6oAmND06hkHE8XDIUAKK0Tu8fUXDQ18zG7KSiS0fZIaGpaamA1o4Q1zq yUhTcPf1JDm/6EVnoX0XUQihcrULvm2xkSg8WNZUcNBdGxOSGrT16rqyk1Fvmc2k+Nxy tbSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zbBGip6n+u68FKN/wYbMxmbnusLqfshDeM5saryOohA=; b=cUlODgP1SRZyLBBnKf1xxRRWW+lm53d35qlGkEwi1wel0ey5xDYAT404KlueAfktPj Glgh7rd+nPZYxHxr9LiHTtZKtuPjGhl9pD85NEwsLLmmLpZiha+0MzcdzJLzxQanXpdi MJAaHXMFuXBM51fWzKpb3CFt68dm3hXZh3/0A2r+P9ZOdLYw/lr221xywlGfYhUEdg3f /5M3pewVIRLWBT2jNaewaEUOC3U4u/g4pYXEzjLVODocyfywMZICSSai05RHZZENyTKr Y5zFN1NmulgnI50zS58BH1Tct/lwGPSzPhpz/JsgyvPV5Gxk07U+p268N9Ce9VuT03PM GMrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o19-20020a1709062e9300b008b17b550d11si2912806eji.382.2023.03.02.06.50.42; Thu, 02 Mar 2023 06:51:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbjCBOsL (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbjCBOrv (ORCPT ); Thu, 2 Mar 2023 09:47:51 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED5C346091 for ; Thu, 2 Mar 2023 06:47:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDa-0003rA-P8; Thu, 02 Mar 2023 15:47:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDa-001Lr6-0g; Thu, 02 Mar 2023 15:47:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Zpb-7B; Thu, 02 Mar 2023 15:47:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Shyam Sundar S K , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/29] platform/x86: amd: pmf: core: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:08 +0100 Message-Id: <20230302144732.1903781-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1749; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=NLxovv9AqdM9/bwpLuxYogacX4f0kVeQEwMkH3uF2MA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaVdEf8Iym4jEzQzhQOe04S9Uf9m2gLZ0/MD dAnrq4FWveJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2lQAKCRDB/BR4rcrs CRpWB/9pbIaMZy87nfOk+7vTzUoPV7iOdFI8iZOP8bZ1BwiUHKqUYQCWNjrPCRQCbmCWv6kEMAU h/cdt0PUc804WzHHwOK03oQAe6cunZA+fKZaw7S+82drmJ4SdfIVOHsnzvS1sT10+WlDYWvKqJ2 zciWXyZ6eAzSx/TIpMgW6hFPWU91S4U1+kJn85DkINmRPHG8dKY/hvfvPmXvKp2aYCFQ5solVEx HckHwDmEd8Ni8KprTu711Vz1VuJqR7rD8dgBe2pqF2MT++gK58rN+Y/5I6OJulOwSiAA2wLMKVt qQ1Fti6zrucbjL+y4WT+Llo6RhgjGzaDVaygHcTZA6sCVcYU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267957092278022?= X-GMAIL-MSGID: =?utf-8?q?1759267957092278022?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/amd/pmf/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c index da23639071d7..800ca2c998d3 100644 --- a/drivers/platform/x86/amd/pmf/core.c +++ b/drivers/platform/x86/amd/pmf/core.c @@ -402,7 +402,7 @@ static int amd_pmf_probe(struct platform_device *pdev) return 0; } -static int amd_pmf_remove(struct platform_device *pdev) +static void amd_pmf_remove(struct platform_device *pdev) { struct amd_pmf_dev *dev = platform_get_drvdata(pdev); @@ -413,7 +413,6 @@ static int amd_pmf_remove(struct platform_device *pdev) mutex_destroy(&dev->lock); mutex_destroy(&dev->update_mutex); kfree(dev->buf); - return 0; } static const struct attribute_group *amd_pmf_driver_groups[] = { @@ -428,7 +427,7 @@ static struct platform_driver amd_pmf_driver = { .dev_groups = amd_pmf_driver_groups, }, .probe = amd_pmf_probe, - .remove = amd_pmf_remove, + .remove_new = amd_pmf_remove, }; module_platform_driver(amd_pmf_driver);