From patchwork Thu Mar 2 14:47:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63437 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273427wrd; Thu, 2 Mar 2023 06:51:15 -0800 (PST) X-Google-Smtp-Source: AK7set/HomXwD0D3cD55xl82Q9kioKDJQFdCnYaRVy6d9QVIcbx+aY/vHD0fLjgsh8DCZleSyBN5 X-Received: by 2002:aa7:d959:0:b0:4ad:738b:6706 with SMTP id l25-20020aa7d959000000b004ad738b6706mr2543806eds.2.1677768675377; Thu, 02 Mar 2023 06:51:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768675; cv=none; d=google.com; s=arc-20160816; b=bFUtkHTyWHZ+UVceqpaihVMsy7rW0WLb3Iuu93D3/45Qr5K5L3wbFTnlRtdo4u1kRQ i1pUuQSBv9s20EhX2uMBGJWIhap83Sl1vhVVxZ0+GJykjtKNbF6F7AvEDfDZ+n5ZbSkA 94J1EeUn9uNHFxsF181tJoQF7/hMuGz8KjOQ9RcW6lXHjoMNjxcq03ufigs9TLUit24o Yv0fFlSa2w2iY2GhyiZgubfw5Jk+FBiXZvXAgfU4wfxeAR3RW8c8oQJpgBpCmzL0JJCf 87sO8mb+u1m3DyQ7ggLbtrYpPj6HTT7L2CTlC8/mm7ozn+JQLuwtOJOhdWvN4NAnEf/v lF8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=efiQCCCM/o/zjelvOrQvnpwXOqb9PAWso7ZB9YVO4BI=; b=qbJJjnBoKVynP7aQ39u5JZM24LonV+kVOntp00pmK3iSCXRG2beM0aTMwfi+niKjUS Szx76X8PdmajqGWyq/7I57SzbMYeEeXLmijCOxu3epLoTwBRv1QdIzJQSu+RPRnAmPIf v7Ryz0lK/NrN6X+ZLjZge+W/MKQDMIDtvl7sumSUiFlpDnwzf/cFM0c8Us+yIwxR2Og7 AFYbh0bqnQ7uHpvMxw5fx0JaaKPrcCq9bOmsNpXtHYeGrw2P2y8JhnV9QkQDlYFWIlDw RrXQWa3yib7CjgYN1f1KSWH4ReGj+TvxZ4uV5jwk+eW6B+o1ZzBwrJqnIZF++2iPV15l zSRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a20-20020a170906245400b008f0ba094bb6si16654922ejb.707.2023.03.02.06.50.52; Thu, 02 Mar 2023 06:51:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230195AbjCBOsR (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbjCBOrw (ORCPT ); Thu, 2 Mar 2023 09:47:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA8E460B4 for ; Thu, 2 Mar 2023 06:47:49 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003r9-2P; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDZ-001Lr2-Mo; Thu, 02 Mar 2023 15:47:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDY-001ZpT-RI; Thu, 02 Mar 2023 15:47:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Naveen Krishna Chatradhi , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , Carlos Bilbao , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/29] platform/x86: amd: hsmp: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:06 +0100 Message-Id: <20230302144732.1903781-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1461; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=qgD6Fu+TwEiUbD68TORw2X6DDiB/hL0lY5kxPSiVZIw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaNEhHeZybd0i9WVR1+OP5V0++Ct8ZKYQXPY SR2dxnaPy+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2jQAKCRDB/BR4rcrs CQblCACBa4XFyZ4EUSa9UsFxt52M+imRA1OkAW1aKR1jxMnUiTcge54noOrMVuW74wFatFUm4NC 1Q8G6WymgHcOyA8lgiaCEnTRX0CQ+1XixLaF+e2arwIIip0NHBg3BLbkUiz9d63pw26wRnvASeU 2SpxelmAMaY+szOQFdktT0TsizOcP9P52roVXL85e/zjyuRORno1h4XmoKKwNPVn0lZI5tfR0TP fiGLEacB1nOkpS3IoN0ffYQft7CtBooBfAJs38jV2M23JHOrwCStfofeEMw5PJeqkW9ui9n3jKB qgtmpVfYYKak/c9x/8OUs1sLGdLqfTcyJcIHxklaGVrNr2Rk X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267966751243689?= X-GMAIL-MSGID: =?utf-8?q?1759267966751243689?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/amd/hsmp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c index 521c6a229362..31382ef52efb 100644 --- a/drivers/platform/x86/amd/hsmp.c +++ b/drivers/platform/x86/amd/hsmp.c @@ -340,16 +340,14 @@ static int hsmp_pltdrv_probe(struct platform_device *pdev) return misc_register(&hsmp_device); } -static int hsmp_pltdrv_remove(struct platform_device *pdev) +static void hsmp_pltdrv_remove(struct platform_device *pdev) { misc_deregister(&hsmp_device); - - return 0; } static struct platform_driver amd_hsmp_driver = { .probe = hsmp_pltdrv_probe, - .remove = hsmp_pltdrv_remove, + .remove_new = hsmp_pltdrv_remove, .driver = { .name = DRIVER_NAME, },